[OGNL-253] Every getter/setter method lookup that misses does a second lookup

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.0.13, 3.1.2
• Component/s: Core Runtime
• Assignee: Unassigned
• Reporter: Jasper Rosenberg
• Created: 16/Dec/15 16:51
• Updated: 16/Dec/15 16:51

Description

Regarding https://github.com/jkuhnert/ognl/pull/12

In getSetMethod/getGetMethod it calls contains after getting a null method back. This means that anytime we ever have a property miss for a class we are going to do two lookups in the cache (the get and contains). This isn't great because property misses can happen a lot.

The solution is actually trivial. The ClassPropertyMethodCache is already storing a special value for null internally. It should just return it, and the two callers can check for the special value and return null rather than making the containsKey extra call.