[OGNL-152] OGNLRuntime doesn't handle parameterized method arguments correctly

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.7.3
• Fix Version/s: 3.0
• Component/s: Core Runtime
• Environment: Tried on JDK 1.6. Should affect 1.5 as well
• Flags: Important
• Assignee: Disabled - L-u-k-a-s-z Lenart - OpenSymphony
• Reporter: Anshuman
• Created: 25/Jan/09 05:16
• Updated: 13/Mar/10 09:36
• Resolved: 13/Mar/10 09:36

Description

OGNLRuntime.findParameterTypes(Class type, Method m) caches the parameter types based on the method only. This is incorrect as further calls to the same inherited method (possibly through different child classes with different generic type specification) will always yield parameter types for the first call.

The cache should use the class on which the method is called or it will not be able to handle generic parameter types correctly.

e.g.

Class GenericParent<T> { public void save(T entity){}}

Class StringChild<String> {}

Class LongChild<Long> {}

OGNLRuntime.findParameterTypes(Class type, Method m) should return String.class for StringChild and Long.class for LongChild.

See attached test-case for details