[OGNL-121] Race condition in SimpleNode#evaluateGetValueBody(OgnlContext, Object)

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.9
• Fix Version/s: 2.7.2
• Flags: Patch
• Assignee: Jesse Kuhnert
• Reporter: Toshihiro Nakamura
• Created: 08/Sep/07 16:45
• Updated: 21/Jan/08 14:38
• Resolved: 21/Jan/08 14:38

Description

SimpleNode#evaluateGetValueBody(OgnlContext, Object) might return null.

I have a patch that resolves the issue for version 2.6.9. Same issue might be in the above vesions.

 

Index: C:/User/Work/workspace/ognl/src/java/ognl/SimpleNode.java

===================================================================

--- C:/User/Work/workspace/ognl/src/java/ognl/SimpleNode.java	(revision 139)

+++ C:/User/Work/workspace/ognl/src/java/ognl/SimpleNode.java	(working copy)

@@ -44,7 +44,7 @@

     protected OgnlParser    parser;

 

     private boolean         constantValueCalculated;

-    private boolean         hasConstantValue;

+    private volatile boolean hasConstantValue;

     private Object          constantValue;

 

     public SimpleNode(int i) {

@@ -162,10 +162,11 @@

         context.setCurrentNode(this);

         if (!constantValueCalculated) {

             constantValueCalculated = true;

-            hasConstantValue = isConstant(context);

-            if (hasConstantValue) {

+            boolean constant = isConstant(context);

+            if (constant) {

                 constantValue = getValueBody(context, source);

             }

+            hasConstantValue = constant;

         }

         return hasConstantValue ? constantValue : getValueBody(context, source);

     }