Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: pricat
    • Labels:
      None

      Description

      ofbiz-plugins pricat Component

      Affected by the empty rows, the number of rows actually imported is less than rows of excel.

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        No worries Liang, you are welcome contributing

        Show
        jacques.le.roux Jacques Le Roux added a comment - No worries Liang, you are welcome contributing
        Hide
        zhang.liang zhang.liang added a comment -

        Jacques Le Roux Sorry, made some trouble for you, Thanks for your reminding. I'll be careful in the future.

        Show
        zhang.liang zhang.liang added a comment - Jacques Le Roux Sorry, made some trouble for you, Thanks for your reminding. I'll be careful in the future.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Thanks Liang,

        Your patch is in trunk at revision 1809270; previous branches are not concerned.

        The pricat component was missing in Jira I added it.

        2 small remarks:

        1. We don't uset tabs but 4 spaces instead
        2. Please create your patches from the root to have a complete path from there. Easier when patching

        See https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices for details (look for "Guidelines" notably, reading the whole page is worth it)

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Thanks Liang, Your patch is in trunk at revision 1809270; previous branches are not concerned. The pricat component was missing in Jira I added it. 2 small remarks: We don't uset tabs but 4 spaces instead Please create your patches from the root to have a complete path from there. Easier when patching See https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices for details (look for "Guidelines" notably, reading the whole page is worth it)

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            zhang.liang zhang.liang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development