[OFBIZ-9719] [FB] Package org.apache.ofbiz.entity.model - ASF JIRA

Details

Type: Sub-task
Status: Closed
Priority: Minor
Resolution: Implemented
Affects Version/s: Trunk
Fix Version/s: 17.12.01
Component/s: ALL APPLICATIONS, ALL COMPONENTS
Labels:
None

Description

ModelEntity.java:-1, SE_BAD_FIELD

Se: Class org.apache.ofbiz.entity.model.ModelEntity defines non-transient non-serializable instance field modelInfo

This Serializable class defines a non-primitive instance field which is neither transient, Serializable, or java.lang.Object, and does not appear to implement the Externalizable interface or the readObject() and writeObject() methods. Objects of this class will not be deserialized correctly if a non-Serializable object is stored in this field.

ModelEntity.java:61, SE_NO_SERIALVERSIONID

SnVI: org.apache.ofbiz.entity.model.ModelEntity is Serializable; consider declaring a serialVersionUID

This class implements the Serializable interface, but does not define a serialVersionUID field. A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.

ModelEntity.java:1338, EQ_COMPARETO_USE_OBJECT_EQUALS

Eq: org.apache.ofbiz.entity.model.ModelEntity defines compareTo(ModelEntity) and uses Object.equals()

This class defines a compareTo(...) method but inherits its equals() method from java.lang.Object. Generally, the value of compareTo should return zero if and only if equals returns true. If this is violated, weird and unpredictable failures will occur in classes such as PriorityQueue. In Java 5 the PriorityQueue.remove method uses the compareTo method, while in Java 6 it uses the equals method.

From the JavaDoc for the compareTo method in the Comparable interface:

It is strongly recommended, but not strictly required that (x.compareTo==0) == (x.equals). Generally speaking, any class that implements the Comparable interface and violates this condition should clearly indicate this fact. The recommended language is "Note: this class has a natural ordering that is inconsistent with equals."
ModelEntity.java:1502, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

RCN: Redundant nullcheck of fieldIter, which is known to be non-null in org.apache.ofbiz.entity.model.ModelEntity.toXmlElement(Document, String)

This method contains a redundant check of a known non-null value against the constant null.

ModelEntity.java:1520, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

RCN: Redundant nullcheck of relIter, which is known to be non-null in org.apache.ofbiz.entity.model.ModelEntity.toXmlElement(Document, String)

This method contains a redundant check of a known non-null value against the constant null.

ModelEntity.java:1527, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

RCN: Redundant nullcheck of idxIter, which is known to be non-null in org.apache.ofbiz.entity.model.ModelEntity.toXmlElement(Document, String)

This method contains a redundant check of a known non-null value against the constant null.

ModelEntityChecker.java:98, DM_CONVERT_CASE

Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.entity.model.ModelEntityChecker.checkEntities(Delegator, List)

A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the

String.toUpperCase( Locale l )
String.toLowerCase( Locale l )
versions instead.

ModelEntityChecker.java:288, MS_PKGPROTECT

MS: org.apache.ofbiz.entity.model.ModelEntityChecker.rwArray should be package protected

A mutable static field could be changed by malicious code or by accident. The field could be made package protected to avoid this vulnerability.

ModelField.java:40, SE_NO_SERIALVERSIONID

SnVI: org.apache.ofbiz.entity.model.ModelField is Serializable; consider declaring a serialVersionUID

This class implements the Serializable interface, but does not define a serialVersionUID field. A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.

ModelField.java:150, DM_CONVERT_CASE

Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.entity.model.ModelField.create(ModelEntity, Element, boolean)

A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the

String.toUpperCase( Locale l )
String.toLowerCase( Locale l )
versions instead.

ModelField.java:151, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

RCN: Redundant nullcheck of encrypt, which is known to be non-null in org.apache.ofbiz.entity.model.ModelField.create(ModelEntity, Element, boolean)

This method contains a redundant check of a known non-null value against the constant null.

ModelField.java:180, DM_CONVERT_CASE

Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.entity.model.ModelField.create(ModelEntity, DatabaseUtil$ColumnCheckInfo, ModelFieldTypeReader)

A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the

String.toUpperCase( Locale l )
String.toLowerCase( Locale l )
versions instead.

ModelField.java:306, DM_CONVERT_CASE

Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.entity.model.ModelField.toXmlElement(Document)

A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the

String.toUpperCase( Locale l )
String.toLowerCase( Locale l )
versions instead.

ModelFieldType.java:-1, SE_BAD_FIELD

Se: Class org.apache.ofbiz.entity.model.ModelFieldType defines non-transient non-serializable instance field jdbcValueHandler

This Serializable class defines a non-primitive instance field which is neither transient, Serializable, or java.lang.Object, and does not appear to implement the Externalizable interface or the readObject() and writeObject() methods. Objects of this class will not be deserialized correctly if a non-Serializable object is stored in this field.

ModelFieldType.java:35, SE_NO_SERIALVERSIONID

SnVI: org.apache.ofbiz.entity.model.ModelFieldType is Serializable; consider declaring a serialVersionUID

This class implements the Serializable interface, but does not define a serialVersionUID field. A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.

ModelFieldType.java:93, DM_CONVERT_CASE

Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.entity.model.ModelFieldType.stringLength()

A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the

String.toUpperCase( Locale l )
String.toLowerCase( Locale l )
versions instead.

ModelFieldType.java:95, RV_CHECK_FOR_POSITIVE_INDEXOF

RV: org.apache.ofbiz.entity.model.ModelFieldType.stringLength() checks to see if result of String.indexOf is positive

The method invokes String.indexOf and checks to see if the result is positive or non-positive. It is much more typical to check to see if the result is negative or non-negative. It is positive only if the substring checked for occurs at some place other than at the beginning of the String.

ModelFieldTypeReader.java:49, SE_NO_SERIALVERSIONID

SnVI: org.apache.ofbiz.entity.model.ModelFieldTypeReader is Serializable; consider declaring a serialVersionUID

This class implements the Serializable interface, but does not define a serialVersionUID field. A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.

ModelGroupReader.java:55, SE_NO_SERIALVERSIONID

SnVI: org.apache.ofbiz.entity.model.ModelGroupReader is Serializable; consider declaring a serialVersionUID

This class implements the Serializable interface, but does not define a serialVersionUID field. A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.

ModelGroupReader.java:103, DC_DOUBLECHECK

DC: Possible doublecheck on org.apache.ofbiz.entity.model.ModelGroupReader.groupCache in org.apache.ofbiz.entity.model.ModelGroupReader.getGroupCache(String)

This method may contain an instance of double-checked locking. This idiom is not correct according to the semantics of the Java memory model. For more information, see the web page http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html.

ModelIndex.java:-1, SE_BAD_FIELD

Se: Class org.apache.ofbiz.entity.model.ModelIndex defines non-transient non-serializable instance field fields

This Serializable class defines a non-primitive instance field which is neither transient, Serializable, or java.lang.Object, and does not appear to implement the Externalizable interface or the readObject() and writeObject() methods. Objects of this class will not be deserialized correctly if a non-Serializable object is stored in this field.

ModelIndex.java:49, SE_NO_SERIALVERSIONID

SnVI: org.apache.ofbiz.entity.model.ModelIndex is Serializable; consider declaring a serialVersionUID

This class implements the Serializable interface, but does not define a serialVersionUID field. A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.

ModelIndex.java:80, DM_CONVERT_CASE

Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.entity.model.ModelIndex.create(ModelEntity, Element)

A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the

String.toUpperCase( Locale l )
String.toLowerCase( Locale l )
versions instead.

ModelKeyMap.java:35, SE_NO_SERIALVERSIONID

SnVI: org.apache.ofbiz.entity.model.ModelKeyMap is Serializable; consider declaring a serialVersionUID

This class implements the Serializable interface, but does not define a serialVersionUID field. A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.

ModelReader.java:60, SE_NO_SERIALVERSIONID

SnVI: org.apache.ofbiz.entity.model.ModelReader is Serializable; consider declaring a serialVersionUID

This class implements the Serializable interface, but does not define a serialVersionUID field. A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.

ModelReader.java:188, DC_DOUBLECHECK

DC: Possible doublecheck on org.apache.ofbiz.entity.model.ModelReader.entityCache in org.apache.ofbiz.entity.model.ModelReader.getEntityCache()

This method may contain an instance of double-checked locking. This idiom is not correct according to the semantics of the Java memory model. For more information, see the web page http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html.

ModelReader.java:242, BC_UNCONFIRMED_CAST_OF_RETURN_VALUE

BC: Unchecked/unconfirmed cast from org.apache.ofbiz.entity.model.ModelEntity to org.apache.ofbiz.entity.model.ModelViewEntity of return value in org.apache.ofbiz.entity.model.ModelReader.getEntityCache()

This code performs an unchecked cast of the return value of a method. The code might be calling the method in such a way that the cast is guaranteed to be safe, but FindBugs is unable to verify that the cast is safe. Check that your program logic ensures that this cast will not fail.

ModelReader.java:344, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

RCN: Redundant nullcheck of relatedEnt, which is known to be non-null in org.apache.ofbiz.entity.model.ModelReader.getEntityCache()

This method contains a redundant check of a known non-null value against the constant null.

ModelRelation.java:55, SE_NO_SERIALVERSIONID

SnVI: org.apache.ofbiz.entity.model.ModelRelation is Serializable; consider declaring a serialVersionUID

This class implements the Serializable interface, but does not define a serialVersionUID field. A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.

ModelUtil.java:47, DM_CONVERT_CASE

Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.entity.model.ModelUtil.upperFirstChar(String)

A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the

String.toUpperCase( Locale l )
String.toLowerCase( Locale l )
versions instead.

ModelUtil.java:62, DM_CONVERT_CASE

Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.entity.model.ModelUtil.lowerFirstChar(String)

A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the

String.toUpperCase( Locale l )
String.toLowerCase( Locale l )
versions instead.

ModelUtil.java:285, UC_USELESS_CONDITION
Condition has no effect

This condition always produces the same result as the value of the involved variable was narrowed before. Probably something else was meant or condition can be removed.

ModelViewEntity.java:-1, CI_CONFUSED_INHERITANCE

CI: Class org.apache.ofbiz.entity.model.ModelViewEntity$ModelConversion is final but declares protected field org.apache.ofbiz.entity.model.ModelViewEntity$ModelConversion.aliasName