Details

      Description

      ThreadPool.java:135, REC_CATCH_EXCEPTION
      REC: Exception is caught when Exception is not thrown in new org.apache.ofbiz.service.config.model.ThreadPool(Element)

      This method uses a try-catch block that catches Exception objects, but Exception is not thrown within the try block, and RuntimeException is not explicitly caught. It is a common bug pattern to say try

      { ... }

      catch (Exception e)

      { something }

      as a shorthand for catching a number of types of exception each of whose catch blocks is identical, but this construct also accidentally catches RuntimeException as well, masking potential bugs.

      A better approach is to either explicitly catch the specific exceptions that are thrown, or to explicitly catch RuntimeException exception, rethrow it, and then catch all non-Runtime Exceptions, as shown below:

      try

      { ... }

      catch (RuntimeException e)

      { throw e; }

      catch (Exception e)

      { ... deal with all non-runtime exceptions ... }

        Activity

        Hide
        jleichert Julian Leichert added a comment -

        Changed Multiple Catches of Exception to Multi-catch.

        Show
        jleichert Julian Leichert added a comment - Changed Multiple Catches of Exception to Multi-catch.
        Hide
        mbrohl Michael Brohl added a comment -

        Hi Julian,

        this patch wrongly changes the exception messages, please check and provide a correct patch.

        Show
        mbrohl Michael Brohl added a comment - Hi Julian, this patch wrongly changes the exception messages, please check and provide a correct patch.
        Hide
        jleichert Julian Leichert added a comment -

        Hi Michael,
        I corrected the exception messages.

        Show
        jleichert Julian Leichert added a comment - Hi Michael, I corrected the exception messages.
        Hide
        mbrohl Michael Brohl added a comment -

        Thanks Julian,

        your patch is in trunk r1811699.

        Show
        mbrohl Michael Brohl added a comment - Thanks Julian, your patch is in trunk r1811699.

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            jleichert Julian Leichert
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development