[OFBIZ-9640] [FB] Package org.apache.ofbiz.common.preferences

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: Trunk
• Fix Version/s: 17.12.01
• Component/s: framework
• Assignee: Michael Brohl
• Reporter: Dennis Balkir
• Created: 25/Aug/17 14:55
• Updated: 07/Oct/17 14:52
• Resolved: 07/Oct/17 14:52

Description

• PreferenceWorker.java:90, RpC_REPEATED_CONDITIONAL_TEST
  RpC: Repeated conditional test in org.apache.ofbiz.common.preferences.PreferenceWorker.checkCopyPermission(DispatchContext, Map)

The code contains a conditional test is performed twice, one right after the other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to be something else (e.g., x == 0 || y == 0).

• PreferenceWorker.java:90, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
  RCN: Redundant nullcheck of userLoginIdArg, which is known to be non-null in org.apache.ofbiz.common.preferences.PreferenceWorker.checkCopyPermission(DispatchContext, Map)

This method contains a redundant check of a known non-null value against the constant null.