Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: framework
    • Labels:
      None

      Description

      SecurityFactory.java:-1, CI_CONFUSED_INHERITANCE, Priorit├Ąt: Niedrig
      CI: Class org.apache.ofbiz.security.SecurityFactory$OFBizSecurity is final but declares protected field org.apache.ofbiz.security.SecurityFactory$OFBizSecurity.simpleRoleEntity

      This class is declared to be final, but declares fields to be protected. Since the class is final, it can not be derived from, and the use of protected is confusing. The access modifier for the field should be changed to private or public to represent the true use for the field.

        Activity

        Hide
        Dennis Balkir Dennis Balkir added a comment -
        • Diamond Operators fixed
        • Line 90: changed the assigned field to private, since it is a final class and protected is a confusing declaration at this point and the field is only used in this class

        PS: package security isn't available to choose from, while creating a new sub

        Show
        Dennis Balkir Dennis Balkir added a comment - Diamond Operators fixed Line 90: changed the assigned field to private, since it is a final class and protected is a confusing declaration at this point and the field is only used in this class PS: package security isn't available to choose from, while creating a new sub
        Hide
        mbrohl Michael Brohl added a comment -

        Thanks Dennis,

        your patch is in trunk r1811429.

        Show
        mbrohl Michael Brohl added a comment - Thanks Dennis, your patch is in trunk r1811429.

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            Dennis Balkir Dennis Balkir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development