[OFBIZ-9635] [FB] Package org.apache.ofbiz.security

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: Trunk
• Fix Version/s: 17.12.01
• Component/s: framework
• Assignee: Michael Brohl
• Reporter: Dennis Balkir
• Created: 25/Aug/17 13:38
• Updated: 07/Oct/17 14:16
• Resolved: 07/Oct/17 14:16

Description

SecurityFactory.java:-1, CI_CONFUSED_INHERITANCE, Priorität: Niedrig
CI: Class org.apache.ofbiz.security.SecurityFactory$OFBizSecurity is final but declares protected field org.apache.ofbiz.security.SecurityFactory$OFBizSecurity.simpleRoleEntity

This class is declared to be final, but declares fields to be protected. Since the class is final, it can not be derived from, and the use of protected is confusing. The access modifier for the field should be changed to private or public to represent the true use for the field.