Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: framework
    • Labels:
      None

      Description

      • PeriodWorker.java:34, MS_SHOULD_BE_FINAL
        MS: org.apache.ofbiz.common.period.PeriodWorker.module isn't final but should be

      This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.

        Activity

        Hide
        Dennis Balkir Dennis Balkir added a comment -
        • changed the parameter to final and private, to prevent possible vulnerability through external code changing
        Show
        Dennis Balkir Dennis Balkir added a comment - changed the parameter to final and private, to prevent possible vulnerability through external code changing
        Hide
        mbrohl Michael Brohl added a comment -

        Thanks Dennis,

        your patch is in trunk r1811426.

        Show
        mbrohl Michael Brohl added a comment - Thanks Dennis, your patch is in trunk r1811426.

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            Dennis Balkir Dennis Balkir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development