Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9620

Extend SecurityGroup entity and add name/groupName field

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: None
    • Labels:
      None

      Description

      Currently, SecurityGroup entity has groupId and description fields in that, it should also have groupName/name field as well, as a description can be very long and groupName can be used to represent SecurityGroup in a better manner.

      1. OFBIZ-9620.patch
        21 kB
        Suraj Khurana

        Activity

        Hide
        suraj.khurana Suraj Khurana added a comment -

        One reference is while assigning a security group to party from party screen, very long security groups with descriptions are mentioned, they can be shortened up to some logical group names.

        Show
        suraj.khurana Suraj Khurana added a comment - One reference is while assigning a security group to party from party screen, very long security groups with descriptions are mentioned, they can be shortened up to some logical group names.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Thanks Suraj,

        Yes indeed I see no reasons why not to add this field

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Thanks Suraj, Yes indeed I see no reasons why not to add this field
        Hide
        suraj.khurana Suraj Khurana added a comment -

        Here is the proposed patch wit proper fix.
        Please have a look into it. I have also added groupName to all available data and some relevant forms as well.

        Show
        suraj.khurana Suraj Khurana added a comment - Here is the proposed patch wit proper fix. Please have a look into it. I have also added groupName to all available data and some relevant forms as well.
        Hide
        rishisolankii Rishi Solanki added a comment -

        Suraj Khurana Thanks for providing patch for the improvement. Your patch has been committed in revision 1809386.

        Show
        rishisolankii Rishi Solanki added a comment - Suraj Khurana Thanks for providing patch for the improvement. Your patch has been committed in revision 1809386.
        Hide
        rishisolankii Rishi Solanki added a comment -

        This will simply add an no pk field to entity, and simply add field on server start. Do we need to add this information at - https://cwiki.apache.org/confluence/x/LoBr

        Community please suggest. Thanks!

        Show
        rishisolankii Rishi Solanki added a comment - This will simply add an no pk field to entity, and simply add field on server start. Do we need to add this information at - https://cwiki.apache.org/confluence/x/LoBr Community please suggest. Thanks!
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Nope, thanks Rishi. There is no real data model change. You can refer to explanations at top of this page.

        Committers should make an entry in this list if your revision causes a need for any manual data migration or other update steps in production instances:

        • A file change which need additional unload/reload/convert activities
        • Any tables which can be deleted(dropped) because they are not used anymore.
        • Any other required activity to keep your production site operational
        Show
        jacques.le.roux Jacques Le Roux added a comment - Nope, thanks Rishi. There is no real data model change. You can refer to explanations at top of this page. Committers should make an entry in this list if your revision causes a need for any manual data migration or other update steps in production instances: A file change which need additional unload/reload/convert activities Any tables which can be deleted(dropped) because they are not used anymore. Any other required activity to keep your production site operational
        Hide
        rishisolankii Rishi Solanki added a comment -

        Thanks Jacques Le Roux : My understanding is same that no need to add this information for tracking. Just wanted to make sure before making decision, so we are good with the ticket and no further action required.

        Thanks again for your help.

        Show
        rishisolankii Rishi Solanki added a comment - Thanks Jacques Le Roux : My understanding is same that no need to add this information for tracking. Just wanted to make sure before making decision, so we are good with the ticket and no further action required. Thanks again for your help.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks for your wokr Rishi

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks for your wokr Rishi

          People

          • Assignee:
            rishisolankii Rishi Solanki
            Reporter:
            suraj.khurana Suraj Khurana
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development