Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: framework
    • Labels:
      None

      Description

      Commonly used entities extended in data model component like UserLogin, UserLoginHistory, Visit etc can be merged to their existing definition only.

      1. OFBIZ-9581.patch
        3 kB
        Aditya Sharma
      2. OFBIZ-9581.patch
        20 kB
        Aditya Sharma

        Activity

        Hide
        deepak.dixit Deepak Dixit added a comment -

        Thanks Aditya for your contribution.

        This has been committed at ofbiz-framework trunk at r#1809376

        Show
        deepak.dixit Deepak Dixit added a comment - Thanks Aditya for your contribution. This has been committed at ofbiz-framework trunk at r#1809376
        Hide
        aditya.sharma Aditya Sharma added a comment -

        Updated patch with only applications/datamodel entities changes.

        Show
        aditya.sharma Aditya Sharma added a comment - Updated patch with only applications/datamodel entities changes.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Hi Aditya,

        I think we can keep framework entities untouch and only merge the extended enitity field in applications/datamodel only.
        No need to add extended field to framework entities.

        Show
        deepak.dixit Deepak Dixit added a comment - Hi Aditya, I think we can keep framework entities untouch and only merge the extended enitity field in applications/datamodel only. No need to add extended field to framework entities.
        Hide
        aditya.sharma Aditya Sharma added a comment -

        Merged all extended into existing definitions.
        I found a comment for PortalPage entity extension but there was no error merging the entity.
        <!-- defined as an extend and not directly in common to avoid dependencies between common and content -->

        Show
        aditya.sharma Aditya Sharma added a comment - Merged all extended into existing definitions. I found a comment for PortalPage entity extension but there was no error merging the entity. <!-- defined as an extend and not directly in common to avoid dependencies between common and content -->
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Good catch Aditya.

        Show
        deepak.dixit Deepak Dixit added a comment - Good catch Aditya.

          People

          • Assignee:
            deepak.dixit Deepak Dixit
            Reporter:
            aditya.sharma Aditya Sharma
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development