Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: base
    • Labels:
      None

      Description

      • ComparableRangeTests.java:82, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
        Return value of method without side effect is ignored

      This code calls a method and ignores the return value. However our analysis shows that the method (including its implementations in subclasses if any) does not produce any effect other than return value. Thus this call can be removed.

      We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. Common false-positive cases include:

      • The method is designed to be overridden and produce a side effect in other projects which are out of the scope of the analysis.
      • The method is called to trigger the class loading which may have a side effect.
      • The method is called just to get some exception.

      If you feel that our assumption is incorrect, you can use a @CheckReturnValue annotation to instruct FindBugs that ignoring the return value of this method is acceptable.

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Dennis,

        Your patch is in trunk at revision: 1804558

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Dennis, Your patch is in trunk at revision: 1804558
        Hide
        Dennis Balkir Dennis Balkir added a comment -
        • fixed some diamond operators
        • didn't fix the main issue (listed in description), because the method which was used, was only used for testing, which makes the issue irrelevant
        Show
        Dennis Balkir Dennis Balkir added a comment - fixed some diamond operators didn't fix the main issue (listed in description), because the method which was used, was only used for testing, which makes the issue irrelevant

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            Dennis Balkir Dennis Balkir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development