Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9525

MRP incorrectly computes quantity already received in open purchase order shipments

    Details

      Description

      The MRP algorithm incorrectly computes the quantity of items partially received in a purchase shipment because it leverages the OrderReadHelper.getItemShippedQuantity(...) method that is intended to be used to count the quantity shipped of a sales order.

      1. OFBIZ-9525_trunk.patch
        2 kB
        Amit Gadaley
      2. OFBIZ-9525_14.12.patch
        3 kB
        Amit Gadaley

        Activity

        Hide
        amit.gadaley Amit Gadaley added a comment -

        Provided patch for OFBiz 14.12 release. Thank you Jacopo Cappellato for your guidance.

        Show
        amit.gadaley Amit Gadaley added a comment - Provided patch for OFBiz 14.12 release. Thank you Jacopo Cappellato for your guidance.
        Hide
        amit.gadaley Amit Gadaley added a comment -

        Provided patch for OFBiz trunk release. Thank you, Jacopo Cappellato for your guidance.

        Show
        amit.gadaley Amit Gadaley added a comment - Provided patch for OFBiz trunk release. Thank you, Jacopo Cappellato for your guidance.
        Hide
        jacopoc Jacopo Cappellato added a comment -

        Amit, I see that in the proposed patch you have added a try/catch block with an empty catch block: it would be better to suppress it completely or, if there is a use case, add behavior to the block (e.g. add a log statement etc...).

        Show
        jacopoc Jacopo Cappellato added a comment - Amit, I see that in the proposed patch you have added a try/catch block with an empty catch block: it would be better to suppress it completely or, if there is a use case, add behavior to the block (e.g. add a log statement etc...).
        Hide
        amit.gadaley Amit Gadaley added a comment -

        Updated patch for trunk.

        Show
        amit.gadaley Amit Gadaley added a comment - Updated patch for trunk.
        Hide
        amit.gadaley Amit Gadaley added a comment -

        Updated patch for 14.12 release.

        Show
        amit.gadaley Amit Gadaley added a comment - Updated patch for 14.12 release.
        Hide
        jacopoc Jacopo Cappellato added a comment -

        Thanks Amit.
        Your patch has been committed in trunk rev. 1809594 and in release16.11 rev. 1809595

        Show
        jacopoc Jacopo Cappellato added a comment - Thanks Amit. Your patch has been committed in trunk rev. 1809594 and in release16.11 rev. 1809595

          People

          • Assignee:
            jacopoc Jacopo Cappellato
            Reporter:
            jacopoc Jacopo Cappellato
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development