[OFBIZ-9465] Replace Inline Javascript with External Javascript

• Type: Improvement
• Status: Reopened
• Priority: Major
• Resolution: Unresolved
• Assignee: Aditya Sharma
• Reporter: Aditya Sharma
• Created: 08/Jul/17 11:58
• Updated: 27/Feb/20 10:12

Description

As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline javascript for various macros like renderLookupField, makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be replaced with a generic code written as external javascript. Generic Javascript code should be written in OfbizUtil.js and appropriate classes or identifiers should be used for applying that. Any additional data can be passed with HTML 5 custom data attribute (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes).

As suggested by Jacques in https://s.apache.org/y8P1 will introduce require.js for the split javascript files in a sub-task.

Issue Links

• relates to: OFBIZ-10012 Alert message : "Developer: for lookups to work you must provide a form name!" appears when try to select contentId from Lookup

Sub-Tasks

• Replace Inline js with External js in renderTextareaField macro: Closed
• Replace Inline js with External js in renderDisplayField macro: Closed
• Replace Inline js with External js in makeHyperlinkString macro: Closed
• Replace Inline js with External js in renderFormClose macro: Closed
• Replace Inline js with External js in renderTextField macro: Closed
• Replace Inline js with External js in renderDateTimeField macro: Closed
• Replace Inline js with External js in renderDropDownField macro: Closed
• Replace Inline js with External js in renderDateFindField macro: Closed
• Replace Inline js with External js in renderLookupField macro: Closed
• Replace Inline js with External js in renderFieldGroupOpen macro: Closed
• Review and refactor implementation of select multiple: Open