Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9464

Accounting quantity transfer should not be zero while transferring inventory from one facility to another

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.04
    • Component/s: None

      Description

      when we transfer inventory, the accountingQuantityTotal field of InventoryItem entity is always ZERO. There is no reflection of ATP/QOH in accountingQuantityTotal.

      This will create following issues in the system.

      1. Accounting quantity total will mismatch with the original quantity in the facility which shows the wrong result when we calculate facility specific inventory valuation.
      2. Inventory reservation also throws an error in some specific case like when AQT of respective product is zero in the specific facility from when reservation happens.

      As we manage 5 different statuses of inventory transfer in OFBiz and according to my current understanding these processes are associated with the respective statuses, which are as show below
      Requested: As inventory transfer is requested for another facility.
      a)ATP, QOH and AQT should decrease from the inventory item of From Facility and QOH of To Facility should increase.
      b)ATP and AQT should be Zero in To Facility as inventory is not transferred yet. But QOH should increase at To Facility because QOH shows the xferquantity later. At the time of the completion of the transfer
      ATP = ATP + (QOH - ATP) (Adjustment in case of backorder)
      AQT = QOH
      b)AQT should not decrease because AQT is used for accounting purpose and as of now quantity is still in From Facility as the transfer is not done yet. which shows the xferQuantity later
      Scheduled: As inventory transfer is Scheduled for another facility. ATP, QOH and AQT should not affect in both From Facility and To Facility.
      En-route: As inventory is routed to reach at To Facility. Even in this case ATP, QOH and AQT should not affect in both From Facility and To Facility.
      Complete: As inventory transfer is completed
      a)ATP, QOH and AQT should not affect at From Facility.
      b)QOH will be same but ATP and AQT should affect respectively
      ATP = ATP + (QOH - ATP)
      AQT = QOH
      Cancelled: As inventory transfer is cancelled and inventory item record is already created so
      a) ATP, QOH and AQT should decrease from old inventory item and ATP, QOH and AQT should increase in the newly created inventory item.
      Key points:
      If the whole ATP and QOH is moved then new inventory item will not create. Only Facility and location are changed for existing inventory item.

      Before Changes:-

      As I know there are following processes are associated with respective statuses

      **Note: ATP-> Available to promise QOH-> Quantity on hand AQT-> Accounting quantity total

      1. Requested:-
      ATP =0 QOH=Transferred quantity AQT=0
      2. Scheduled:-
      ATP =0 QOH=Transferred quantity AQT=0
      3.En-Route:-
      ATP =0 QOH=Transferred quantity AQT=0
      4.Complete:-
      If the partial quantity of any inventory item is transferred.
      ATP =Transferred quantity QOH=Transferred quantity AQT=0
      If the whole quantity is transferred then only facility id and location will change no new inventory item record will create.
      5.Cancelled:-
      No new inventory item record will create. An inventory transfer record is created with whole ATP/QOH in cancelled status.

      After Changes:-
      As shown above, accounting quantity transfer will not affect in transfer inventory. After the following changes, records will be updated a shown below.

      1. Requested:-
      ATP =0 QOH=Transferred quantity AQT=0
      2. Scheduled:-
      ATP =0 QOH=Transferred quantity AQT=0
      3.En-Route:-
      ATP =0 QOH=Transferred quantity AQT=0
      4.Complete:-
      If the partial quantity of any inventory item is transferred.
      ATP =Transferred quantity QOH=Transferred quantity AQT=Transferred quantity
      If the whole quantity is transferred then only facility id and location will change no new inventory item record will create.
      5.Cancelled:-
      No new inventory item record will create. An inventory transfer record is created with whole ATP/QOH in cancelled status.

        Issue Links

          Activity

          Hide
          vaibhav.jain Vaibhav Jain added a comment -

          Added accounting quantity total field for creating a new record for inventory item detail at the time inventory transfer.

          Show
          vaibhav.jain Vaibhav Jain added a comment - Added accounting quantity total field for creating a new record for inventory item detail at the time inventory transfer.
          Hide
          diveshdut Divesh Dutta added a comment - - edited

          Fixed this issue in revision number 1801300 in ofbiz-framework/trunk. Thanks Vaibhav Jain for providing the fix

          Show
          diveshdut Divesh Dutta added a comment - - edited Fixed this issue in revision number 1801300 in ofbiz-framework/trunk. Thanks Vaibhav Jain for providing the fix
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Backported to release 16.11 at r#1801304

          Show
          deepak.dixit Deepak Dixit added a comment - Backported to release 16.11 at r#1801304
          Hide
          paul_foxworthy Paul Foxworthy added a comment -

          This fix is OK for COGS methods of inventory cost and average cost, but not for FIFO and LIFO.

          See this thread from January: http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html#a4700869 .

          During a sale, the createAcctgTransForSalesShipmentIssuance service adjusts the accountingQuantity for the most or least recent inventory item, not necessarily the item being sold. The same should happen during transfers.

          Show
          paul_foxworthy Paul Foxworthy added a comment - This fix is OK for COGS methods of inventory cost and average cost, but not for FIFO and LIFO. See this thread from January: http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html#a4700869 . During a sale, the createAcctgTransForSalesShipmentIssuance service adjusts the accountingQuantity for the most or least recent inventory item, not necessarily the item being sold. The same should happen during transfers.
          Hide
          vaibhav.jain Vaibhav Jain added a comment -

          Hi Paul,

          Thanks for pointing out this two scenario which will affect due to this changes.
          I am working on it.

          Show
          vaibhav.jain Vaibhav Jain added a comment - Hi Paul, Thanks for pointing out this two scenario which will affect due to this changes. I am working on it.

            People

            • Assignee:
              vaibhav.jain Vaibhav Jain
              Reporter:
              vaibhav.jain Vaibhav Jain
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development