Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: order
    • Labels:
      None

      Description

      Fix entity definition of OrderHeader and do the following changes in the implementation;

      • Remove relations with OrderHeaderNoteView and OrderItemAndShipGroupAssoc from the entity definition.
      • Check for the both views used at any place as getRelated() generic value methods on OrderHeader then change them with appropriate EntityQuery method or delegaor or other script as applicable.
      • Few find areas are;
        • AddItemsFromOrder.groovy
        • ReceiveInventoryAgainstPurchaseOrder.groovy

      Note: As we are removing relation from OrderHeader so only need to work on the items where we are trying to get related data by using the relations. We need to rewrite only those lines of code. Reverse in not true.

      1. OFBIZ-9457.patch
        3 kB
        Rishi Solanki
      2. OFBIZ-9457.diff
        3 kB
        Aishwary Shrivastava

        Activity

        Hide
        mbrohl Michael Brohl added a comment -
        Show
        mbrohl Michael Brohl added a comment - +1, Rishi Solanki
        Hide
        aishwary Aishwary Shrivastava added a comment -

        Here is the patch for the Improvement.
        Thanks to Devanshu Vyas, Amit Gadaley, Vaibhav Jain and Rishi Solanki for the guidance.

        Steps to verify the changes of AddItemFromOrder:
        1. Login
        2.Go to Facility.
        3.Go to Shipments.
        4.Find an Outgoing - Sales type shipment.
        5.Select the shipment.
        6.Click on Order Items

        Steps to verify the changes of ReceiveInventoryAgainstPurchaseOrder:
        1. Login
        2.Go to Facility.
        3.Go to Shipments.
        4.Find an Incoming - Purchase type shipment.
        5.Select the shipment.
        6.Click on Receive against PO.

        The data show on the screens remains same before and after applying the patch.

        Show
        aishwary Aishwary Shrivastava added a comment - Here is the patch for the Improvement. Thanks to Devanshu Vyas, Amit Gadaley, Vaibhav Jain and Rishi Solanki for the guidance. Steps to verify the changes of AddItemFromOrder: 1. Login 2.Go to Facility. 3.Go to Shipments. 4.Find an Outgoing - Sales type shipment. 5.Select the shipment. 6.Click on Order Items Steps to verify the changes of ReceiveInventoryAgainstPurchaseOrder: 1. Login 2.Go to Facility. 3.Go to Shipments. 4.Find an Incoming - Purchase type shipment. 5.Select the shipment. 6.Click on Receive against PO. The data show on the screens remains same before and after applying the patch.
        Hide
        rishisolankii Rishi Solanki added a comment -

        Updating patch with correct naming pattern.

        Show
        rishisolankii Rishi Solanki added a comment - Updating patch with correct naming pattern.
        Hide
        rishisolankii Rishi Solanki added a comment -

        Aishwary Shrivastava: Your patch looks good to me, thanks for providing patch for the same.

        Show
        rishisolankii Rishi Solanki added a comment - Aishwary Shrivastava : Your patch looks good to me, thanks for providing patch for the same.
        Hide
        arunpati Arun Patidar added a comment -

        Committed changes in ofbiz framework at revision 1801310.

        Thanks Rishi Solanki and Aishwary for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed changes in ofbiz framework at revision 1801310. Thanks Rishi Solanki and Aishwary for your contribution.

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            rishisolankii Rishi Solanki
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development