Details

      Description

      While adding numericCode to currency UOM, I found that we need to update some old currency UOM, as uomId has been updated.
      https://www.currency-iso.org/en/home/tables/table-a1.html
      https://www.currency-iso.org/en/home/amendments.html

      Here is the short summary
      Following UomId not found

      • Santo Domiongo(CDP)
      • Brazil (BRR)
      • Argentinian Austral(ARA)
      • Andoran peseta(ADP)
      • Maltese Lira (MTL)
      • Mexican Peso (old)(MXP)
      • Peruvian Inti(PEI)
      • Peruvian Sol(PES)
      • Tadzhikistani Ruble(TJR)

      Following UOM using other currency
      Used Other

      • ANDORRA == Euro
      • Cyprus Pound(CYP) == Euro
      • Ecuador Sucre(ECS) = USD
      • Estonian Krone(EEK) = EURO
      • Lithuanian Lita(LTL) == EURO
      • Latvian Lat(LVL) == EURO
      • Timor Escudo(TPE) == US Dollor

      Following UOM has been changed

      Old New
      Belorussian Ruble(BYR) Belarusian Ruble(BYN)
      Bosnia-Herzogovinian Dinar(BAD) Convertible Mark(BAM)
      Azerbaijan Manat (AZM) Azerbaijan Manat(AZN)
      Angolan Kwanza (AOK) Kwanza (AOA)
      Afghani (AFA) Afghani(AFN)
      Dominican Republic Peso(DRP) Dominican Peso (DOP)
      Ghanian Cedi(GHC) Ghana Cedi(GHS)
      Guinea Peso(GWP) Guinean Franc(GNF)
      Kirghizstan Som(KIS) KYRGYZSTAN Som (KGS)
      Madagascan Franc(MGF) Malagasy Ariary(MGA)
      Mozambique Metical(MZM) Mozambique Metical(MZN)
      Nicaragua (NIC) Cordoba Oro (NIO)
      New Israeli Shekel(NIS) New Israeli Sheqel (ILS)
      Poland(PLZ) Zloty (PLN)
      Romanian Leu(ROL) Romanian Leu(RON)
      Russian Rouble(RUR) Russian Ruble(RUB)
      Sudanese Pound(SDP) Sudanese Pound(SDG)
      Peru (SOL) Sol (PEN)
      Surinam Guilder(SRG) Surinam Dollar (SRD)
      Turkmenistani Manat(TMM) Turkmenistan New Manat(TMT)
      Uganda Shilling(UGS) Uganda Shilling(UGX)
      Uruguayan New Peso(UYP) Uruguay Peso en Unidades Indexadas (URUIURUI)(UYI)
      Venezuelan Bolivar(VEB) Bolívar(VEF)
      Zambian Kwacha(ZMK) Zambian Kwacha(ZMW)
      Zimbabwean Dollar(ZWD) Zimbabwe Dollar(ZWL)
      Georgian Kupon (GEK) GEORGIA Lari (GEL)

      Some currency codes moved to historic denominations, we can remove them from data.
      https://www.currency-iso.org/en/home/tables/table-a3.html

      1. list_three.xls
        54 kB
        Deepak Dixit
      2. OFBIZ-9413.patch
        21 kB
        Deepak Dixit

        Issue Links

          Activity

          Hide
          deepak.dixit Deepak Dixit added a comment -

          Attaching file for codes for historic denominations of currencies

          Show
          deepak.dixit Deepak Dixit added a comment - Attaching file for codes for historic denominations of currencies
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks for the effor Deepak,

          Will you provide a patch?

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks for the effor Deepak, Will you provide a patch?
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Yes Jacques, I am working on it, I'll upload patch for review.

          Show
          deepak.dixit Deepak Dixit added a comment - Yes Jacques, I am working on it, I'll upload patch for review.
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Here is the patch for this issue.

          Show
          deepak.dixit Deepak Dixit added a comment - Here is the patch for this issue.
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          Thanks for the hard work Deepak,

          From a cursorly review

          • 100% of Following UomId not found
          • 100% of Following UOM using other currency
          • 25% of Following UOM has been changed
            this sounds good to me
          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited Thanks for the hard work Deepak, From a cursorly review 100% of Following UomId not found 100% of Following UOM using other currency 25% of Following UOM has been changed this sounds good to me
          Hide
          deepak.dixit Deepak Dixit added a comment -

          This has been done at
          OFBiz framework Trunk at r#1799183
          Release 16.11 at r#1799196
          Release 15.12 at r#1799200
          Release 14.12 at r#1799201

          Show
          deepak.dixit Deepak Dixit added a comment - This has been done at OFBiz framework Trunk at r#1799183 Release 16.11 at r#1799196 Release 15.12 at r#1799200 Release 14.12 at r#1799201
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Removed unused entity uiLabels related to removed currency UOM at ofbiz framework trunk r#1799209

          Show
          deepak.dixit Deepak Dixit added a comment - Removed unused entity uiLabels related to removed currency UOM at ofbiz framework trunk r#1799209
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Hi Deepak,

          This introduced duplicates for "Uom.description.ILS" which is the right ISO code (https://www.quora.com/Israeli-currency-is-NIS-or-ILS)

          It seems to me that the ones under the same label than "New Israeli Shekel" should be kept, but for instance the French one need to be amended (wrong translation). I suggest this patch:

          Index: framework/common/config/CommonEntityLabels.xml
          ===================================================================
          --- framework/common/config/CommonEntityLabels.xml	(revision 1801301)
          +++ framework/common/config/CommonEntityLabels.xml	(working copy)
          @@ -18862,21 +18862,6 @@
                   <value xml:lang="zh">爱尔兰镑</value>
                   <value xml:lang="zh-TW">愛爾蘭鎊</value>
               </property>
          -    <property key="Uom.description.ILS">
          -        <value xml:lang="ar">شكيل إسرائيلي</value>
          -        <value xml:lang="de">Scheckel Israel</value>
          -        <value xml:lang="en">Israeli Scheckel</value>
          -        <value xml:lang="fr">Scheckel israélien</value>
          -        <value xml:lang="it">Scheckel Israeliano</value>
          -        <value xml:lang="ja">イスラエル・シェケル</value>
          -        <value xml:lang="pt">Israeli Scheckel</value>
          -        <value xml:lang="pt-BR">Israel Scheckel</value>
          -        <value xml:lang="ro">Scheckel Israelian</value>
          -        <value xml:lang="ru">Израиль�кий шекель</value>
          -        <value xml:lang="th">เชคเ�ิล อิสราเอล</value>
          -        <value xml:lang="zh">以色列谢克尔</value>
          -        <value xml:lang="zh-TW">以色列�克爾</value>
          -    </property>
               <property key="Uom.description.INR">
                   <value xml:lang="ar">روبية هندية</value>
                   <value xml:lang="de">Rupie Indien</value>
          @@ -19889,7 +19874,7 @@
               <property key="Uom.description.ILS">
                   <value xml:lang="ar">الشيكل الإسرائيلي الجديد</value>
                   <value xml:lang="en">New Israeli Shekel</value>
          -        <value xml:lang="fr">Shekel du nouvel Israël</value>
          +        <value xml:lang="fr">Nouveau shekel</value>
                   <value xml:lang="it">Shekel Nuovo Israele</value>
                   <value xml:lang="ja">イスラエル・新シェケル</value>
                   <value xml:lang="pt">New Israeli Shekel</value>
          
          Show
          jacques.le.roux Jacques Le Roux added a comment - Hi Deepak, This introduced duplicates for "Uom.description.ILS" which is the right ISO code ( https://www.quora.com/Israeli-currency-is-NIS-or-ILS ) It seems to me that the ones under the same label than "New Israeli Shekel" should be kept, but for instance the French one need to be amended (wrong translation). I suggest this patch: Index: framework/common/config/CommonEntityLabels.xml =================================================================== --- framework/common/config/CommonEntityLabels.xml (revision 1801301) +++ framework/common/config/CommonEntityLabels.xml (working copy) @@ -18862,21 +18862,6 @@ <value xml:lang= "zh" >爱尔兰镑</value> <value xml:lang= "zh-TW" >愛爾蘭鎊</value> </property> - <property key= "Uom.description.ILS" > - <value xml:lang= "ar" >شكيل إسرائيلي</value> - <value xml:lang= "de" >Scheckel Israel</value> - <value xml:lang= "en" >Israeli Scheckel</value> - <value xml:lang= "fr" >Scheckel israélien</value> - <value xml:lang= "it" >Scheckel Israeliano</value> - <value xml:lang= "ja" >イスラエル・シェケル</value> - <value xml:lang= "pt" >Israeli Scheckel</value> - <value xml:lang= "pt-BR" >Israel Scheckel</value> - <value xml:lang= "ro" >Scheckel Israelian</value> - <value xml:lang= "ru" >Израиль�кий шекель</value> - <value xml:lang= "th" >เชคเ�ิล อิสราเอล</value> - <value xml:lang= "zh" >以色列谢克尔</value> - <value xml:lang= "zh-TW" >以色列�克爾</value> - </property> <property key= "Uom.description.INR" > <value xml:lang= "ar" >روبية هندية</value> <value xml:lang= "de" >Rupie Indien</value> @@ -19889,7 +19874,7 @@ <property key= "Uom.description.ILS" > <value xml:lang= "ar" >الشيكل الإسرائيلي الجديد</value> <value xml:lang= "en" >New Israeli Shekel</value> - <value xml:lang= "fr" >Shekel du nouvel Israël</value> + <value xml:lang= "fr" >Nouveau shekel</value> <value xml:lang= "it" >Shekel Nuovo Israele</value> <value xml:lang= "ja" >イスラエル・新シェケル</value> <value xml:lang= "pt" >New Israeli Shekel</value>
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Thanks Jacques,
          This has been fixed at ofbiz framework trunk at r#1801311 and r#1801312

          Show
          deepak.dixit Deepak Dixit added a comment - Thanks Jacques, This has been fixed at ofbiz framework trunk at r#1801311 and r#1801312

            People

            • Assignee:
              deepak.dixit Deepak Dixit
              Reporter:
              deepak.dixit Deepak Dixit
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development