Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9386

RequestHandlerException on request link of Quote Profit page

    Details

      Description

      Similar to OFBIZ-9384
      Steps to reproduce:
      1. Go to Order component (https://demo-trunk.ofbiz.apache.org/ordermgr/control/main)
      2. Click on Quotes from submenu.(https://demo-trunk.ofbiz.apache.org/ordermgr/control/FindQuote)
      3. Provide search preferences and click on Find button.
      4. Click on Quote Id link (https://demo-trunk.ofbiz.apache.org/ordermgr/control/ViewQuote?quoteId=CQ0001).
      5. Click on Profit subtab (https://demo-trunk.ofbiz.apache.org/ordermgr/control/ViewQuoteProfit?quoteId=CQ0001)
      6. Click on link under View Request (https://demo-trunk.ofbiz.apache.org/workeffort/control/requestitem)
      It gives a RequestHandlerException.

      1. OFBIZ-9386.patch
        1 kB
        Aditya Sharma

        Activity

        Hide
        aditya.sharma Aditya Sharma added a comment -

        Problem:
        1. Profit tab redirects to ViewQuoteProfit.
        2. ViewQuoteProfit screen includes ViewQuoteProfit form of QuoteForms.xml to list quote profit records.
        3.View Request field contains link with request for workeffort controller while request belongs to ordermgr
        Solution:
        Changed link URL with the request for ordrmgr. Additionally added a check to show link only when custRequestId and custRequestItemSeqId exist.

        Show
        aditya.sharma Aditya Sharma added a comment - Problem: 1. Profit tab redirects to ViewQuoteProfit. 2. ViewQuoteProfit screen includes ViewQuoteProfit form of QuoteForms.xml to list quote profit records. 3.View Request field contains link with request for workeffort controller while request belongs to ordermgr Solution: Changed link URL with the request for ordrmgr. Additionally added a check to show link only when custRequestId and custRequestItemSeqId exist.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Hi Aditya,

        Since we use the letsencrypt certificate the trunk demo URL is
        https://demo-trunk.ofbiz.apache.org
        not
        https://demo-trunk-ofbiz.apache.org:8443

        Note the dot instead of dash
        (similar for stable)

        Your patch seems good to me but it's no longer an "inter-app" link Also did you try with a case where the link appears (I did not find one OOTB)?

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Hi Aditya, Since we use the letsencrypt certificate the trunk demo URL is https://demo-trunk.ofbiz.apache.org not https://demo-trunk-ofbiz.apache.org:8443 Note the dot instead of dash (similar for stable) Your patch seems good to me but it's no longer an "inter-app" link Also did you try with a case where the link appears (I did not find one OOTB)?
        Hide
        aditya.sharma Aditya Sharma added a comment - - edited

        Thanks, Jacques. I missed on that . I updated the description of OFBIZ-9384 too.
        I do try it with the link.
        When we create a quote from a request, a link appears there.
        Steps to verify:
        1. Create a request with Cust Request Type Id as Request For Quote (https://demo-trunk.ofbiz.apache.org/ordermgr/control/request)
        2. Add Request Items & then click Create Quote from request.

        Show
        aditya.sharma Aditya Sharma added a comment - - edited Thanks, Jacques. I missed on that . I updated the description of OFBIZ-9384 too. I do try it with the link. When we create a quote from a request, a link appears there. Steps to verify: 1. Create a request with Cust Request Type Id as Request For Quote ( https://demo-trunk.ofbiz.apache.org/ordermgr/control/request ) 2. Add Request Items & then click Create Quote from request .
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Hi Aditya,

        You still did not get the links totally right in OFBIZ-9384. As I said above

        Note the dot instead of dash

        So it's
        demo-trunk.ofbiz.apache.org
        not
        demo-trunk-ofbiz.apache.org.

        If you use the dash it may work after you accept to bypass the non existing certificate (which exists for the dot)

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi Aditya, You still did not get the links totally right in OFBIZ-9384 . As I said above Note the dot instead of dash So it's demo-trunk.ofbiz.apache.org not demo-trunk-ofbiz.apache.org. If you use the dash it may work after you accept to bypass the non existing certificate (which exists for the dot)
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Another point is because the link is inside order component and start from it, it's no longer an "inter-app" link

        Show
        jacques.le.roux Jacques Le Roux added a comment - Another point is because the link is inside order component and start from it, it's no longer an "inter-app" link
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Hi Aditya,

        Thanks for you steps to verify I was quickly able to check. It always help to have less things to think about

        Your modified patch is in
        trunk r1798803
        R16.11 r1798804
        R15.12 r1798805
        R14.12 r1798806

        I simply changed the link from inter-app to simple (inter-app works also but is not right)

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi Aditya, Thanks for you steps to verify I was quickly able to check. It always help to have less things to think about Your modified patch is in trunk r1798803 R16.11 r1798804 R15.12 r1798805 R14.12 r1798806 I simply changed the link from inter-app to simple (inter-app works also but is not right)
        Hide
        aditya.sharma Aditya Sharma added a comment -

        Hi Jacques,
        I should have read that more gravely. I got both the points now.
        A simple link for the inter-app link should have been a much better choice.
        Thanks, Jacques

        Show
        aditya.sharma Aditya Sharma added a comment - Hi Jacques, I should have read that more gravely. I got both the points now. A simple link for the inter-app link should have been a much better choice. Thanks, Jacques

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            aditya.sharma Aditya Sharma
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development