Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      I found several cases. This is an improvement only because no cases were reported. But obviously in case of unlucky exception after the EntityListIterator creation and before it's closed the EntityListIterator remains in memory. It should be closed in EntityListIterator.finalize() but the less happens there the better.

      The solution is to use try-with-ressources when (easily) possible (some cases are quite convoluted)

        Issue Links

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          I found some other cases and improved them at 1798566. I did not improve tests code, it's has no real impact.

          This completes OFBIZ-9385, there are no other cases left.

          Show
          jacques.le.roux Jacques Le Roux added a comment - I found some other cases and improved them at 1798566. I did not improve tests code, it's has no real impact. This completes OFBIZ-9385 , there are no other cases left.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          There are few methods like FindServices.executeFind() or performFindParty service which can't be improved because they return an EntityListIterator. So methods using them must be carefully crafted to close the EntityListIterator. Most where already documented (in the framework). I completed few in
          applications at r1798495.

          Show
          jacques.le.roux Jacques Le Roux added a comment - There are few methods like FindServices.executeFind() or performFindParty service which can't be improved because they return an EntityListIterator. So methods using them must be carefully crafted to close the EntityListIterator. Most where already documented (in the framework). I completed few in applications at r1798495.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          This is completely done

          Show
          jacques.le.roux Jacques Le Roux added a comment - This is completely done
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Done at revision: 1798300 for ProductSearchEvents class. The getProductSearchResults() method was public but only used in the class. I made it private

          Show
          jacques.le.roux Jacques Le Roux added a comment - Done at revision: 1798300 for ProductSearchEvents class. The getProductSearchResults() method was public but only used in the class. I made it private
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Done at revision: 1797792 for ContentEvents.updateAllContentKeywords()

          Show
          jacques.le.roux Jacques Le Roux added a comment - Done at revision: 1797792 for ContentEvents.updateAllContentKeywords()
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Done at revision: 1797791 for OrderListState.getOrders()

          Show
          jacques.le.roux Jacques Le Roux added a comment - Done at revision: 1797791 for OrderListState.getOrders()
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Done at revision: 1797790 for SurveyWrapper.getBooleanResult()

          Show
          jacques.le.roux Jacques Le Roux added a comment - Done at revision: 1797790 for SurveyWrapper.getBooleanResult()
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Done at revision: 1797373 for misc. groovy files

          Show
          jacques.le.roux Jacques Le Roux added a comment - Done at revision: 1797373 for misc. groovy files
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Done at revision: 1797160 for framework/entity

          Show
          jacques.le.roux Jacques Le Roux added a comment - Done at revision: 1797160 for framework/entity
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          Done at revision: 1797159 for framework/common

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited Done at revision: 1797159 for framework/common
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Done at revision: 1797158 for product

          Show
          jacques.le.roux Jacques Le Roux added a comment - Done at revision: 1797158 for product
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Done at revision: 1797074 for content

          Show
          jacques.le.roux Jacques Le Roux added a comment - Done at revision: 1797074 for content
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Done at revision: 1797073 for webpos

          Show
          jacques.le.roux Jacques Le Roux added a comment - Done at revision: 1797073 for webpos

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              jacques.le.roux Jacques Le Roux
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development