[OFBIZ-9385] EntityListIterator closed but not in case of exception

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 17.12.01, 22.01.01
• Component/s: ALL COMPONENTS
• Assignee: Jacques Le Roux
• Reporter: Jacques Le Roux
• Created: 31/May/17 17:02
• Updated: 07/Dec/22 09:58
• Resolved: 07/Dec/22 09:58

Description

I found several cases. This is an improvement only because no cases were reported. But obviously in case of unlucky exception after the EntityListIterator creation and before it's closed the EntityListIterator remains in memory. It should be closed in EntityListIterator.finalize() but the less happens there the better.

The solution is to use try-with-ressources when (easily) possible (some cases are quite convoluted)

Issue Links

• is duplicated by: OFBIZ-9291 EntityListIterator Not Closed for Entity [Content], caught in Finalize