Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9345

Error viewing tomahawk-themed page when externalLoginKey is not enabled

    Details

      Description

      The following error occurs when the theme is set to tomahawk and security.login.externalLoginKey.enabled=false:

      2017-05-04 22:57:42,818 |http-nio-8443-exec-8 |FreeMarkerWorker              |E| null
      freemarker.core.InvalidReferenceException: The following has evaluated to null or missing:
      ==> externalLoginKey  [in template "component://tomahawk/template/AppBarClose.ftl" at line 88, column 113]
      
      ----
      Tip: If the failing expression is known to be legally refer to something that's sometimes null or missing, either specify a default value like myOptionalVar!myDefault, or use <#if myOptionalVar??>when-present<#else>when-missing</#if>. (These only cover the last step of the expression; to cover the whole expression, use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
      ----
      
      ----
      FTL stack trace ("~" means nesting-related):
      	- Failed at: ${externalLoginKey}  [in template "component://tomahawk/template/AppBarClose.ftl" at line 88, column 111]
      ----
      	at freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:134) ~[freemarker-2.3.25-incubating.jar:2.3.25]
      

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks James,

        Your modified patch is in
        trunk r1794008
        R16.11 r1794009

        We don't need to create externalKeyParam in AppBarClose.ftl. It already exists in context.

        I updated the https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context page about that

        BTW don't put "Trunk" in "Fix Version/s" field but "Upcoming Release". THiz is explained at https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-ManageJIRA%27sissues

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks James, Your modified patch is in trunk r1794008 R16.11 r1794009 We don't need to create externalKeyParam in AppBarClose.ftl. It already exists in context. I updated the https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context page about that BTW don't put "Trunk" in "Fix Version/s" field but "Upcoming Release". THiz is explained at https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-ManageJIRA%27sissues
        Hide
        jamesyong James Yong added a comment -

        Thanks Jacques Le Roux for the correction and follow-up.

        In the wiki section mentioned, should the terms "Upcoming Branch" be "Upcoming Release" instead?

        Show
        jamesyong James Yong added a comment - Thanks Jacques Le Roux for the correction and follow-up. In the wiki section mentioned, should the terms "Upcoming Branch" be "Upcoming Release" instead?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Right James, we changed the name but did not update the doc, done, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Right James, we changed the name but did not update the doc, done, thanks!

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            jamesyong James Yong
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development