Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9322

Remove all dependencies from OFBiz framework to plugins

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Upcoming Release
    • Fix Version/s: Upcoming Release
    • Component/s: None
    • Labels:
      None

      Description

      The OFBiz framework repository fails to build and run tests unless the plugins repository is added first.

      The reason for this failure is mostly due to dependencies of some tests defined in the framework on data that is defined in the ecommerce plugin.

      The purpose of this JIRA is to completely remove all these dependencies and achieve a successful build of the framework using the command "./gradlew cleanAll loadDefault testIntegration"

      This task requires multiple different approaches including:

      • Moving some demo data from ecommerce to framework
      • Moving some tests where relevant from framework to ecommerce
      • Refactoring and/or removing some tests to disentangle the dependencies
      1. OFBIZ-9322.patch
        3 kB
        Taher Alkhateeb

        Activity

        Hide
        taher Taher Alkhateeb added a comment - - edited

        Made first commits in ofbiz-framework r1792866 and ofbiz-plugins r1792867 which removed most (I think over 90%) of all dependencies. I only have about 9 or so tests failing on ofbiz-framework standalone.

        Show
        taher Taher Alkhateeb added a comment - - edited Made first commits in ofbiz-framework r1792866 and ofbiz-plugins r1792867 which removed most (I think over 90%) of all dependencies. I only have about 9 or so tests failing on ofbiz-framework standalone.
        Hide
        taher Taher Alkhateeb added a comment -

        Implemented more changes in ofbiz-trunk r1793170 and ofbiz-plugins r1793171. This brings down the total failing tests to only two.

        Show
        taher Taher Alkhateeb added a comment - Implemented more changes in ofbiz-trunk r1793170 and ofbiz-plugins r1793171. This brings down the total failing tests to only two.
        Hide
        taher Taher Alkhateeb added a comment -

        I am attaching a patch that would simply remove the last 2 failing tests on framework-alone. I think we should apply it because the tests are fundamentally wrong because they depend on the existence of ecommerce and hard-coded in several places in the order component.

        Show
        taher Taher Alkhateeb added a comment - I am attaching a patch that would simply remove the last 2 failing tests on framework-alone. I think we should apply it because the tests are fundamentally wrong because they depend on the existence of ecommerce and hard-coded in several places in the order component.
        Hide
        taher Taher Alkhateeb added a comment -

        Started a discussion thread on applying the attached patch.

        Show
        taher Taher Alkhateeb added a comment - Started a discussion thread on applying the attached patch.
        Hide
        taher Taher Alkhateeb added a comment -

        Final commit on r1793633. This issue is now completed.

        Show
        taher Taher Alkhateeb added a comment - Final commit on r1793633. This issue is now completed.

          People

          • Assignee:
            taher Taher Alkhateeb
            Reporter:
            taher Taher Alkhateeb
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development