[OFBIZ-9281] Code Improvement on Product Config

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 17.12.01
• Component/s: product
• Assignee: Ashish Vijaywargiya
• Reporter: Suraj Khurana
• Created: 25/Mar/17 09:38
• Updated: 22/Jul/17 12:10
• Resolved: 22/Jul/17 12:10

Description

I noticed a couple of code improvements on product config current code. Here is the reference:

• In ProductConfigWorker.fillProductConfigWrapper() method, currently, we only check parameters map, while it is possible in a business environment that user can submit required fields values in request attributes as well. So here getCombinedMap method can be used to make it more efficient.

• While calling constructor of ConfigOption (ConfigOption(ConfigOption co)), some private members should also be copied, like componentOptions etc.