Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9264

Make sure the local date time uses the time zone from the local browser.

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: None
    • Labels:

      Description

      This feature was requested by one of our clients, it sets the time zone of the user logged in to it's browser time zone.

      1. OFBIZ-9264.diff
        440 kB
        Francis Douet

        Issue Links

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          Did you check the mail history? I vaguely remember Adrian, who deeply worked on the time zone and globally time issues, was against such changes, like time from browser or OS. I could be wrong...

          And ouch! This is quite big Mostly adds though so less worrying...

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited Did you check the mail history? I vaguely remember Adrian, who deeply worked on the time zone and globally time issues, was against such changes, like time from browser or OS. I could be wrong... And ouch! This is quite big Mostly adds though so less worrying...
          Hide
          Francis Douet Francis Douet added a comment -

          Didn't find much in the mail history about setting the time zone from the browser.
          And yeah, it's quite big, but it's due to the JavaScript library we added.

          Show
          Francis Douet Francis Douet added a comment - Didn't find much in the mail history about setting the time zone from the browser. And yeah, it's quite big, but it's due to the JavaScript library we added.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Francis,

          I'll double check, and if nobody oppose I'll commit

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Francis, I'll double check, and if nobody oppose I'll commit
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          What about the fact that you can set your own time zone independently of the browser?
          https://demo-trunk.ofbiz.apache.org/catalog/control/ListTimezones

          Show
          jacques.le.roux Jacques Le Roux added a comment - What about the fact that you can set your own time zone independently of the browser? https://demo-trunk.ofbiz.apache.org/catalog/control/ListTimezones
          Show
          jacques.le.roux Jacques Le Roux added a comment - Also this is maybe worth reading https://cwiki.apache.org/confluence/display/OFBIZ/Calendars,+Dates,+and+Times
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          I wonder if this is still true http://markmail.org/message/bldm5eajql4in3yg (did not check) Maybe the reason of the initial problem your client crossed?

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited I wonder if this is still true http://markmail.org/message/bldm5eajql4in3yg (did not check) Maybe the reason of the initial problem your client crossed?
          Hide
          Francis Douet Francis Douet added a comment -

          If a time zone is already set for a user, this new feature won't override it.
          The user still can set it's own time zone, but if it isn't set, this avoids the time zone set to the default of the server.

          Show
          Francis Douet Francis Douet added a comment - If a time zone is already set for a user, this new feature won't override it. The user still can set it's own time zone, but if it isn't set, this avoids the time zone set to the default of the server.
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          I see, then this makes sense. I'll wait a week for other opinions before reviewing and hopefully committing

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited I see, then this makes sense. I'll wait a week for other opinions before reviewing and hopefully committing
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Francis,

          Your patch is in trunk at r1788256

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Francis, Your patch is in trunk at r1788256
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Hi Francis Douet,

          Did you not cross the issues which are reported are being broken by this one? Else Could you please have a look, I'll also, thanks

          For OFBIZ-9379, I suspect it's because webtools has a specific way to login. For the other case I have no clues yet.

          Show
          jacques.le.roux Jacques Le Roux added a comment - Hi Francis Douet , Did you not cross the issues which are reported are being broken by this one? Else Could you please have a look, I'll also, thanks For OFBIZ-9379 , I suspect it's because webtools has a specific way to login. For the other case I have no clues yet.

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              Francis Douet Francis Douet
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development