Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9253

Order contact mechs are not copied over while re-ordering an order

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk, Release Branch 16.11
    • Fix Version/s: Upcoming Release
    • Component/s: None
    • Labels:
      None

      Description

      Place an order and click on create as new order button on order detail page.

      All the information is properly copied over to that order but email contact mechs are not copied to newly created order.

      If a user has added those emails in previous order, then they should also be copied over while re-ordering.

      1. OFBIZ-9253.patch
        2 kB
        Suraj Khurana

        Issue Links

          Activity

          Hide
          suraj.khurana Suraj Khurana added a comment -

          Attached patch with proper fix. Please review.

          Show
          suraj.khurana Suraj Khurana added a comment - Attached patch with proper fix. Please review.
          Hide
          pfm.smits Pierre Smits added a comment -

          Did you factor in the possibility that the contact mech details may not be valid anymore (address expired and such)?

          Thanks.

          Show
          pfm.smits Pierre Smits added a comment - Did you factor in the possibility that the contact mech details may not be valid anymore (address expired and such)? Thanks.
          Hide
          suraj.khurana Suraj Khurana added a comment -

          Hi Pierre Smits,

          Cureently, I am just copying the old order contact mech to the newly created cart object.
          We can discuss that further work flow and that can be added in another ticket.

          Thanks.

          Show
          suraj.khurana Suraj Khurana added a comment - Hi Pierre Smits , Cureently, I am just copying the old order contact mech to the newly created cart object. We can discuss that further work flow and that can be added in another ticket. Thanks.
          Hide
          toashishvijay Ashish Vijaywargiya added a comment -

          Hello Suraj,

          The suggestions from Pierre can be a good improvement. For now, I am committing this patch. I request you to create a new Jira issue for the mentioned comment so that we can take care of the improvements in near future.

          Show
          toashishvijay Ashish Vijaywargiya added a comment - Hello Suraj, The suggestions from Pierre can be a good improvement. For now, I am committing this patch. I request you to create a new Jira issue for the mentioned comment so that we can take care of the improvements in near future.
          Hide
          toashishvijay Ashish Vijaywargiya added a comment -

          Thanks Suraj for the contribution.
          Your changes are committed in trunk at r1802683.

          Show
          toashishvijay Ashish Vijaywargiya added a comment - Thanks Suraj for the contribution. Your changes are committed in trunk at r1802683.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          I think Pierre or Suraj (or even you Ashish ) should create a Jira an refer to it from there, thanks guys I trust one of you will

          Show
          jacques.le.roux Jacques Le Roux added a comment - I think Pierre or Suraj (or even you Ashish ) should create a Jira an refer to it from there, thanks guys I trust one of you will
          Hide
          suraj.khurana Suraj Khurana added a comment -

          Thanks for the reminder Jacques.

          Created a ticket at OFBIZ-9544

          Show
          suraj.khurana Suraj Khurana added a comment - Thanks for the reminder Jacques. Created a ticket at OFBIZ-9544
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Suraj

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Suraj

            People

            • Assignee:
              toashishvijay Ashish Vijaywargiya
              Reporter:
              suraj.khurana Suraj Khurana
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development