Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9229

refactor list related forms in Cost widgets

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: accounting
    • Labels:
      None

      Description

      Refactoring various list forms into grids
      Refactoring various list form references in screen widgets

        Activity

        Hide
        pfm.smits Pierre Smits added a comment -

        This patch addresses the issue.

        Show
        pfm.smits Pierre Smits added a comment - This patch addresses the issue.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pierre, your patch is in at revision: 1786916

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, your patch is in at revision: 1786916
        Hide
        pfm.smits Pierre Smits added a comment -

        Thanks for the help, Jacques.

        Show
        pfm.smits Pierre Smits added a comment - Thanks for the help, Jacques.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Pierre,

        Are you using that in a project? Because I reverted at revision: 1786987

        I prefered to revert because the grid concept is questionned by Taher. No need to complicate later if we ever revert it all.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Pierre, Are you using that in a project? Because I reverted at revision: 1786987 I prefered to revert because the grid concept is questionned by Taher. No need to complicate later if we ever revert it all.
        Hide
        pfm.smits Pierre Smits added a comment -

        Maybe you should have waited until a discussion was started and a conclusion reached.

        Whether or not I use grids in a project is irrelevant.

        Show
        pfm.smits Pierre Smits added a comment - Maybe you should have waited until a discussion was started and a conclusion reached. Whether or not I use grids in a project is irrelevant.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Maybe you should have waited until a discussion was started and a conclusion reached.

        I don't wait when there is an issue in the patch, see my commit comment. What I could have done is fixing the problem. But then I'd have 2 commits to revert if ever we want to remove the grid feature. I doubt we will, but I still prefer to wait the conclusion of the current discussion on the grid in dev ML.

        Whether or not I use grids in a project is irrelevant.

        This question because you privately asked me to commit this, as if urgent, and I thought it was blocking you in a custom project.

        Note also that I reverted because I was unsure there were no other cases like that in the related patches I committed ("refactor list related forms into grid"). I know for sure now that there are none. So it's not a big deal to fix the 3 case I reported in commits comments

        Show
        jacques.le.roux Jacques Le Roux added a comment - Maybe you should have waited until a discussion was started and a conclusion reached. I don't wait when there is an issue in the patch, see my commit comment. What I could have done is fixing the problem. But then I'd have 2 commits to revert if ever we want to remove the grid feature. I doubt we will, but I still prefer to wait the conclusion of the current discussion on the grid in dev ML. Whether or not I use grids in a project is irrelevant. This question because you privately asked me to commit this, as if urgent, and I thought it was blocking you in a custom project. Note also that I reverted because I was unsure there were no other cases like that in the related patches I committed ("refactor list related forms into grid"). I know for sure now that there are none. So it's not a big deal to fix the 3 case I reported in commits comments
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        This was reverted and is now back with bugs fixed at r1787184

        Show
        jacques.le.roux Jacques Le Roux added a comment - This was reverted and is now back with bugs fixed at r1787184
        Hide
        pfm.smits Pierre Smits added a comment -

        Thank you for your assistance, Jacques

        Show
        pfm.smits Pierre Smits added a comment - Thank you for your assistance, Jacques

          People

          • Assignee:
            pfm.smits Pierre Smits
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development