[OFBIZ-9208] reinstate url cache in UtilURL.fromResource

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: Release Branch 15.12, 16.11.02, 17.12.01
• Component/s: base
• Assignee: Jacques Le Roux
• Reporter: Gareth Carter
• Created: 08/Feb/17 13:17
• Updated: 10/Feb/17 20:44
• Resolved: 10/Feb/17 20:44

Description

Adrian created the following commit to cache URL objects

Revision: 1649979
Author: adrianc
Date: 07 January 2015 00:24:28
Message:
Some optimizations for URL lookups.
----
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java

and was later reverted in this commit

Revision: 1650347
Author: adrianc
Date: 08 January 2015 17:53:59
Message:
Some small fixups for some of my previous commits.
----
Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java

We have found in one of our production servers that line 98 in UtilURL.java

url = loader.getResource(resourceName);

has caused locking and looking at the stack trace (from jstack) there are numerous threads waiting on locks from within this method

I propose the cache gets added back (we have done this as a patch on our systems with no ill effect)

FYI - The commits are in reference to the EntityClassLoader which is not used and does not work see OFBIZ-6210