Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9208

reinstate url cache in UtilURL.fromResource

    Details

      Description

      Adrian created the following commit to cache URL objects

      Revision: 1649979
      Author: adrianc
      Date: 07 January 2015 00:24:28
      Message:
      Some optimizations for URL lookups.
      ----
      Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java
      Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java
      

      and was later reverted in this commit

      Revision: 1650347
      Author: adrianc
      Date: 08 January 2015 17:53:59
      Message:
      Some small fixups for some of my previous commits.
      ----
      Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java
      Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java
      

      We have found in one of our production servers that line 98 in UtilURL.java

      url = loader.getResource(resourceName);
      

      has caused locking and looking at the stack trace (from jstack) there are numerous threads waiting on locks from within this method

      I propose the cache gets added back (we have done this as a patch on our systems with no ill effect)

      FYI - The commits are in reference to the EntityClassLoader which is not used and does not work see OFBIZ-6210

        Attachments

          Activity

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              gareth.carter Gareth Carter
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: