Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: framework
    • Labels:
      None
    • Sprint:
      Community Day 1 - 2015

      Description

      In OFBIZ-5409 a prefix was added for GET ajax requests.

      It would be beneficial if the prefix could be configured instead of hard coded

        Issue Links

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Hi Chris,

          With the addition of gradle, I would have thought the multi-tenancy functionality would be getting pulled out of OFBiz and into specialpurpose/ as opposed to becoming a first class citizen.

          That's a nice idea, but how to achieve it is another thing. The multi-tenancy all depends on a tweak/hack on the delegator...

          Show
          jacques.le.roux Jacques Le Roux added a comment - Hi Chris, With the addition of gradle, I would have thought the multi-tenancy functionality would be getting pulled out of OFBiz and into specialpurpose/ as opposed to becoming a first class citizen. That's a nice idea, but how to achieve it is another thing. The multi-tenancy all depends on a tweak/hack on the delegator...
          Hide
          cjhowe Chris Howe added a comment -

          Thanks, Pierre.

          I had attempted to go down the EntityUtilProperties route but needed the delegator to accomplish that. I didn't think it was inside the scope of the improvement to make signature changes (and ensure that didn't require further refactor) as would be necessary. Going from hard coded to configurable server wide was more than sufficient for my use case.

          I admit I haven't kept up with the community over the last few years. With the addition of gradle, I would have thought the multi-tenancy functionality would be getting pulled out of OFBiz and into specialpurpose/ as opposed to becoming a first class citizen.

          Anyway, I appreciate your review and improvement to the improvement Cheers.

          Show
          cjhowe Chris Howe added a comment - Thanks, Pierre. I had attempted to go down the EntityUtilProperties route but needed the delegator to accomplish that. I didn't think it was inside the scope of the improvement to make signature changes (and ensure that didn't require further refactor) as would be necessary. Going from hard coded to configurable server wide was more than sufficient for my use case. I admit I haven't kept up with the community over the last few years. With the addition of gradle, I would have thought the multi-tenancy functionality would be getting pulled out of OFBiz and into specialpurpose/ as opposed to becoming a first class citizen. Anyway, I appreciate your review and improvement to the improvement Cheers.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Pierre, I see no reasons to make this issue a subtask of OFBIZ-6164.

          The main change here is not "configurability of OFBiz regarding multi-tenancy" it's only a by product. If we do so with similar issues we will end with a lot of issues under OFBIZ-6164 which are not primarily related to OFBIZ-6164. So please revert to an improvment. Else I'll ask on dev ML what others think, thanks.

          BTW in 1st place you should have asked Chris and I about what we thought about a such change!

          Show
          jacques.le.roux Jacques Le Roux added a comment - Pierre, I see no reasons to make this issue a subtask of OFBIZ-6164 . The main change here is not "configurability of OFBiz regarding multi-tenancy" it's only a by product. If we do so with similar issues we will end with a lot of issues under OFBIZ-6164 which are not primarily related to OFBIZ-6164 . So please revert to an improvment. Else I'll ask on dev ML what others think, thanks. BTW in 1st place you should have asked Chris and I about what we thought about a such change!
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Chris, Pierre,

          Chris your modified patch on Pierre's suggestion is done at r1777942. I made signature and calls changes.

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Chris, Pierre, Chris your modified patch on Pierre's suggestion is done at r1777942. I made signature and calls changes.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Hi Chris, Pierre,
          Chris, I'm taking care of Pierre's request...

          Show
          jacques.le.roux Jacques Le Roux added a comment - Hi Chris, Pierre, Chris, I'm taking care of Pierre's request...
          Hide
          pfm.smits Pierre Smits added a comment -

          Please convert the following string

          String xssiPrefix = UtilProperties.getPropertyValue("general", "http.json.xssi.prefix", "");

          into

          String xssiPrefix =EntityUtilProperties.getPropertyValue("general", "http.json.xssi.prefix", delegator);

          to make the improvement multi-tenant aware.

          Show
          pfm.smits Pierre Smits added a comment - Please convert the following string String xssiPrefix = UtilProperties.getPropertyValue( "general" , "http.json.xssi.prefix" , ""); into String xssiPrefix =EntityUtilProperties.getPropertyValue( "general" , "http.json.xssi.prefix" , delegator); to make the improvement multi-tenant aware.
          Hide
          cjhowe Chris Howe added a comment -

          Creates a xssi.prefix property in general.properties and sets it to "//".

          Show
          cjhowe Chris Howe added a comment - Creates a xssi.prefix property in general.properties and sets it to "//".

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              cjhowe Chris Howe
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile