Details

    • Sprint:
      2016 - OFBiz Community Day 4

      Description

      Refactoring form definitions with type='single'
      Refactoring various lists forms into grids.
      Refactoring various list form references in screen widgets into grid references

        Issue Links

          Activity

          Hide
          pfm.smits Pierre Smits added a comment -

          This patch addresses the issue.

          Show
          pfm.smits Pierre Smits added a comment - This patch addresses the issue.
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          Hi Pierre, any reason why you excluded ExampleFeaturesInLine? It does not work with include-form inside field or you simply started from screens?

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited Hi Pierre, any reason why you excluded ExampleFeaturesInLine? It does not work with include-form inside field or you simply started from screens?
          Hide
          pfm.smits Pierre Smits added a comment -

          Hey Jacques Le Roux,

          Thanks for the feedback. I simply started from looking at forms and the references in screens. I will look at the issue you brought forward.

          Show
          pfm.smits Pierre Smits added a comment - Hey Jacques Le Roux , Thanks for the feedback. I simply started from looking at forms and the references in screens. I will look at the issue you brought forward.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          OK I could answer myself: the grid stuff is incomplete. It lacks an include-grid inside field. This is what you get when you try:

          2016-12-18 17:03:03,115 |http-nio-8443-exec-2 |FieldInfo                     |E| Error rendering form named [ExampleFeaturesInLine] at location [component://example/widget/example/ExampleForms.xml]:
          java.lang.NullPointerException
                  at org.apache.ofbiz.widget.model.FormFactory.createModelForm(FormFactory.java:134) ~[ofbiz.jar:?]
          
          Show
          jacques.le.roux Jacques Le Roux added a comment - OK I could answer myself: the grid stuff is incomplete. It lacks an include-grid inside field. This is what you get when you try: 2016-12-18 17:03:03,115 |http-nio-8443-exec-2 |FieldInfo |E| Error rendering form named [ExampleFeaturesInLine] at location [component: //example/widget/example/ExampleForms.xml]: java.lang.NullPointerException at org.apache.ofbiz.widget.model.FormFactory.createModelForm(FormFactory.java:134) ~[ofbiz.jar:?]
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          This though does not prevent the rest. A last review and I'll apply.

          Show
          jacques.le.roux Jacques Le Roux added a comment - This though does not prevent the rest. A last review and I'll apply.
          Hide
          pfm.smits Pierre Smits added a comment -

          I am still working this issue, [~jacques le roux]

          Show
          pfm.smits Pierre Smits added a comment - I am still working this issue, [~jacques le roux]
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Pierre,

          Your patch is in trunk at revision: 1774906

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Your patch is in trunk at revision: 1774906
          Hide
          pfm.smits Pierre Smits added a comment -

          Hey Jacques Le Roux,

          Thank you for committing the changes, but I informed you 42 minutes ago that I was still working this issue (Status: In Progress) S the issue is not to be closed yet. I will reopen.

          Show
          pfm.smits Pierre Smits added a comment - Hey Jacques Le Roux , Thank you for committing the changes, but I informed you 42 minutes ago that I was still working this issue (Status: In Progress) S the issue is not to be closed yet. I will reopen.
          Hide
          pfm.smits Pierre Smits added a comment -

          Still working the issue.

          Show
          pfm.smits Pierre Smits added a comment - Still working the issue.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Pierre, we crossed on wire, please feel free to improve and fix if necessary (I did not spot any issue with your patch while reviewing and testing)

          Show
          jacques.le.roux Jacques Le Roux added a comment - Pierre, we crossed on wire, please feel free to improve and fix if necessary (I did not spot any issue with your patch while reviewing and testing)

            People

            • Assignee:
              pfm.smits Pierre Smits
              Reporter:
              pfm.smits Pierre Smits
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile