Details

      Description

      go to https://localhost:8443/catalog/control/EditProduct?productId=GZ-1000
      notice missing form elements for 'shopping cart' and 'miscellaneous' section

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Wai for report.

        This was initially my bad at r1446847 for OFBIZ-5136. I should not have
        committed the changes in ProductForms.xml. It went unnoticed during 3 years, then Deepak thought it was done on purpose and committed r1746676 in trunk for OFBIZ-7151.

        So it's only a matter of reverting these changes, done in
        trunk r1765104
        R15.12 r1765105
        R14.12 r1765106
        R13.07 r1765107

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Wai for report. This was initially my bad at r1446847 for OFBIZ-5136 . I should not have committed the changes in ProductForms.xml. It went unnoticed during 3 years, then Deepak thought it was done on purpose and committed r1746676 in trunk for OFBIZ-7151 . So it's only a matter of reverting these changes, done in trunk r1765104 R15.12 r1765105 R14.12 r1765106 R13.07 r1765107
        Hide
        wt Wai added a comment -

        Tested with trunk.
        go to https://localhost:8443/catalog/control/EditProduct?productId=GZ-1000
        'InventoryItem Type ID' is missing form element in 'Inventory' section

        Show
        wt Wai added a comment - Tested with trunk. go to https://localhost:8443/catalog/control/EditProduct?productId=GZ-1000 'InventoryItem Type ID' is missing form element in 'Inventory' section
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        This is related with OFBIZ-7079, which does not simplify things... I have to re-read all there... Help appreciated

        Show
        jacques.le.roux Jacques Le Roux added a comment - This is related with OFBIZ-7079 , which does not simplify things... I have to re-read all there... Help appreciated
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Fortunately I did not have to read it all, this Deepak's comment was enough

        Added condition on EditProduct form at r#1746422, Now inventoryItemTypeId will be enable only for createProduct, and on EditProduct screen it will be displayed as readonly instead of editable dropdown. Also fixed fk-name for inventoryItemTypeId relation

        The only problem is that you can have the inventoryItemTypeId with a null value. It's then considered by convention as not serialised. But then only the label shows. I fixed it at by setting the inventoryItemTypeId as not serialised in this case. It was a bit tricky because you have to consider if the product is null (creation) and then not set product.inventoryItemTypeId. It would else defeat the creation case and give other contradictions.

        Fixed in
        trunk 1766074
        R15.12 r1766076
        R14.12 r1766077
        R13.07 not concerned

        Show
        jacques.le.roux Jacques Le Roux added a comment - Fortunately I did not have to read it all, this Deepak's comment was enough Added condition on EditProduct form at r#1746422, Now inventoryItemTypeId will be enable only for createProduct, and on EditProduct screen it will be displayed as readonly instead of editable dropdown. Also fixed fk-name for inventoryItemTypeId relation The only problem is that you can have the inventoryItemTypeId with a null value. It's then considered by convention as not serialised. But then only the label shows. I fixed it at by setting the inventoryItemTypeId as not serialised in this case. It was a bit tricky because you have to consider if the product is null (creation) and then not set product.inventoryItemTypeId. It would else defeat the creation case and give other contradictions. Fixed in trunk 1766074 R15.12 r1766076 R14.12 r1766077 R13.07 not concerned

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            wt Wai
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development