[OFBIZ-8471] Remove uneccessary call of isNotEmpty() to validate not null generic value

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 16.11.01
• Component/s: ALL COMPONENTS
• Assignee: Divesh Dutta
• Reporter: Ratnesh Upadhyay
• Created: 15/Oct/16 10:08
• Updated: 30/Nov/16 03:57
• Resolved: 05/Nov/16 11:28

Description

There are lots of places in code where we have used UtilValidate.isNotEmpty() to validate GenericValue object. GenericValue will always be null or not null, they will never empty. So instead of using utility method to validate them we should be using native checks onwards.

Example:
Currently we are validating generic value in following ways

if (UtilValidate.isNotEmpty(acctgTransEntry)) {

instead we will using it in this way:

if (acctgTransEntry != null ) { 

Basically these validation methods should preferably be used on Strings or Lists and normal Maps.

Issue Links

• is related to: OFBIZ-4427 Runtime errors with UtilValidate.isEmpty(Object) and IsNotEmpty should be caught during compilation