Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-8316

Update Apache Solr/Lucene to release 6.2.1

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: lucene, solr
    • Labels:
      None
    • Sprint:
      2016 - OFBiz Community Day 4
    1. OFBIZ-8316_corrected.patch
      5 kB
      Michael Brohl
    2. ofbiz-truck-lucene-6.2.1.patch
      4 kB
      caopengan
    3. ofbiz-truck-solr-6.2.1.patch
      3.10 MB
      caopengan
    4. solr6.2.1_1.patch
      69 kB
      caopengan

      Issue Links

        Activity

        Hide
        caopengan caopengan added a comment -

        Solr version has been upgraded by 5.3.1 to 6.2.1. major changes: 1. Solr, lucene jar has been upgraded to 6.2.1;2. Solr management interface to replace angularjs new page;3. Some of the lucene document API changes, also the corresponding replace, solr initialization method is modified;4: the only shortcoming in logging module is not configured, hope to continue to work

        Show
        caopengan caopengan added a comment - Solr version has been upgraded by 5.3.1 to 6.2.1. major changes: 1. Solr, lucene jar has been upgraded to 6.2.1;2. Solr management interface to replace angularjs new page;3. Some of the lucene document API changes, also the corresponding replace, solr initialization method is modified;4: the only shortcoming in logging module is not configured, hope to continue to work
        Hide
        mbrohl Michael Brohl added a comment -

        caopengan,
        thanks for your patch. I will check with my open work on this and give feedback.

        Show
        mbrohl Michael Brohl added a comment - caopengan , thanks for your patch. I will check with my open work on this and give feedback.
        Hide
        mbrohl Michael Brohl added a comment -

        caopengan,

        I tried your patch and found some issues:

        1. the patch does not follow the suggested format described in https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices and contained a project name different from mine so it could not be applied automatically.

        2. I have corrected the patch and changed a version dependency in SearchWorker. The patch is attached.

        I was not able to successfully run the tests, there seem to be a classloader issue, see stacktrace. Have you tested your patch against the lucene tests?

        Exception in thread "DocumentIndexer_test-bW5S94ThgY_content" java.lang.NoClassDefFoundError: Could not initialize class org.apache.lucene.codecs.PostingsFormat$Holder
        > Buildiat org.apache.lucene.codecs.PostingsFormat.forName(PostingsFormat.java:112)
        	at org.apache.lucene.codecs.lucene62.Lucene62Codec.<init>(Lucene62Codec.java:167)
        	at org.apache.lucene.codecs.lucene62.Lucene62Codec.<init>(Lucene62Codec.java:82)
        	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        	at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
        	at java.lang.Class.newInstance(Class.java:442)
        	at org.apache.lucene.util.NamedSPILoader.reload(NamedSPILoader.java:72)
        	at org.apache.lucene.util.NamedSPILoader.<init>(NamedSPILoader.java:51)
        	at org.apache.lucene.util.NamedSPILoader.<init>(NamedSPILoader.java:38)
        	at org.apache.lucene.codecs.Codec$Holder.<clinit>(Codec.java:47)
        	at org.apache.lucene.codecs.Codec.getDefault(Codec.java:143)
        	at org.apache.lucene.index.LiveIndexWriterConfig.<init>(LiveIndexWriterConfig.java:115)
        	at org.apache.lucene.index.IndexWriterConfig.<init>(IndexWriterConfig.java:149)
        	at org.apache.ofbiz.content.search.DocumentIndexer.run(DocumentIndexer.java:103)
        2016-12-17 13:03:45,528 |main                 |TestRunContainer              |W| [JUNIT (error)] - testSearchTermHand : java.lang.NoClassDefFoundError: Could not initialize class org.apache.lucene.codecs.Codec$Holder
        java.lang.NoClassDefFoundError: Could not initialize class org.apache.lucene.codecs.Codec$Holder
        	at org.apache.lucene.codecs.Codec.forName(Codec.java:116) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20]
        	at org.apache.lucene.index.SegmentInfos.readCodec(SegmentInfos.java:417) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20]
        	at org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:349) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20]
        	at org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:284) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20]
        	at org.apache.lucene.index.StandardDirectoryReader$1.doBody(StandardDirectoryReader.java:57) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20]
        	at org.apache.lucene.index.StandardDirectoryReader$1.doBody(StandardDirectoryReader.java:54) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20]
        	at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:685) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20]
        	at org.apache.lucene.index.StandardDirectoryReader.open(StandardDirectoryReader.java:77) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20]
        	at org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:63) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20]
        	at org.apache.ofbiz.content.test.LuceneTests.testSearchTermHand(LuceneTests.java:74) ~[ofbiz.jar:?]
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_45]
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_45]
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_45]
        	at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_45]
        	at junit.framework.TestCase.runTest(TestCase.java:168) ~[junit-dep-4.10.jar:?]
        	at junit.framework.TestCase.runBare(TestCase.java:134) ~[junit-dep-4.10.jar:?]
        	at junit.framework.TestResult$1.protect(TestResult.java:110) ~[junit-dep-4.10.jar:?]
        	at junit.framework.TestResult.runProtected(TestResult.java:128) [junit-dep-4.10.jar:?]
        	at junit.framework.TestResult.run(TestResult.java:113) [junit-dep-4.10.jar:?]
        	at junit.framework.TestCase.run(TestCase.java:124) [junit-dep-4.10.jar:?]
        	at junit.framework.TestSuite.runTest(TestSuite.java:243) [junit-dep-4.10.jar:?]
        	at junit.framework.TestSuite.run(TestSuite.java:238) [junit-dep-4.10.jar:?]
        	at junit.framework.TestSuite.runTest(TestSuite.java:243) [junit-dep-4.10.jar:?]
        	at junit.framework.TestSuite.run(TestSuite.java:238) [junit-dep-4.10.jar:?]
        	at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152) [ofbiz.jar:?]
        	at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148) [ofbiz.jar:?]
        	at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73) [ofbiz.jar:?]
        	at org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:202) [ofbiz.jar:?]
        	at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:69) [ofbiz.jar:?]
        	at org.apache.ofbiz.base.start.Start.main(Start.java:84) [ofbiz.jar:?]
        2016-12-17 13:03:45,541 |main                 |TestRunContainer              |I| [JUNIT] : testSearchTermHand finished.
        2016-12-17 13:03:45,541 |main                 |GenericDelegator              |I| Rolling back 0 entity operations
        2016-12-17 13:03:45,543 |main                 |TestRunContainer              |I| [JUNIT] Results for test suite: lucenetests
        2016-12-17 13:03:45,543 |main                 |TestRunContainer              |I| [JUNIT] Pass: false | # Tests: 1 | # Failed: 0 # Errors: 1
        2016-12-17 13:03:45,543 |main                 |TestRunContainer              |I| [JUNIT] ----------------------------- ERRORS ----------------------------- [JUNIT]
        2016-12-17 13:03:45,543 |main                 |TestRunContainer              |I| --> testSearchTermHand(org.apache.ofbiz.content.test.LuceneTests): Could not initialize class org.apache.lucene.codecs.Codec$Holder
        2016-12-17 13:03:45,543 |main                 |TestRunContainer              |I| java.lang.NoClassDefFoundError: Could not initialize class org.apache.lucene.codecs.Codec$Holder
        	at org.apache.lucene.codecs.Codec.forName(Codec.java:116)
        	at org.apache.lucene.index.SegmentInfos.readCodec(SegmentInfos.java:417)
        	at org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:349)
        	at org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:284)
        	at org.apache.lucene.index.StandardDirectoryReader$1.doBody(StandardDirectoryReader.java:57)
        	at org.apache.lucene.index.StandardDirectoryReader$1.doBody(StandardDirectoryReader.java:54)
        	at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:685)
        	at org.apache.lucene.index.StandardDirectoryReader.open(StandardDirectoryReader.java:77)
        	at org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:63)
        	at org.apache.ofbiz.content.test.LuceneTests.testSearchTermHand(LuceneTests.java:74)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:497)
        	at junit.framework.TestCase.runTest(TestCase.java:168)
        	at junit.framework.TestCase.runBare(TestCase.java:134)
        	at junit.framework.TestResult$1.protect(TestResult.java:110)
        	at junit.framework.TestResult.runProtected(TestResult.java:128)
        	at junit.framework.TestResult.run(TestResult.java:113)
        	at junit.framework.TestCase.run(TestCase.java:124)
        	at junit.framework.TestSuite.runTest(TestSuite.java:243)
        	at junit.framework.TestSuite.run(TestSuite.java:238)
        	at junit.framework.TestSuite.runTest(TestSuite.java:243)
        	at junit.framework.TestSuite.run(TestSuite.java:238)
        	at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
        	at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)
        	at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
        	at org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:202)
        	at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:69)
        	at org.apache.ofbiz.base.start.Start.main(Start.java:84)
        
        2016-12-17 13:03:45,543 |main                 |TestRunContainer              |I| [JUNIT] ------------------------------------------------------------------ [JUNIT]
        2016-12-17 13:03:45,543 |main                 |TestRunContainer              |I| [JUNIT] ---------------------------- FAILURES ---------------------------- [JUNIT]
        2016-12-17 13:03:45,543 |main                 |TestRunContainer              |I| None
        2016-12-17 13:03:45,543 |main                 |TestRunContainer              |I| [JUNIT] ------------------------------------------------------------------ [JUNIT]
        org.apache.ofbiz.base.start.StartupException: Cannot start() org.apache.ofbiz.testtools.TestRunContainer (Test run was unsuccessful)
        	at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:150)
        	at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
        	at org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:202)
        	at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:69)
        	at org.apache.ofbiz.base.start.Start.main(Start.java:84)
        Caused by: org.apache.ofbiz.base.container.ContainerException: Test run was unsuccessful
        	at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:199)
        	at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)
        	... 4 more
        :ofbiz --test component=lucene --test case=lucene-tests FAILED
        Trying to override old definition of datatype junitreport
        [ant:junitreport] the file /Users/mbrohl/Projects/apache-ofbiz/trunk/ofbiz/runtime/logs/test-results/TESTS-TestSuites.xml is not a valid testsuite XML document
        
        Show
        mbrohl Michael Brohl added a comment - caopengan , I tried your patch and found some issues: 1. the patch does not follow the suggested format described in https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices and contained a project name different from mine so it could not be applied automatically. 2. I have corrected the patch and changed a version dependency in SearchWorker. The patch is attached. I was not able to successfully run the tests, there seem to be a classloader issue, see stacktrace. Have you tested your patch against the lucene tests? Exception in thread "DocumentIndexer_test-bW5S94ThgY_content" java.lang.NoClassDefFoundError: Could not initialize class org.apache.lucene.codecs.PostingsFormat$Holder > Buildiat org.apache.lucene.codecs.PostingsFormat.forName(PostingsFormat.java:112) at org.apache.lucene.codecs.lucene62.Lucene62Codec.<init>(Lucene62Codec.java:167) at org.apache.lucene.codecs.lucene62.Lucene62Codec.<init>(Lucene62Codec.java:82) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:422) at java.lang.Class.newInstance(Class.java:442) at org.apache.lucene.util.NamedSPILoader.reload(NamedSPILoader.java:72) at org.apache.lucene.util.NamedSPILoader.<init>(NamedSPILoader.java:51) at org.apache.lucene.util.NamedSPILoader.<init>(NamedSPILoader.java:38) at org.apache.lucene.codecs.Codec$Holder.<clinit>(Codec.java:47) at org.apache.lucene.codecs.Codec.getDefault(Codec.java:143) at org.apache.lucene.index.LiveIndexWriterConfig.<init>(LiveIndexWriterConfig.java:115) at org.apache.lucene.index.IndexWriterConfig.<init>(IndexWriterConfig.java:149) at org.apache.ofbiz.content.search.DocumentIndexer.run(DocumentIndexer.java:103) 2016-12-17 13:03:45,528 |main |TestRunContainer |W| [JUNIT (error)] - testSearchTermHand : java.lang.NoClassDefFoundError: Could not initialize class org.apache.lucene.codecs.Codec$Holder java.lang.NoClassDefFoundError: Could not initialize class org.apache.lucene.codecs.Codec$Holder at org.apache.lucene.codecs.Codec.forName(Codec.java:116) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20] at org.apache.lucene.index.SegmentInfos.readCodec(SegmentInfos.java:417) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20] at org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:349) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20] at org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:284) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20] at org.apache.lucene.index.StandardDirectoryReader$1.doBody(StandardDirectoryReader.java:57) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20] at org.apache.lucene.index.StandardDirectoryReader$1.doBody(StandardDirectoryReader.java:54) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20] at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:685) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20] at org.apache.lucene.index.StandardDirectoryReader.open(StandardDirectoryReader.java:77) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20] at org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:63) ~[lucene-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:15:20] at org.apache.ofbiz.content.test.LuceneTests.testSearchTermHand(LuceneTests.java:74) ~[ofbiz.jar:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_45] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_45] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_45] at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_45] at junit.framework.TestCase.runTest(TestCase.java:168) ~[junit-dep-4.10.jar:?] at junit.framework.TestCase.runBare(TestCase.java:134) ~[junit-dep-4.10.jar:?] at junit.framework.TestResult$1.protect(TestResult.java:110) ~[junit-dep-4.10.jar:?] at junit.framework.TestResult.runProtected(TestResult.java:128) [junit-dep-4.10.jar:?] at junit.framework.TestResult.run(TestResult.java:113) [junit-dep-4.10.jar:?] at junit.framework.TestCase.run(TestCase.java:124) [junit-dep-4.10.jar:?] at junit.framework.TestSuite.runTest(TestSuite.java:243) [junit-dep-4.10.jar:?] at junit.framework.TestSuite.run(TestSuite.java:238) [junit-dep-4.10.jar:?] at junit.framework.TestSuite.runTest(TestSuite.java:243) [junit-dep-4.10.jar:?] at junit.framework.TestSuite.run(TestSuite.java:238) [junit-dep-4.10.jar:?] at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152) [ofbiz.jar:?] at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148) [ofbiz.jar:?] at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73) [ofbiz.jar:?] at org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:202) [ofbiz.jar:?] at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:69) [ofbiz.jar:?] at org.apache.ofbiz.base.start.Start.main(Start.java:84) [ofbiz.jar:?] 2016-12-17 13:03:45,541 |main |TestRunContainer |I| [JUNIT] : testSearchTermHand finished. 2016-12-17 13:03:45,541 |main |GenericDelegator |I| Rolling back 0 entity operations 2016-12-17 13:03:45,543 |main |TestRunContainer |I| [JUNIT] Results for test suite: lucenetests 2016-12-17 13:03:45,543 |main |TestRunContainer |I| [JUNIT] Pass: false | # Tests: 1 | # Failed: 0 # Errors: 1 2016-12-17 13:03:45,543 |main |TestRunContainer |I| [JUNIT] ----------------------------- ERRORS ----------------------------- [JUNIT] 2016-12-17 13:03:45,543 |main |TestRunContainer |I| --> testSearchTermHand(org.apache.ofbiz.content.test.LuceneTests): Could not initialize class org.apache.lucene.codecs.Codec$Holder 2016-12-17 13:03:45,543 |main |TestRunContainer |I| java.lang.NoClassDefFoundError: Could not initialize class org.apache.lucene.codecs.Codec$Holder at org.apache.lucene.codecs.Codec.forName(Codec.java:116) at org.apache.lucene.index.SegmentInfos.readCodec(SegmentInfos.java:417) at org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:349) at org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:284) at org.apache.lucene.index.StandardDirectoryReader$1.doBody(StandardDirectoryReader.java:57) at org.apache.lucene.index.StandardDirectoryReader$1.doBody(StandardDirectoryReader.java:54) at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:685) at org.apache.lucene.index.StandardDirectoryReader.open(StandardDirectoryReader.java:77) at org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:63) at org.apache.ofbiz.content.test.LuceneTests.testSearchTermHand(LuceneTests.java:74) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at junit.framework.TestCase.runTest(TestCase.java:168) at junit.framework.TestCase.runBare(TestCase.java:134) at junit.framework.TestResult$1.protect(TestResult.java:110) at junit.framework.TestResult.runProtected(TestResult.java:128) at junit.framework.TestResult.run(TestResult.java:113) at junit.framework.TestCase.run(TestCase.java:124) at junit.framework.TestSuite.runTest(TestSuite.java:243) at junit.framework.TestSuite.run(TestSuite.java:238) at junit.framework.TestSuite.runTest(TestSuite.java:243) at junit.framework.TestSuite.run(TestSuite.java:238) at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152) at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148) at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73) at org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:202) at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:69) at org.apache.ofbiz.base.start.Start.main(Start.java:84) 2016-12-17 13:03:45,543 |main |TestRunContainer |I| [JUNIT] ------------------------------------------------------------------ [JUNIT] 2016-12-17 13:03:45,543 |main |TestRunContainer |I| [JUNIT] ---------------------------- FAILURES ---------------------------- [JUNIT] 2016-12-17 13:03:45,543 |main |TestRunContainer |I| None 2016-12-17 13:03:45,543 |main |TestRunContainer |I| [JUNIT] ------------------------------------------------------------------ [JUNIT] org.apache.ofbiz.base.start.StartupException: Cannot start() org.apache.ofbiz.testtools.TestRunContainer (Test run was unsuccessful) at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:150) at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73) at org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:202) at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:69) at org.apache.ofbiz.base.start.Start.main(Start.java:84) Caused by: org.apache.ofbiz.base.container.ContainerException: Test run was unsuccessful at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:199) at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148) ... 4 more :ofbiz --test component=lucene --test case=lucene-tests FAILED Trying to override old definition of datatype junitreport [ant:junitreport] the file /Users/mbrohl/Projects/apache-ofbiz/trunk/ofbiz/runtime/logs/test-results/TESTS-TestSuites.xml is not a valid testsuite XML document
        Hide
        mbrohl Michael Brohl added a comment -

        The corrected and enhanced patch.

        Show
        mbrohl Michael Brohl added a comment - The corrected and enhanced patch.
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Thanks Michael and caopengan(曹鹏安) for the contribution!

        Your patches are in trunk rev. 1776930.

        To caopengan:
        Would it possible to add a sample page in solr component, i.e. uri /solr/control/sample? Provides several basic functions:
        1. search products with productId or product name
        2. provide suggestions while user inputing the productId or product name
        3. paginate with AngularJS included in Solr 6.2.1

        Happy new year.

        Show
        shi.jinghai Shi Jinghai added a comment - Thanks Michael and caopengan(曹鹏安) for the contribution! Your patches are in trunk rev. 1776930. To caopengan: Would it possible to add a sample page in solr component, i.e. uri /solr/control/sample? Provides several basic functions: 1. search products with productId or product name 2. provide suggestions while user inputing the productId or product name 3. paginate with AngularJS included in Solr 6.2.1 Happy new year.
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Oh, the bug on viewing solr log file is OFBIZ-6858. I'll try to work on it later.

        Show
        shi.jinghai Shi Jinghai added a comment - Oh, the bug on viewing solr log file is OFBIZ-6858 . I'll try to work on it later.
        Hide
        mbrohl Michael Brohl added a comment -

        Shi Jinghai,

        I'm not sure if this was ready to commit. I was not able to run the tests without error, see my above comments. Hence I did not commit.
        Did you correct the error?

        Show
        mbrohl Michael Brohl added a comment - Shi Jinghai , I'm not sure if this was ready to commit. I was not able to run the tests without error, see my above comments. Hence I did not commit. Did you correct the error?
        Hide
        shi.jinghai Shi Jinghai added a comment -

        No, I didn't correct the error you mentioned. Let me check it now.

        Sorry for my crude submit.

        Show
        shi.jinghai Shi Jinghai added a comment - No, I didn't correct the error you mentioned. Let me check it now. Sorry for my crude submit.
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Hi Michael,

        I have run the Lucene test cases locally and successfully:
        lucene-tests-data-load took 0.009s
        testSearchTermHand took 3.534s

        Kind Regards,

        Show
        shi.jinghai Shi Jinghai added a comment - Hi Michael, I have run the Lucene test cases locally and successfully: lucene-tests-data-load took 0.009s testSearchTermHand took 3.534s Kind Regards,
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Hi PengAn,

        It would great if you can remove the "original UI" files of solr and submit a patch on it. The original UI is deprecated, right?

        Thanks,

        Show
        shi.jinghai Shi Jinghai added a comment - Hi PengAn, It would great if you can remove the "original UI" files of solr and submit a patch on it. The original UI is deprecated, right? Thanks,
        Hide
        mbrohl Michael Brohl added a comment -

        Thanks, Shi Jinghai,

        it seems that it works in the overall integration tests and if you run them by hand one after the other.
        If I run

        ./gradlew "ofbiz --test component=lucene --test case=lucene-tests"

        it shows the above errors. Must be a problem with the test suite.

        Show
        mbrohl Michael Brohl added a comment - Thanks, Shi Jinghai , it seems that it works in the overall integration tests and if you run them by hand one after the other. If I run ./gradlew "ofbiz --test component=lucene --test case=lucene-tests" it shows the above errors. Must be a problem with the test suite.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Not sure how important it is but I see that in log when loading:

        2017-01-03 03:05:05,944 |dExecutor-6-thread-1 |CoreContainer                 |E| Error creating core [solrdefault]: Error opening new searcher
        org.apache.solr.common.SolrException: Error opening new searcher
        	at org.apache.solr.core.SolrCore.<init>(SolrCore.java:815) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.<init>(SolrCore.java:688) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.CoreContainer.create(CoreContainer.java:838) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.CoreContainer.lambda$load$0(CoreContainer.java:494) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_111]
        	at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:229) ~[solr-solrj-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:55]
        	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_111]
        	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_111]
        	at java.lang.Thread.run(Thread.java:745) [?:1.8.0_111]
        Caused by: org.apache.solr.common.SolrException: Error opening new searcher
        	at org.apache.solr.core.SolrCore.openNewSearcher(SolrCore.java:1695) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1806) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.initSearcher(SolrCore.java:902) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.<init>(SolrCore.java:788) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	... 8 more
        Caused by: java.lang.IllegalArgumentException: cannot wrap points
        	at org.apache.solr.index.SlowCompositeReaderWrapper.<init>(SlowCompositeReaderWrapper.java:88) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.index.SlowCompositeReaderWrapper.wrap(SlowCompositeReaderWrapper.java:77) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.search.SolrIndexSearcher.<init>(SolrIndexSearcher.java:248) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.openNewSearcher(SolrCore.java:1663) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1806) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.initSearcher(SolrCore.java:902) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.<init>(SolrCore.java:788) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	... 8 more
        2017-01-03 03:05:05,948 |kExecutor-2-thread-1 |CoreContainer                 |E| Error waiting for SolrCore to be created
        java.util.concurrent.ExecutionException: org.apache.solr.common.SolrException: Unable to create core [solrdefault]
        	at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_111]
        	at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_111]
        	at org.apache.solr.core.CoreContainer.lambda$load$1(CoreContainer.java:522) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_111]
        	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_111]
        	at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:229) ~[solr-solrj-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:55]
        	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_111]
        	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_111]
        	at java.lang.Thread.run(Thread.java:745) [?:1.8.0_111]
        Caused by: org.apache.solr.common.SolrException: Unable to create core [solrdefault]
        	at org.apache.solr.core.CoreContainer.create(CoreContainer.java:851) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.CoreContainer.lambda$load$0(CoreContainer.java:494) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	... 5 more
        Caused by: org.apache.solr.common.SolrException: Error opening new searcher
        	at org.apache.solr.core.SolrCore.<init>(SolrCore.java:815) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.<init>(SolrCore.java:688) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.CoreContainer.create(CoreContainer.java:838) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.CoreContainer.lambda$load$0(CoreContainer.java:494) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	... 5 more
        Caused by: org.apache.solr.common.SolrException: Error opening new searcher
        	at org.apache.solr.core.SolrCore.openNewSearcher(SolrCore.java:1695) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1806) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.initSearcher(SolrCore.java:902) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.<init>(SolrCore.java:788) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.<init>(SolrCore.java:688) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.CoreContainer.create(CoreContainer.java:838) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.CoreContainer.lambda$load$0(CoreContainer.java:494) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	... 5 more
        Caused by: java.lang.IllegalArgumentException: cannot wrap points
        	at org.apache.solr.index.SlowCompositeReaderWrapper.<init>(SlowCompositeReaderWrapper.java:88) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.index.SlowCompositeReaderWrapper.wrap(SlowCompositeReaderWrapper.java:77) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.search.SolrIndexSearcher.<init>(SolrIndexSearcher.java:248) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.openNewSearcher(SolrCore.java:1663) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1806) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.initSearcher(SolrCore.java:902) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.<init>(SolrCore.java:788) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.SolrCore.<init>(SolrCore.java:688) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.CoreContainer.create(CoreContainer.java:838) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	at org.apache.solr.core.CoreContainer.lambda$load$0(CoreContainer.java:494) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53]
        	... 5 more
        
        Show
        jacques.le.roux Jacques Le Roux added a comment - Not sure how important it is but I see that in log when loading: 2017-01-03 03:05:05,944 |dExecutor-6-thread-1 |CoreContainer |E| Error creating core [solrdefault]: Error opening new searcher org.apache.solr.common.SolrException: Error opening new searcher at org.apache.solr.core.SolrCore.<init>(SolrCore.java:815) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.<init>(SolrCore.java:688) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.CoreContainer.create(CoreContainer.java:838) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.CoreContainer.lambda$load$0(CoreContainer.java:494) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_111] at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:229) ~[solr-solrj-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:55] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_111] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_111] at java.lang. Thread .run( Thread .java:745) [?:1.8.0_111] Caused by: org.apache.solr.common.SolrException: Error opening new searcher at org.apache.solr.core.SolrCore.openNewSearcher(SolrCore.java:1695) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1806) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.initSearcher(SolrCore.java:902) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.<init>(SolrCore.java:788) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] ... 8 more Caused by: java.lang.IllegalArgumentException: cannot wrap points at org.apache.solr.index.SlowCompositeReaderWrapper.<init>(SlowCompositeReaderWrapper.java:88) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.index.SlowCompositeReaderWrapper.wrap(SlowCompositeReaderWrapper.java:77) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.search.SolrIndexSearcher.<init>(SolrIndexSearcher.java:248) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.openNewSearcher(SolrCore.java:1663) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1806) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.initSearcher(SolrCore.java:902) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.<init>(SolrCore.java:788) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] ... 8 more 2017-01-03 03:05:05,948 |kExecutor-2-thread-1 |CoreContainer |E| Error waiting for SolrCore to be created java.util.concurrent.ExecutionException: org.apache.solr.common.SolrException: Unable to create core [solrdefault] at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_111] at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_111] at org.apache.solr.core.CoreContainer.lambda$load$1(CoreContainer.java:522) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_111] at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_111] at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:229) ~[solr-solrj-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:55] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_111] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_111] at java.lang. Thread .run( Thread .java:745) [?:1.8.0_111] Caused by: org.apache.solr.common.SolrException: Unable to create core [solrdefault] at org.apache.solr.core.CoreContainer.create(CoreContainer.java:851) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.CoreContainer.lambda$load$0(CoreContainer.java:494) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] ... 5 more Caused by: org.apache.solr.common.SolrException: Error opening new searcher at org.apache.solr.core.SolrCore.<init>(SolrCore.java:815) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.<init>(SolrCore.java:688) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.CoreContainer.create(CoreContainer.java:838) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.CoreContainer.lambda$load$0(CoreContainer.java:494) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] ... 5 more Caused by: org.apache.solr.common.SolrException: Error opening new searcher at org.apache.solr.core.SolrCore.openNewSearcher(SolrCore.java:1695) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1806) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.initSearcher(SolrCore.java:902) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.<init>(SolrCore.java:788) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.<init>(SolrCore.java:688) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.CoreContainer.create(CoreContainer.java:838) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.CoreContainer.lambda$load$0(CoreContainer.java:494) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] ... 5 more Caused by: java.lang.IllegalArgumentException: cannot wrap points at org.apache.solr.index.SlowCompositeReaderWrapper.<init>(SlowCompositeReaderWrapper.java:88) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.index.SlowCompositeReaderWrapper.wrap(SlowCompositeReaderWrapper.java:77) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.search.SolrIndexSearcher.<init>(SolrIndexSearcher.java:248) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.openNewSearcher(SolrCore.java:1663) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1806) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.initSearcher(SolrCore.java:902) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.<init>(SolrCore.java:788) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.SolrCore.<init>(SolrCore.java:688) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.CoreContainer.create(CoreContainer.java:838) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] at org.apache.solr.core.CoreContainer.lambda$load$0(CoreContainer.java:494) ~[solr-core-6.2.1.jar:6.2.1 43ab70147eb494324a1410f7a9f16a896a59bc6f - shalin - 2016-09-15 05:20:53] ... 5 more
        Hide
        mbrohl Michael Brohl added a comment -

        Shi Jinghai,

        I would prefer that you revert the commit until all issues are resolved (the errors Jacques reported, missing removal of obsolete UI files). In this way, you and other fellow contributors have time to work on them and we stay with a consistent codebase until we have a complete patch.

        What do you think?

        Show
        mbrohl Michael Brohl added a comment - Shi Jinghai , I would prefer that you revert the commit until all issues are resolved (the errors Jacques reported, missing removal of obsolete UI files). In this way, you and other fellow contributors have time to work on them and we stay with a consistent codebase until we have a complete patch. What do you think?
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Hi Michael,

        Thanks for the reminding! Really appreciate it.

        I didn't notice the errors Jacques found, now I find it while visiting https://ofbiz-vm2.apache.org:8443/solr/, I'm sure it's a problem of dataDir in solrconfig.xml. I'm fixing it.

        I have asked PengAn to submit a patch to remove the deprecated UI files tomorrow, and he promised me OK. If the patch come, we can keep .

        Kind Regards,

        Show
        shi.jinghai Shi Jinghai added a comment - Hi Michael, Thanks for the reminding! Really appreciate it. I didn't notice the errors Jacques found, now I find it while visiting https://ofbiz-vm2.apache.org:8443/solr/ , I'm sure it's a problem of dataDir in solrconfig.xml. I'm fixing it. I have asked PengAn to submit a patch to remove the deprecated UI files tomorrow, and he promised me OK. If the patch come, we can keep . Kind Regards,
        Hide
        mbrohl Michael Brohl added a comment -

        Hi Shi Jinghai,

        thanks for your response.

        What I was trying to say is that we should, at least for the future, prepare and check everything before committing to the codebase.
        Every contribution is much appreciated but even if trunk is not stable, we should avoid any inconsistencies or half done code going into the codebase.

        Thanks and regards,

        Michael

        Show
        mbrohl Michael Brohl added a comment - Hi Shi Jinghai , thanks for your response. What I was trying to say is that we should, at least for the future, prepare and check everything before committing to the codebase. Every contribution is much appreciated but even if trunk is not stable, we should avoid any inconsistencies or half done code going into the codebase. Thanks and regards, Michael
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Unfortunately, I'm a human and programmer, I write codes everyday, and bugs everyday.

        Show
        shi.jinghai Shi Jinghai added a comment - Unfortunately, I'm a human and programmer, I write codes everyday, and bugs everyday.
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Hi Jacques,

        On the errors you found, I tested locally and checked our production system, an absolute path configed in dataDir of solrconfig.xml would work fine, i.e.

        for Windows:
        <dataDir>D:/workspaces/OFBiz/ofbiz/runtime/indexes/</dataDir>

        for Linux:
        <dataDir>/opt/ofbiz/runtime/indexes/</dataDir>

        The product index can be loaded correctly and the tlog folder will be under runtime/indexes/ as expected.

        Kind Regards,

        Show
        shi.jinghai Shi Jinghai added a comment - Hi Jacques, On the errors you found, I tested locally and checked our production system, an absolute path configed in dataDir of solrconfig.xml would work fine, i.e. for Windows: <dataDir>D:/workspaces/OFBiz/ofbiz/runtime/indexes/</dataDir> for Linux: <dataDir>/opt/ofbiz/runtime/indexes/</dataDir> The product index can be loaded correctly and the tlog folder will be under runtime/indexes/ as expected. Kind Regards,
        Hide
        caopengan caopengan added a comment -

        Delete the old solr5.3.1 page file

        Show
        caopengan caopengan added a comment - Delete the old solr5.3.1 page file
        Hide
        caopengan caopengan added a comment -

        Because of updated solr6.2.1, solr5.2.1 used in project page file is useless, so this time will be useless HTML files deleted

        Show
        caopengan caopengan added a comment - Because of updated solr6.2.1, solr5.2.1 used in project page file is useless, so this time will be useless HTML files deleted
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Jinghai,

        I wanted to look into this in detail to see if we can find a way to have something set for OFBiz OOTB. So I Googled for "solr set dataDir dynamically" but I'm short of time atm. Did you think at it already?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Jinghai, I wanted to look into this in detail to see if we can find a way to have something set for OFBiz OOTB. So I Googled for "solr set dataDir dynamically" but I'm short of time atm. Did you think at it already?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I confirm I do the same

        Show
        jacques.le.roux Jacques Le Roux added a comment - I confirm I do the same
        Hide
        mbrohl Michael Brohl added a comment -

        Default is /data in solr home.

        See https://cwiki.apache.org/confluence/display/solr/DataDir+and+DirectoryFactory+in+SolrConfig

        You can specify the solr home dynamically with -Dsolr.solr.home=/Users/foo/ofbiz/specialpurpose/solr/home

        (using the old way to start OFBiz through ofbiz.jar, I have not the time to look how it works with gradle at the moment).

        Show
        mbrohl Michael Brohl added a comment - Default is /data in solr home. See https://cwiki.apache.org/confluence/display/solr/DataDir+and+DirectoryFactory+in+SolrConfig You can specify the solr home dynamically with -Dsolr.solr.home=/Users/foo/ofbiz/specialpurpose/solr/home (using the old way to start OFBiz through ofbiz.jar, I have not the time to look how it works with gradle at the moment).
        Hide
        mbrohl Michael Brohl added a comment -

        Please don't misunderstand me: it's not about making failures, it's about the process.
        But I won't insist on this any more...

        Show
        mbrohl Michael Brohl added a comment - Please don't misunderstand me: it's not about making failures, it's about the process. But I won't insist on this any more...
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Hi Jacques,

        Sorry, I'm totally wrong. Today Cao Pengan helped me to reproduce the error you found locally. It's the products index couldn't be recogonized by solr after running loadDefault.

        I don't know why, but the content index is OK (the content index can be generated by running test lucene component). Setting it as solrdefault in runtime/indexes/index.properties: index=content, start ofbiz, in this case solr works fine.

        We'll try to find how to resolve this problem.

        Kind Regards,

        Show
        shi.jinghai Shi Jinghai added a comment - Hi Jacques, Sorry, I'm totally wrong. Today Cao Pengan helped me to reproduce the error you found locally. It's the products index couldn't be recogonized by solr after running loadDefault. I don't know why, but the content index is OK (the content index can be generated by running test lucene component). Setting it as solrdefault in runtime/indexes/index.properties: index=content, start ofbiz, in this case solr works fine. We'll try to find how to resolve this problem. Kind Regards,
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Actually the official commit process the OFBiz project uses is CTR (Commit Then Review) not RTC.

        Of course things should be taken with a grain of salt, and in this case

        1. Jinghai should have assigned the issue to himself when he committed
        2. Before that the "Provide Patch" button should have been pushed by the person who provided the patch (caopengan here)
        3. Then the "Start Progress" button should have been pushed (by Jinghai since he started by committing in 1st place)

        I'm doing it for you now guys, please remember, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Actually the official commit process the OFBiz project uses is CTR (Commit Then Review) not RTC. Of course things should be taken with a grain of salt, and in this case Jinghai should have assigned the issue to himself when he committed Before that the "Provide Patch" button should have been pushed by the person who provided the patch (caopengan here) Then the "Start Progress" button should have been pushed (by Jinghai since he started by committing in 1st place) I'm doing it for you now guys, please remember, thanks!
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Ah, since I did not assign to me the "Start Progress" button does not appear, please Jinghai do.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Ah, since I did not assign to me the "Start Progress" button does not appear, please Jinghai do.
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Yesterday, I played indexProduct method of ProductDocument.java for several hours with
        clean build loadDefault :ofbiz.

        The problem that products index cannot be loaded turns out to be caused by LongPoint and DoublePoint fields, comment out the fields related to these two methods used in indexProduct, everything will be ok.

        Today, I'll check further why the LongPoint and DoublePoint fields cannot work in our project environment (they are correct in solr test cases i.e. TestFieldCacheSort.java).

        Show
        shi.jinghai Shi Jinghai added a comment - Yesterday, I played indexProduct method of ProductDocument.java for several hours with clean build loadDefault :ofbiz. The problem that products index cannot be loaded turns out to be caused by LongPoint and DoublePoint fields, comment out the fields related to these two methods used in indexProduct, everything will be ok. Today, I'll check further why the LongPoint and DoublePoint fields cannot work in our project environment (they are correct in solr test cases i.e. TestFieldCacheSort.java).
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Updating the status of this issue:

        I checked Solr source code and found SOLR-8396. I think Solr will be able to support point values in next release (6.4.1 or 6.5.0) as I read the new implement in Solr and it seems good:
        https://github.com/apache/lucene-solr/commit/57934ba4480d71218c7f60d0417dbae9d26188d0

        For now, I plan to change LongPoint and DoublePoint fields to String field to make solr work in trunk version, and I'll change them back when updating to new release of Solr.

        Any suggestions are welcome.

        Kind Regards,

        Show
        shi.jinghai Shi Jinghai added a comment - Updating the status of this issue: I checked Solr source code and found SOLR-8396 . I think Solr will be able to support point values in next release (6.4.1 or 6.5.0) as I read the new implement in Solr and it seems good: https://github.com/apache/lucene-solr/commit/57934ba4480d71218c7f60d0417dbae9d26188d0 For now, I plan to change LongPoint and DoublePoint fields to String field to make solr work in trunk version, and I'll change them back when updating to new release of Solr. Any suggestions are welcome. Kind Regards,
        Hide
        shi.jinghai Shi Jinghai added a comment -

        A temp fix is submitted in rev. 1780133.

        To caopengan:

        Hi Pengan,

        It would be great if you can change the products and content indexes folder structure like:
        runtime/indexes/products/index
        runtime/indexes/products/snapshot_metadata
        runtime/indexes/products/tlog

        runtime/indexes/content/index
        runtime/indexes/content/snapshot_metadata
        runtime/indexes/content/tlog

        TIA,

        Show
        shi.jinghai Shi Jinghai added a comment - A temp fix is submitted in rev. 1780133. To caopengan: Hi Pengan, It would be great if you can change the products and content indexes folder structure like: runtime/indexes/products/index runtime/indexes/products/snapshot_metadata runtime/indexes/products/tlog runtime/indexes/content/index runtime/indexes/content/snapshot_metadata runtime/indexes/content/tlog TIA,
        Hide
        shi.jinghai Shi Jinghai added a comment -

        I have tested Lucene/Solr 6.4.1, the error on wrapping point fields is still there. I'll wait their next release and try again.

        Show
        shi.jinghai Shi Jinghai added a comment - I have tested Lucene/Solr 6.4.1, the error on wrapping point fields is still there. I'll wait their next release and try again.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Hi Jinghai, Pengan,

        What is the situation here? I stumbled upon this pending issue while working on OFBIZ-9301.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi Jinghai, Pengan, What is the situation here? I stumbled upon this pending issue while working on OFBIZ-9301 .
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        BTW what is the situation in R16.11?

        Show
        jacques.le.roux Jacques Le Roux added a comment - BTW what is the situation in R16.11?
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Hi Jacques,

        Thanks for the ping!

        Happy to see Lucene/Solr 6.5.0 has released. I changed lucene and solr from 6.2.1 to 6.5.0, ProductDocument.java to use LongPoint and DoublePoint locally, it works great fine now.

        I'll ask Pengan to upgrade all the files (including html and js files) to 6.5.0 and submit a new patch when we meet next Tuesday.

        Cheers,

        Show
        shi.jinghai Shi Jinghai added a comment - Hi Jacques, Thanks for the ping! Happy to see Lucene/Solr 6.5.0 has released. I changed lucene and solr from 6.2.1 to 6.5.0, ProductDocument.java to use LongPoint and DoublePoint locally, it works great fine now. I'll ask Pengan to upgrade all the files (including html and js files) to 6.5.0 and submit a new patch when we meet next Tuesday. Cheers,
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Show
        jacques.le.roux Jacques Le Roux added a comment -
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Ping?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Ping?
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        BTW we need to move the Lucene index from the Solr component. Actually both should be in the common runtime directory, I started a discussion on dev ML: https://s.apache.org/KJ6n and this is related with OFBIZ-7265

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited BTW we need to move the Lucene index from the Solr component. Actually both should be in the common runtime directory, I started a discussion on dev ML: https://s.apache.org/KJ6n and this is related with OFBIZ-7265
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Thanks Jacques for the ping!

        I discussed the solr component upgrade with Pengan last Tuesday, he suggested waiting solr 6.5.1 as it is in the procedure of release voting. I just checked the status, it's in RC2 now:
        https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.5.1-RC2-revcd1f23c63abe03ae650c75ec8ccb37762806cc75

        I guess the 6.5.1 will be final released before May 1.

        Show
        shi.jinghai Shi Jinghai added a comment - Thanks Jacques for the ping! I discussed the solr component upgrade with Pengan last Tuesday, he suggested waiting solr 6.5.1 as it is in the procedure of release voting. I just checked the status, it's in RC2 now: https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.5.1-RC2-revcd1f23c63abe03ae650c75ec8ccb37762806cc75 I guess the 6.5.1 will be final released before May 1.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks for the update Jinghai

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks for the update Jinghai
        Hide
        mbrohl Michael Brohl added a comment -

        solr 6.5.1 was released today.

        Show
        mbrohl Michael Brohl added a comment - solr 6.5.1 was released today.
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Thanks Michael. Go go go

        Show
        shi.jinghai Shi Jinghai added a comment - Thanks Michael. Go go go
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Thanks Cao Pengan for the new 6.5.1 patch! I have submitted it to plugins-trunk, rev.1794770, 1794771.

        Cheers,

        Show
        shi.jinghai Shi Jinghai added a comment - Thanks Cao Pengan for the new 6.5.1 patch! I have submitted it to plugins-trunk, rev.1794770, 1794771. Cheers,
        Hide
        mbrohl Michael Brohl added a comment -

        Thanks, Shi Jinghai,

        I think you can close this ticket, no?

        Regards,
        Michael

        Show
        mbrohl Michael Brohl added a comment - Thanks, Shi Jinghai , I think you can close this ticket, no? Regards, Michael
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Thanks Cao Pengan, Jinghai, Michael,

        The error I reported

        Error waiting for SolrCore to be created

        I guess (as suggested by Jinghai) was fixed by OFBIZ-7265 (can't reproduce)

        After reviewing rev.1794770, 1794771 I tough see few reasons to keep this issue open, for at least discussion.

        Jinghai, do we really need to keep these commented out lines? https://s.apache.org/DTEG
        Form your comment

        OFBiz-8316, the LongPoint should be reused when updating to Solr 6.4.1 or later

        it seems not.

        What about

        -  <dataDir>${solr.data.dir:runtime/indexes/solr}</dataDir>
        +  <dataDir>${ofbiz.home}/runtime/indexes/products/</dataDir>
        

        Should we not put all under runtime/indexes/solr. So here runtime/indexes/solr/products? I know it changes habits, so not sure.

        I wonder if we should not rename "runtime/indexes/solr" to "runtime/indexes/solrAndLucene" just to let know users that all Solr and Lucene indexes are there.

        On the Solr admin UI, can't we remove the now confusing "Use original UI", since we only use one now (not a big deal).

        Ah Jinghai, I just noticed something trivial and very ASF formal. You say

        Thanks Cao Pengan for the new 6.5.1 patch!

        But I don't see this patch. For me, it's not really an issue. But, following ASF rules, the patch should have been attached by Cao Pengan before being committed by you

        The idea is: it's the person who contribute who delegates her/his rights (copyright) to the ASF. Of course if you did not have wrote this sentence I'd not know. I know other teams (I guess you somehow works with Cao Pengan) are doing that (still not orthodox). Not a big deal, more for you to know

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Thanks Cao Pengan, Jinghai, Michael, The error I reported Error waiting for SolrCore to be created I guess (as suggested by Jinghai) was fixed by OFBIZ-7265 (can't reproduce) After reviewing rev.1794770, 1794771 I tough see few reasons to keep this issue open, for at least discussion. Jinghai, do we really need to keep these commented out lines? https://s.apache.org/DTEG Form your comment OFBiz-8316, the LongPoint should be reused when updating to Solr 6.4.1 or later it seems not. What about - <dataDir>${solr.data.dir:runtime/indexes/solr}</dataDir> + <dataDir>${ofbiz.home}/runtime/indexes/products/</dataDir> Should we not put all under runtime/indexes/solr. So here runtime/indexes/solr/products? I know it changes habits, so not sure. I wonder if we should not rename "runtime/indexes/solr" to "runtime/indexes/solrAndLucene" just to let know users that all Solr and Lucene indexes are there. On the Solr admin UI, can't we remove the now confusing "Use original UI", since we only use one now (not a big deal). Ah Jinghai, I just noticed something trivial and very ASF formal. You say Thanks Cao Pengan for the new 6.5.1 patch! But I don't see this patch. For me, it's not really an issue. But, following ASF rules, the patch should have been attached by Cao Pengan before being committed by you The idea is: it's the person who contribute who delegates her/his rights (copyright) to the ASF. Of course if you did not have wrote this sentence I'd not know. I know other teams (I guess you somehow works with Cao Pengan) are doing that (still not orthodox). Not a big deal, more for you to know
        Hide
        shi.jinghai Shi Jinghai added a comment -

        Yes, Pengan and me are in the same team. Pengan gave me the patch face to face a week ago. I'm a bit late to check them in.

        I removed the comments related to this issue in rev. 1794801.

        On the "runtime/indexes/products", the "products" index name is hardcoded in plugins/lucene/src/main/java/org/apache/ofbiz/content/search/SearchServices.java:
        DocumentIndexer indexer = DocumentIndexer.getInstance(delegator, "products");

        Show
        shi.jinghai Shi Jinghai added a comment - Yes, Pengan and me are in the same team. Pengan gave me the patch face to face a week ago. I'm a bit late to check them in. I removed the comments related to this issue in rev. 1794801. On the "runtime/indexes/products", the "products" index name is hardcoded in plugins/lucene/src/main/java/org/apache/ofbiz/content/search/SearchServices.java: DocumentIndexer indexer = DocumentIndexer.getInstance(delegator, "products");
        Hide
        mbrohl Michael Brohl added a comment -

        Jacques Le Roux,

        I wonder if we should not rename "runtime/indexes/solr" to "runtime/indexes/solrAndLucene" just to let know users that all Solr and Lucene indexes are there.

        I would leave it as it is here. Solr uses Lucene for indexing so there is in fact no Solr index but a Lucene index created through Solr. Since the component is named Solr, it makes sense to name it as is.

        Show
        mbrohl Michael Brohl added a comment - Jacques Le Roux , I wonder if we should not rename "runtime/indexes/solr" to "runtime/indexes/solrAndLucene" just to let know users that all Solr and Lucene indexes are there. I would leave it as it is here. Solr uses Lucene for indexing so there is in fact no Solr index but a Lucene index created through Solr. Since the component is named Solr, it makes sense to name it as is.
        Hide
        mbrohl Michael Brohl added a comment - - edited

        Shi Jinghai,

        On the "runtime/indexes/products", the "products" index name is hardcoded in plugins/lucene/src/main/java/org/apache/ofbiz/content/search/SearchServices.java:
        DocumentIndexer indexer = DocumentIndexer.getInstance(delegator, "products");

        We should make this configurable, I think. But this would be another issue.

        Show
        mbrohl Michael Brohl added a comment - - edited Shi Jinghai , On the "runtime/indexes/products", the "products" index name is hardcoded in plugins/lucene/src/main/java/org/apache/ofbiz/content/search/SearchServices.java: DocumentIndexer indexer = DocumentIndexer.getInstance(delegator, "products"); We should make this configurable, I think. But this would be another issue.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Jinghai, Michael,

        Michael,

        I would leave it as it is here. Solr uses Lucene for indexing so there is in fact no Solr index but a Lucene index created through Solr. Since the component is named Solr, it makes sense to name it as is.

        After JInghai's answer, I made a quick review. The runtime\indexes\content and runtime\indexes\product dirs are only used by Lucene. The runtime\indexes\solr is only used by Solr. So I suggest rather to have as defaults runtime\indexes\lucene\content and runtime\indexes\product and to keep runtime\indexes\solr as is. I agree it should be configurable and it's worth another issue, I'll create one after closing here, where from my POV all is clear.

        I noticed that Solr separates the index and the data (snapshot_metadata) and not Lucene. For Solr this is related with solr.data.dir definition, in OFBIz it's runtime/indexes/solr (I changed that recently with OFBIZ-7265)

        <dataDir>${solr.data.dir:runtime/indexes/solr}</dataDir>

        I think it's not an issue, our usage of Lucene is OFBiz specific.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Jinghai, Michael, Michael, I would leave it as it is here. Solr uses Lucene for indexing so there is in fact no Solr index but a Lucene index created through Solr. Since the component is named Solr, it makes sense to name it as is. After JInghai's answer, I made a quick review. The runtime\indexes\content and runtime\indexes\product dirs are only used by Lucene. The runtime\indexes\solr is only used by Solr. So I suggest rather to have as defaults runtime\indexes\lucene\content and runtime\indexes\product and to keep runtime\indexes\solr as is. I agree it should be configurable and it's worth another issue, I'll create one after closing here, where from my POV all is clear. I noticed that Solr separates the index and the data (snapshot_metadata) and not Lucene. For Solr this is related with solr.data.dir definition, in OFBIz it's runtime/indexes/solr (I changed that recently with OFBIZ-7265 ) <dataDir>${solr.data.dir:runtime/indexes/solr}</dataDir> I think it's not an issue, our usage of Lucene is OFBiz specific.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        At r1794771 Jinghai committed with this comment

        Updated Solr from 6.2.1 to 6.5.1 and the point fields generated by Lucene are ok now for Solr component. The 'original UI' link is commented in admin.html and the relative files under solr/webapp/solr/tpl are all removed.

        But unfortunately he reintroduced the path for indexes to /runtime/indexes/products which breaks OFBIZ-7265 on this aspect (I then set it to runtime/indexes/solr)

        Show
        jacques.le.roux Jacques Le Roux added a comment - At r1794771 Jinghai committed with this comment Updated Solr from 6.2.1 to 6.5.1 and the point fields generated by Lucene are ok now for Solr component. The 'original UI' link is commented in admin.html and the relative files under solr/webapp/solr/tpl are all removed. But unfortunately he reintroduced the path for indexes to /runtime/indexes/products which breaks OFBIZ-7265 on this aspect (I then set it to runtime/indexes/solr)
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        BTW Shi Jinghai updating from 6.2.1 to 6.5.1 should have been a new issue with the commit referenced, thanks.

        Show
        jacques.le.roux Jacques Le Roux added a comment - BTW Shi Jinghai updating from 6.2.1 to 6.5.1 should have been a new issue with the commit referenced, thanks.

          People

          • Assignee:
            shi.jinghai Shi Jinghai
            Reporter:
            mbrohl Michael Brohl
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile