Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: themes
    • Labels:
      None

      Description

      We already already discussed several times on dev ML to reduce the number of OOTB backend themes and we globally agreed about doing so.

      These themes are still working so we will move them to Attic from where (using svn history) they can be fetch to create expected plugins (tough I'm not sure we can yet create theme-plugins but this is expected)

      If nobody disagree I'll do so in few days...

      BTW the themes I expect to remove in a 1st phase are:

      1. bizzness time, still not complete after several years see OFBIZ-2398
      2. BlueLight, it's subsumed by Tomahawk which is the last variant of this group and more complete
      3. Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of this group and more complete
      4. 3 instances of Rainbow Stone, we need to collectively decide which ones

        Issue Links

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          With rev. 1767881 + 176789 + 1767920 the bizzness time and Dropping Crumbs themes are in Attic. We will see later for the other themes.

          Show
          jacques.le.roux Jacques Le Roux added a comment - With rev. 1767881 + 176789 + 1767920 the bizzness time and Dropping Crumbs themes are in Attic. We will see later for the other themes.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          I'll finally do since we agreed about removing those, but will wait Sharan's opinion for BlueLight

          Show
          jacques.le.roux Jacques Le Roux added a comment - I'll finally do since we agreed about removing those, but will wait Sharan's opinion for BlueLight
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Votes are sent to dev ML

          Show
          jacques.le.roux Jacques Le Roux added a comment - Votes are sent to dev ML
          Hide
          julien.nicolas Julien NICOLAS added a comment -

          Hi Jacques, Pierre, Taher,

          I know well the guy who made Rainbowstone, and I know that Rainbostone is based on Flatgrey because of it works with rtl and because it's the smartest one (ok, this is my opinion ^^ ).

          I don't know if the rtl works in Rainbowstone (lot of modifications since the beginning), but you talk about Rainbowstone as 4 themes but it's only 1 theme that use the same structure. Actually there are 4 less files but I have a tips to change it in 1 main less file and 4 less files for color only. In this way, and if Rainbowstone is the one, you can have 1 theme to maintain and you are able to switch theme \o/

          Another thing that I have in my head, I think that the effort of the community (big up to Taher) need to have a new skin theme. Not for now, but something tells me that Taher have plan to modify "a little" the rendering management and maybe the theme management. So keep in mind that this selected theme could be outdated in a while.

          But I agree, as Christophe Lambert said in Highlander : "There can be only one !"

          Show
          julien.nicolas Julien NICOLAS added a comment - Hi Jacques, Pierre, Taher, I know well the guy who made Rainbowstone, and I know that Rainbostone is based on Flatgrey because of it works with rtl and because it's the smartest one (ok, this is my opinion ^^ ). I don't know if the rtl works in Rainbowstone (lot of modifications since the beginning), but you talk about Rainbowstone as 4 themes but it's only 1 theme that use the same structure. Actually there are 4 less files but I have a tips to change it in 1 main less file and 4 less files for color only. In this way, and if Rainbowstone is the one, you can have 1 theme to maintain and you are able to switch theme \o/ Another thing that I have in my head, I think that the effort of the community (big up to Taher) need to have a new skin theme. Not for now, but something tells me that Taher have plan to modify "a little" the rendering management and maybe the theme management. So keep in mind that this selected theme could be outdated in a while. But I agree, as Christophe Lambert said in Highlander : "There can be only one !"
          Hide
          pfm.smits Pierre Smits added a comment -

          If you would test with only the rainbowstone theme you would know.

          But you are right. Taking the vote(s) will determine the outcome of what remains and what gets disentangled.

          Show
          pfm.smits Pierre Smits added a comment - If you would test with only the rainbowstone theme you would know. But you are right. Taking the vote(s) will determine the outcome of what remains and what gets disentangled.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          I know we have/had at least Arabic users in the Maghreb.

          Show
          jacques.le.roux Jacques Le Roux added a comment - I know we have/had at least Arabic users in the Maghreb.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Why one theme only? How can users test the theme change with only one theme?

          Show
          jacques.le.roux Jacques Le Roux added a comment - Why one theme only? How can users test the theme change with only one theme?
          Hide
          pfm.smits Pierre Smits added a comment - - edited

          No Jacques Le Roux, one must remain. And the rainbowstone theme offers the functionality you desire.

          Show
          pfm.smits Pierre Smits added a comment - - edited No Jacques Le Roux , one must remain. And the rainbowstone theme offers the functionality you desire.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Interesting Pierre, so I think we can vote of removing all themes, but of course we need to keep at least one. Actually even 2, in order to demonstrate OOTB how the theme changing stuff works. I'll prepare a vote, or maybe several. I have to think about it. All ideas are welcome...

          Thanks Taher, I'd be great to have all themes RTL enabled, but that's quite a task... for a minimal ROI...

          Show
          jacques.le.roux Jacques Le Roux added a comment - Interesting Pierre, so I think we can vote of removing all themes, but of course we need to keep at least one. Actually even 2, in order to demonstrate OOTB how the theme changing stuff works. I'll prepare a vote, or maybe several. I have to think about it. All ideas are welcome... Thanks Taher, I'd be great to have all themes RTL enabled, but that's quite a task... for a minimal ROI...
          Hide
          pfm.smits Pierre Smits added a comment - - edited

          Of course we're talking real world users. Not OFBiz contributors.

          Show
          pfm.smits Pierre Smits added a comment - - edited Of course we're talking real world users. Not OFBiz contributors.
          Hide
          taher Taher Alkhateeb added a comment - - edited

          Hello .. RTL guy here I used flatgrey because it is the most well supported RTL theme. However, it would be great at some point to reduce themes and make them all RTL enabled. As I mentioned elsewhere the widgets and themes are in need of a major overhaul.

          Show
          taher Taher Alkhateeb added a comment - - edited Hello .. RTL guy here I used flatgrey because it is the most well supported RTL theme. However, it would be great at some point to reduce themes and make them all RTL enabled. As I mentioned elsewhere the widgets and themes are in need of a major overhaul.
          Hide
          pfm.smits Pierre Smits added a comment -

          For what it is worth: the rainbowstone theme works rtl.

          Show
          pfm.smits Pierre Smits added a comment - For what it is worth: the rainbowstone theme works rtl.
          Hide
          pfm.smits Pierre Smits added a comment -

          Do we even have adopters from rtl countries using flatgrey?
          And how good are the labels regarding rtl translations?

          Before making the assumption that there is a need, it should be investigated first.

          Show
          pfm.smits Pierre Smits added a comment - Do we even have adopters from rtl countries using flatgrey? And how good are the labels regarding rtl translations? Before making the assumption that there is a need, it should be investigated first.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          As long as we have not another RTL supporting theme we can't get rid of flatgrey. Which leads to what should be the other theme? For me it's tomahawk, but I agree this should be voted.

          Show
          jacques.le.roux Jacques Le Roux added a comment - As long as we have not another RTL supporting theme we can't get rid of flatgrey. Which leads to what should be the other theme? For me it's tomahawk, but I agree this should be voted.
          Hide
          pfm.smits Pierre Smits added a comment -

          And flatgrey.

          Show
          pfm.smits Pierre Smits added a comment - And flatgrey.
          Hide
          pfm.smits Pierre Smits added a comment -

          I suggest to consider incorporating tomahawk too.

          Show
          pfm.smits Pierre Smits added a comment - I suggest to consider incorporating tomahawk too.
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          If we need votes, let's go. I think we need at least one for removing "3 instances of Rainbow Stone" anyway

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited If we need votes, let's go. I think we need at least one for removing "3 instances of Rainbow Stone" anyway
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Here are some discussions you find when looking for "remove theme", I think here we really need a new fresh start and not look back.
          http://markmail.org/message/boqhok57dzp3zwpe
          http://markmail.org/message/34z2a4n3nzymv3bu
          http://markmail.org/message/ovdjzmlwn2udqvpm
          http://markmail.org/message/lu6uy67oqkydedvl
          http://markmail.org/thread/lu6uy67oqkydedvl
          We can find much more related discussion, but nothing happened, it's time!

          Show
          jacques.le.roux Jacques Le Roux added a comment - Here are some discussions you find when looking for "remove theme", I think here we really need a new fresh start and not look back. http://markmail.org/message/boqhok57dzp3zwpe http://markmail.org/message/34z2a4n3nzymv3bu http://markmail.org/message/ovdjzmlwn2udqvpm http://markmail.org/message/lu6uy67oqkydedvl http://markmail.org/thread/lu6uy67oqkydedvl We can find much more related discussion, but nothing happened, it's time!
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          You were too fast with your comment, we crossed online

          I'll look for the discussions on the dev ML...

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited You were too fast with your comment, we crossed online I'll look for the discussions on the dev ML...
          Hide
          pfm.smits Pierre Smits added a comment -

          Jacques Le Roux Could you please include the mail thread(s) in which this was discussed.

          Also, could you please list the themes which were agreed upon to get disentangled from trunk?

          Otherwise this issue is very cryptic.

          Show
          pfm.smits Pierre Smits added a comment - Jacques Le Roux Could you please include the mail thread(s) in which this was discussed. Also, could you please list the themes which were agreed upon to get disentangled from trunk? Otherwise this issue is very cryptic.

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              jacques.le.roux Jacques Le Roux
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development