Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-8292

Use ignore_missing option of the <#include Freemarker directive when fixed

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None

      Description

      Working on OFBIZ-8250 and after Deepak at OFBIZ-7942 (too bad I missed that :/) I found that the ignore_missing option of the <#include Freemarker directive does not work. I reported to the Freemarker incubating project.

      Hopefully this will be fixed. It will then remove the need of creating empty files for the svn and git info footers when building.

      In the meantime I'll provide the change in the themes footers.

        Issue Links

          Activity

          Hide
          deepak.dixit Deepak Dixit added a comment -

          Thanks Jacopo

          Show
          deepak.dixit Deepak Dixit added a comment - Thanks Jacopo
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Great, thanks Jacopo!

          Show
          jacques.le.roux Jacques Le Roux added a comment - Great, thanks Jacopo!
          Hide
          jacopoc Jacopo Cappellato added a comment -

          Fix committed in trunk with rev. 1761586

          Show
          jacopoc Jacopo Cappellato added a comment - Fix committed in trunk with rev. 1761586
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          This is currently handled at FREEMARKER-34

          Show
          jacques.le.roux Jacques Le Roux added a comment - This is currently handled at FREEMARKER-34
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          I just created OFBIZ-8293. It seems enough to me at the moment

          Show
          jacques.le.roux Jacques Le Roux added a comment - I just created OFBIZ-8293 . It seems enough to me at the moment
          Hide
          pfm.smits Pierre Smits added a comment -

          So 1 hour ago you suggested to have a new issue created. And already now you are complaining that it hasn't been done yet. Does this deserve such a high priority?

          When something is suggested to nobody, only nobody will take the bait and scratch that itch...

          Visavis the subject already having been discussed, I suspect that the outcome delivered something actionable. Can you provide a link to that outcome? Or is it another discussion still open?

          Show
          pfm.smits Pierre Smits added a comment - So 1 hour ago you suggested to have a new issue created. And already now you are complaining that it hasn't been done yet. Does this deserve such a high priority? When something is suggested to nobody, only nobody will take the bait and scratch that itch... Visavis the subject already having been discussed, I suspect that the outcome delivered something actionable. Can you provide a link to that outcome? Or is it another discussion still open?
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Since you rightly commented with

          I don't believe that a dependency from one theme on another optional is such a good idea.

          I thought you would provide a Jira for that .

          Nevertheless I'll create one for removing some themes OOTB. This has been already discussed on dev ML and we globally agreed about doing so.

          Show
          jacques.le.roux Jacques Le Roux added a comment - Since you rightly commented with I don't believe that a dependency from one theme on another optional is such a good idea. I thought you would provide a Jira for that . Nevertheless I'll create one for removing some themes OOTB. This has been already discussed on dev ML and we globally agreed about doing so.
          Hide
          pfm.smits Pierre Smits added a comment -

          The discussion on how many and which theme(s) should be disentangled is not to be done in this issue.

          Show
          pfm.smits Pierre Smits added a comment - The discussion on how many and which theme(s) should be disentangled is not to be done in this issue.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          You are right, it's one of the cases where a copy is better: to break a wrong dependency. I suggest another Jira for that, thanks!

          BTW one day we should tackle the themes, do we really need all of them and why 4 colored Rainbowstone themes? :-o

          Show
          jacques.le.roux Jacques Le Roux added a comment - You are right, it's one of the cases where a copy is better: to break a wrong dependency. I suggest another Jira for that, thanks! BTW one day we should tackle the themes, do we really need all of them and why 4 colored Rainbowstone themes? :-o
          Hide
          pfm.smits Pierre Smits added a comment - - edited

          I don't believe that a dependency from one theme on another optional is such a good idea.

          Show
          pfm.smits Pierre Smits added a comment - - edited I don't believe that a dependency from one theme on another optional is such a good idea.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          At revision: 1761392 I have commited a no functional change except for the flatgrey and blueligth themes where svn and git info are added

          This provides the change in the themes footers.
          I have also added the svn and git info to the flatgrey footer. The result is barely legible there but is also used (include) by the bluelight theme where it's OK
          I have also formatted the related div where it was barely legible (too large)

          Show
          jacques.le.roux Jacques Le Roux added a comment - At revision: 1761392 I have commited a no functional change except for the flatgrey and blueligth themes where svn and git info are added This provides the change in the themes footers. I have also added the svn and git info to the flatgrey footer. The result is barely legible there but is also used (include) by the bluelight theme where it's OK I have also formatted the related div where it was barely legible (too large)

            People

            • Assignee:
              jacopoc Jacopo Cappellato
              Reporter:
              jacques.le.roux Jacques Le Roux
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development