Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-8265

Bursted Layout in screen "orderstatus" of ecommerce

    Details

    • Sprint:
      Community Day 3 - 2016

      Description

      The layout of screen "order status" of application "ecommerce" is bursted .
      URL: https://localhost:8443/ecommerce/control/orderstatus?orderId=WSCO10000

      I save the html of the screen into my local file, and It works fine.
      I don't know the reason exactly, but the patch attached by me works correctly.

      1. OFBIZ-8265_BurstedLayoutInOrderStatusOfEcommerce.patch
        3 kB
        fumiyoshi.to
      2. screenshot-1.png
        38 kB
        fumiyoshi.to
      3. screenshot-2.png
        27 kB
        fumiyoshi.to

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Hi fumiyoshi.to,

        Before I commit your patch, after having fixed typo introduced by r1761135 for OFBIZ-7949, could you please explain why you moved the addCommonToCartForm from OrderStatus.ftl to OrderItems.ftl? Thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi fumiyoshi.to, Before I commit your patch, after having fixed typo introduced by r1761135 for OFBIZ-7949 , could you please explain why you moved the addCommonToCartForm from OrderStatus.ftl to OrderItems.ftl? Thanks!
        Hide
        tofumiyoshi@gmail.com fumiyoshi.to added a comment -

        Hi Jacques Le Roux
        I'm sorry, I don't know the reason exactly. I move it because it works.
        I know that the patch provided by me is poor from designing standard.
        It need improvement.

        Show
        tofumiyoshi@gmail.com fumiyoshi.to added a comment - Hi Jacques Le Roux I'm sorry, I don't know the reason exactly. I move it because it works. I know that the patch provided by me is poor from designing standard. It need improvement.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks fumiyoshi.to, I will try to understand why we need that. If I can't I'll commit as is, because indeed it fixes the issue

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks fumiyoshi.to, I will try to understand why we need that. If I can't I'll commit as is, because indeed it fixes the issue
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Thanks fumiyoshi.to,

        After review I agree it's the right way to fix. OrderStatus.ftl indirectly calls OrderItems.ftl through the orderitems screen so nothing is lost when the addCommonToCartForm is moved from OrderStatus.ftl to OrderItems.ft, it's only a rearrangement which fixes the issue, well spotted!

        Your patch is in
        trunk r1761431
        R15.12, 14.12, 13.07 r1761497

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Thanks fumiyoshi.to, After review I agree it's the right way to fix. OrderStatus.ftl indirectly calls OrderItems.ftl through the orderitems screen so nothing is lost when the addCommonToCartForm is moved from OrderStatus.ftl to OrderItems.ft, it's only a rearrangement which fixes the issue, well spotted! Your patch is in trunk r1761431 R15.12, 14.12, 13.07 r1761497
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I found an issue due to changes above while working on OFBIZ-7317 (unrelated).
        We should only show the addCommonToCartForm when in status mode, ie when maySelectItems="y", fixed in all at r1763013

        Show
        jacques.le.roux Jacques Le Roux added a comment - I found an issue due to changes above while working on OFBIZ-7317 (unrelated). We should only show the addCommonToCartForm when in status mode, ie when maySelectItems="y", fixed in all at r1763013

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            tofumiyoshi@gmail.com fumiyoshi.to
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile