Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-8048

Show "Any", where allow-empty is set true in Find Screens.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      At some places in drop-down it shows empty title (generated through form widget) and at some places it shows "Any" (in ftl).So need to make them consistent.

      We can either enhance form widget render to show "Any" while rendering drop-down where allow-empty is set to true or we can change drop-down option from "Any" to empty in freemarker files.

      My preference is to use empty instead of "Any". "Any" make sense on find screen but on create/update form it does not make sense. So its good idea if we use empty as generic solution.

      1. OFBIZ-8048.patch
        0.7 kB
        Renuka Srishti

        Activity

        Hide
        deepak.dixit Deepak Dixit added a comment -

        I think empty option make more sense to me. As Any option looks good for find screen but apart from find screen it does not make sense as business logic may be different for empty values.

        Show
        deepak.dixit Deepak Dixit added a comment - I think empty option make more sense to me. As Any option looks good for find screen but apart from find screen it does not make sense as business logic may be different for empty values.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        +1

        Show
        jacques.le.roux Jacques Le Roux added a comment - +1
        Hide
        Renuka_Srishti Renuka Srishti added a comment -

        Here is the patch.

        Show
        Renuka_Srishti Renuka Srishti added a comment - Here is the patch.
        Hide
        jacopoc Jacopo Cappellato added a comment -

        Hi Renuka Srishti, if I am understanding the discussion in this ticket, the proposal that was preferred by you, Deepak and Jacques was to:

        change drop-down option from "Any" to empty in freemarker files

        .
        However your patch seems to address a different task (i.e. removal of "---" separator in the drop down generated by the renderer).
        Could you please clarify? Thank you!

        Show
        jacopoc Jacopo Cappellato added a comment - Hi Renuka Srishti , if I am understanding the discussion in this ticket, the proposal that was preferred by you, Deepak and Jacques was to: change drop-down option from "Any" to empty in freemarker files . However your patch seems to address a different task (i.e. removal of "---" separator in the drop down generated by the renderer). Could you please clarify? Thank you!
        Hide
        Renuka_Srishti Renuka Srishti added a comment -

        Mistakenly I have uploaded patch of another issue. Sorry for inconvenience. I am uploading the right one.

        Show
        Renuka_Srishti Renuka Srishti added a comment - Mistakenly I have uploaded patch of another issue. Sorry for inconvenience. I am uploading the right one.
        Hide
        Renuka_Srishti Renuka Srishti added a comment -

        Here is the patch.

        Show
        Renuka_Srishti Renuka Srishti added a comment - Here is the patch.
        Hide
        jacopoc Jacopo Cappellato added a comment -

        Thanks, your patch is in trunk with rev. 1761236

        Show
        jacopoc Jacopo Cappellato added a comment - Thanks, your patch is in trunk with rev. 1761236

          People

          • Assignee:
            Renuka_Srishti Renuka Srishti
            Reporter:
            Renuka_Srishti Renuka Srishti
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development