Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7969

Enable adding a content to an agreement

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: accounting
    • Labels:
      None
    • Flags:
      Patch

      Description

      This add a screen in accounting component to allow uploading a file or attach an existing content to an agreement. This can be useful to attach agreement related contract or files.

      To test this functionnality, you need to reload seed data, create an agreement and go to page :
      http://localhost:8080/accounting/control/EditAgreementContents?agreementId=XXXX

      1. OFBIZ-7969_V3 .patch
        28 kB
        Leila Mekika
      2. OFBIZ-7969_V3 .patch
        32 kB
        Leila Mekika
      3. OFBIZ-7969_V2 .patch
        33 kB
        Leila Mekika
      4. OFBIZ-7969.patch
        29 kB
        Leila Mekika

        Activity

        Hide
        deepak.dixit Deepak Dixit added a comment -

        Added agreementItemSeqId in AgreementContent entity, now content can be uploaded for item level as well. This has been committed at trunk at r#1766266

        Show
        deepak.dixit Deepak Dixit added a comment - Added agreementItemSeqId in AgreementContent entity, now content can be uploaded for item level as well. This has been committed at trunk at r#1766266
        Hide
        mleila Leila Mekika added a comment -

        ok. Thanks Deepak

        Show
        mleila Leila Mekika added a comment - ok. Thanks Deepak
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        OK, thanks

        Show
        jacques.le.roux Jacques Le Roux added a comment - OK, thanks
        Hide
        deepak.dixit Deepak Dixit added a comment -

        I am planning to add agreementItemSeqId in AgreementContent so that we have ability to upload content by item as well, like OrderContent.

        Show
        deepak.dixit Deepak Dixit added a comment - I am planning to add agreementItemSeqId in AgreementContent so that we have ability to upload content by item as well, like OrderContent.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Please Deepak, why this was reopened?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Please Deepak, why this was reopened?
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Thanks Leila Mekika for your contribution, an slightly modified patch has been committed at r#1759127

        I made following changes:

        • Converted Add Agreement form as used in OOTB, removed content and parentContentId lookup from add form, as we are uploading new file here, we can add new screen let to attach existing content to agreement.
        • Added some additional field on add and list agreement content form like status, content type, fromDate etc.
        • Used entity-auto engine for AgreementContent entity CRUD operation.
        • Used stream request to serve content instead of simplecontent
        • Removed some unused code related to copyAgreementContent that was not implemented properly, also done some minor improvement related to form.
        Show
        deepak.dixit Deepak Dixit added a comment - Thanks Leila Mekika for your contribution, an slightly modified patch has been committed at r#1759127 I made following changes: Converted Add Agreement form as used in OOTB, removed content and parentContentId lookup from add form, as we are uploading new file here, we can add new screen let to attach existing content to agreement. Added some additional field on add and list agreement content form like status, content type, fromDate etc. Used entity-auto engine for AgreementContent entity CRUD operation. Used stream request to serve content instead of simplecontent Removed some unused code related to copyAgreementContent that was not implemented properly, also done some minor improvement related to form.
        Hide
        mleila Leila Mekika added a comment -

        Hi Deepak,
        Sorry I miss this one. Here is a new version of the patch

        Show
        mleila Leila Mekika added a comment - Hi Deepak, Sorry I miss this one. Here is a new version of the patch
        Hide
        deepak.dixit Deepak Dixit added a comment -

        You have still added uploadAgreementContent as event as well.
        Is there any specific reason for that? I think uploadAgreementContent service will do all the necessary thing and you can all it directly from controller.

        Show
        deepak.dixit Deepak Dixit added a comment - You have still added uploadAgreementContent as event as well. Is there any specific reason for that? I think uploadAgreementContent service will do all the necessary thing and you can all it directly from controller.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Thanks Leila, let me review it.
        You can upload patch with same name. Jira automatically handle versioning

        Show
        deepak.dixit Deepak Dixit added a comment - Thanks Leila, let me review it. You can upload patch with same name. Jira automatically handle versioning
        Hide
        mleila Leila Mekika added a comment -

        Hi Deepak
        and thanks for the review !
        I have just attached a new version of the patch with the changes you suggested: I hope i didn't forgot any.

        Show
        mleila Leila Mekika added a comment - Hi Deepak and thanks for the review ! I have just attached a new version of the patch with the changes you suggested: I hope i didn't forgot any.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Hi Leila,

        I reviewed your patch it looks good to me, some I found some improvement in this patch here is the list of improvement:

        • Add service to createAgreementContent you can refer uploadPartyContent service for the same.
        • Instead of saying createAgreementContent you can rename it to uploadAgreementContent
        • Use entity-auto for basic CRUD operation for AgreementContent.
        • Instead of creating FILE as agreement content type you can use some related name, FILE is more generic name.
        Show
        deepak.dixit Deepak Dixit added a comment - Hi Leila, I reviewed your patch it looks good to me, some I found some improvement in this patch here is the list of improvement: Add service to createAgreementContent you can refer uploadPartyContent service for the same. Instead of saying createAgreementContent you can rename it to uploadAgreementContent Use entity-auto for basic CRUD operation for AgreementContent. Instead of creating FILE as agreement content type you can use some related name, FILE is more generic name.
        Hide
        mleila Leila Mekika added a comment -

        A new version with Help xml data

        Show
        mleila Leila Mekika added a comment - A new version with Help xml data

          People

          • Assignee:
            deepak.dixit Deepak Dixit
            Reporter:
            mleila Leila Mekika
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development