Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7960

css property name correction in flatgrey and rainbowstone themes

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: themes
    • Labels:
      None

      Description

      found some funny css property names. I believe is it a syntax problem. Please verify to make sure I'm correct.

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        This is weird and does not make sense.
        I agree your changes seems good but how did you check?
        BTW this is related with http://svn.apache.org/viewvc?view=revision&revision=1361685 and I wonder if we should still care about IE7, though I guess we should :/

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited This is weird and does not make sense. I agree your changes seems good but how did you check? BTW this is related with http://svn.apache.org/viewvc?view=revision&revision=1361685 and I wonder if we should still care about IE7, though I guess we should :/
        Hide
        wt Wai added a comment -

        I didn't check against ie7. I don't have access to it. Firebug complained about these css properties and I reported it. That's why I asked someone more knowledgeable in this area to verify.

        Show
        wt Wai added a comment - I didn't check against ie7. I don't have access to it. Firebug complained about these css properties and I reported it. That's why I asked someone more knowledgeable in this area to verify.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Since we are not sure about it and nobody never reported a related issue, I suggest we rather properly comment those lines out.

        Withouth other opinions I'll do so in few days.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Since we are not sure about it and nobody never reported a related issue, I suggest we rather properly comment those lines out. Withouth other opinions I'll do so in few days.
        Hide
        wt Wai added a comment -

        Thanks

        Show
        wt Wai added a comment - Thanks
        Hide
        Florian M Montalbano Florian added a comment - - edited

        I found that this is called the "star html hack". It seems to prevent IE7 from applying some CCS rules.
        Source : http://css-discuss.incutio.com/wiki/Star_Html_Hack
        and the hack is claimed deprecated here : https://blogs.msdn.microsoft.com/ie/2005/10/12/call-to-action-the-demise-of-css-hacks-and-broken-pages/
        Does someone still have IE7 to test it ? ; )

        Show
        Florian M Montalbano Florian added a comment - - edited I found that this is called the "star html hack". It seems to prevent IE7 from applying some CCS rules. Source : http://css-discuss.incutio.com/wiki/Star_Html_Hack and the hack is claimed deprecated here : https://blogs.msdn.microsoft.com/ie/2005/10/12/call-to-action-the-demise-of-css-hacks-and-broken-pages/ Does someone still have IE7 to test it ? ; )
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Florian!

        I believe the best to do is to comment this in the css files where it's used with a TODO to remember to remove it one day and let it like that for now. With the comments people will understand they can ignore the Firebug or such warnings. Wai, would you take the burden, or you Florian?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Florian! I believe the best to do is to comment this in the css files where it's used with a TODO to remember to remove it one day and let it like that for now. With the comments people will understand they can ignore the Firebug or such warnings. Wai, would you take the burden, or you Florian?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Or maybe we can remove it already?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Or maybe we can remove it already?
        Hide
        Florian M Montalbano Florian added a comment -

        We should remove them, according to the link posted earlier, because it shouldn't work anymore.
        On this site : http://www.dynamicsitesolutions.com/css/filters/star-html/ , they say that the hack works only if IE7 is in backward compatibility mode (quirks mode).

        Moreover, since the support of this browser is not available anymore, I would say that we can safely delete them. But I know that some companies are reluctant to upgrade some software, so if any of them are still using IE7 in backward compatibility mode and updating their OFBiz version ... they should see this issue as a stepping stone to update to IE11.

        Show
        Florian M Montalbano Florian added a comment - We should remove them, according to the link posted earlier, because it shouldn't work anymore. On this site : http://www.dynamicsitesolutions.com/css/filters/star-html/ , they say that the hack works only if IE7 is in backward compatibility mode (quirks mode). Moreover, since the support of this browser is not available anymore, I would say that we can safely delete them. But I know that some companies are reluctant to upgrade some software, so if any of them are still using IE7 in backward compatibility mode and updating their OFBiz version ... they should see this issue as a stepping stone to update to IE11.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Thanks Wai for report, Florian for research.

        I think we can safely remove it from trunk
        http://gs.statcounter.com/#browser_version_partially_combined-ww-monthly-201507-201607
        http://www.w3schools.com/browsers/browsers_explorer.asp

        Done at r1757469

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Thanks Wai for report, Florian for research. I think we can safely remove it from trunk http://gs.statcounter.com/#browser_version_partially_combined-ww-monthly-201507-201607 http://www.w3schools.com/browsers/browsers_explorer.asp Done at r1757469
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Yes thanks Florian, I eventually did it at r1757469. I faced issue with the *.less type missing in the svn config file. All done now.

        I had the comment below ready for closing, and forgot to change from to r1757469, I'll do that now, still shaving the yak

        Show
        jacques.le.roux Jacques Le Roux added a comment - Yes thanks Florian, I eventually did it at r1757469. I faced issue with the *.less type missing in the svn config file. All done now. I had the comment below ready for closing, and forgot to change from to r1757469, I'll do that now, still shaving the yak

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            wt Wai
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development