Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7918

Improve Dutch labels regarding accounting reports

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: accounting
    • Labels:
      None

      Activity

      Hide
      pfm.smits Pierre Smits added a comment -

      This patch addresses the issue.

      Show
      pfm.smits Pierre Smits added a comment - This patch addresses the issue.
      Hide
      pfm.smits Pierre Smits added a comment -

      Ping?

      Show
      pfm.smits Pierre Smits added a comment - Ping?
      Hide
      taher Taher Alkhateeb added a comment -

      Hello, I note there are "new" keys in this patch. Why?

      Show
      taher Taher Alkhateeb added a comment - Hello, I note there are "new" keys in this patch. Why?
      Hide
      pfm.smits Pierre Smits added a comment -

      Because of improvements on accounting report forms I am still working on.

      Show
      pfm.smits Pierre Smits added a comment - Because of improvements on accounting report forms I am still working on.
      Hide
      taher Taher Alkhateeb added a comment -

      Then these keys do not belong in this JIRA and should be submitted together with the report improvements. Otherwise, again we add to the mess. The labels in OFBiz are one area with a big mess and many keys that are not used anywhere and should be deleted.

      Show
      taher Taher Alkhateeb added a comment - Then these keys do not belong in this JIRA and should be submitted together with the report improvements. Otherwise, again we add to the mess. The labels in OFBiz are one area with a big mess and many keys that are not used anywhere and should be deleted.
      Hide
      taher Taher Alkhateeb added a comment -

      Also I could be wrong, but my understanding for Assignee is the person who will commit the code, to avoid conflict with other committers who might want to help and commit the work. When you put yourself as the assignee, then it becomes confusing who is going to commit.

      Show
      taher Taher Alkhateeb added a comment - Also I could be wrong, but my understanding for Assignee is the person who will commit the code, to avoid conflict with other committers who might want to help and commit the work. When you put yourself as the assignee, then it becomes confusing who is going to commit.
      Hide
      pfm.smits Pierre Smits added a comment -

      You are indeed wrong (to some extend at least). The assignee is the primary person working on the issue. This has been discussed before in the dev ml. If you want to revisit that, please do it there.

      Show
      pfm.smits Pierre Smits added a comment - You are indeed wrong (to some extend at least). The assignee is the primary person working on the issue. This has been discussed before in the dev ml. If you want to revisit that, please do it there.
      Hide
      jacopoc Jacopo Cappellato added a comment -

      Pierre, as I have already mentioned to you in another Jira ticket yesterday [*], when you contribute a patch, you should base it on a pristine version of the trunk (or branch) you are willing to contribute to.

      [*] https://issues.apache.org/jira/browse/OFBIZ-7016?focusedCommentId=15432278&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15432278

      Show
      jacopoc Jacopo Cappellato added a comment - Pierre, as I have already mentioned to you in another Jira ticket yesterday [*] , when you contribute a patch, you should base it on a pristine version of the trunk (or branch) you are willing to contribute to. [*] https://issues.apache.org/jira/browse/OFBIZ-7016?focusedCommentId=15432278&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15432278
      Hide
      jacopoc Jacopo Cappellato added a comment -

      but once you are done, and your message in the dev list soliciting feedback from committers seems to suggest that you are, you should unassign the ticket.

      Show
      jacopoc Jacopo Cappellato added a comment - but once you are done, and your message in the dev list soliciting feedback from committers seems to suggest that you are, you should unassign the ticket.
      Hide
      taher Taher Alkhateeb added a comment -

      A little help with the reference please?

      Show
      taher Taher Alkhateeb added a comment - A little help with the reference please?
      Hide
      pfm.smits Pierre Smits added a comment -

      Thank you, Jacopo Cappellato. I got the message already the last time. This patch is a month old.
      If committers were more willing to collaborate with the non-privileged contributors , patches would take so much time to get in, and dilutions would be less.

      Show
      pfm.smits Pierre Smits added a comment - Thank you, Jacopo Cappellato . I got the message already the last time. This patch is a month old. If committers were more willing to collaborate with the non-privileged contributors , patches would take so much time to get in, and dilutions would be less.
      Hide
      pfm.smits Pierre Smits added a comment -

      It seems I am not done, right?
      If a committer wants to take over an issue to follow it up, he can assign himself....

      Show
      pfm.smits Pierre Smits added a comment - It seems I am not done, right? If a committer wants to take over an issue to follow it up, he can assign himself....
      Hide
      pfm.smits Pierre Smits added a comment -

      But your digressing of the original intend of the issue. If you want to revisit processes, please do so in the dev ml.

      Show
      pfm.smits Pierre Smits added a comment - But your digressing of the original intend of the issue. If you want to revisit processes, please do so in the dev ml.
      Hide
      pfm.smits Pierre Smits added a comment -

      This is a revised patch, excluding the inclusions of new keys in the previous patch.

      Show
      pfm.smits Pierre Smits added a comment - This is a revised patch, excluding the inclusions of new keys in the previous patch.
      Hide
      taher Taher Alkhateeb added a comment -

      Please pay attention. You still have the new key "AccountingClosingBalance"

      Show
      taher Taher Alkhateeb added a comment - Please pay attention. You still have the new key "AccountingClosingBalance"
      Hide
      jacopoc Jacopo Cappellato added a comment -

      If you got the message then, before soliciting feedback from committers on this patch as you did one hour ago, you could have fixed your patch.
      About your last sentence: I am not going to reply because I don't want to be dragged into a fight.

      Show
      jacopoc Jacopo Cappellato added a comment - If you got the message then, before soliciting feedback from committers on this patch as you did one hour ago, you could have fixed your patch. About your last sentence: I am not going to reply because I don't want to be dragged into a fight.
      Hide
      taher Taher Alkhateeb added a comment -

      This statement is not called for. Here we are interacting with you based on your email to ML, we are also checking the quality of your work and making comments on what is wrong with it (twice so far)

      Show
      taher Taher Alkhateeb added a comment - This statement is not called for. Here we are interacting with you based on your email to ML, we are also checking the quality of your work and making comments on what is wrong with it (twice so far)
      Hide
      pfm.smits Pierre Smits added a comment -

      Thanks, Taher. I indeed must have gotten distracted somehow/somewhere.

      My apologies for the inconvenience.

      Show
      pfm.smits Pierre Smits added a comment - Thanks, Taher. I indeed must have gotten distracted somehow/somewhere. My apologies for the inconvenience.
      Hide
      taher Taher Alkhateeb added a comment - - edited

      Hi Pierre,

      Before committing, I don't know Dutch so I want to confirm whether your below is a translation and not formatting only for one language:

      -        <value xml:lang="nl">Verwerkte totalen</value>
      +        <value xml:lang="nl">Totalen: verwerkt</value>
      
      -        <value xml:lang="nl">Totalen onverwerkt</value>
      +        <value xml:lang="nl">Totalen: onverwerkt</value>
      

      If this is a re-formatting issue, then we might as well fix it for the English version as well?

      Show
      taher Taher Alkhateeb added a comment - - edited Hi Pierre, Before committing, I don't know Dutch so I want to confirm whether your below is a translation and not formatting only for one language: - <value xml:lang= "nl" >Verwerkte totalen</value> + <value xml:lang= "nl" >Totalen: verwerkt</value> - <value xml:lang= "nl" >Totalen onverwerkt</value> + <value xml:lang= "nl" >Totalen: onverwerkt</value> If this is a re-formatting issue, then we might as well fix it for the English version as well?
      Hide
      pfm.smits Pierre Smits added a comment -

      Yes, it has different semantic implications.

      I would say fixing the English variant can be addressed later.

      Show
      pfm.smits Pierre Smits added a comment - Yes, it has different semantic implications. I would say fixing the English variant can be addressed later.
      Hide
      taher Taher Alkhateeb added a comment -

      Committed in revision 1757498. not very happy with leaving the English versions formatted differently, but this is minor and can be fixed in a later iteration

      Show
      taher Taher Alkhateeb added a comment - Committed in revision 1757498. not very happy with leaving the English versions formatted differently, but this is minor and can be fixed in a later iteration
      Hide
      pfm.smits Pierre Smits added a comment -

      Thanks Taher,

      Show
      pfm.smits Pierre Smits added a comment - Thanks Taher,

        People

        • Assignee:
          pfm.smits Pierre Smits
          Reporter:
          pfm.smits Pierre Smits
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development