Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: order
    • Labels:
      None
    • Sprint:
      Bug Crush Event - 21/2/2015, Community Day 3 - 2016

      Description

      Remove inline js for toggleAll, checkToggle and selectAll calling from ftls in Order component. Add class="selectAll" on parent checkbox element for select all functionality.

      1. OFBIZ-7896.patch
        6 kB
        Amardeep Singh Jhajj

        Activity

        Hide
        pandeypranay Pranay Pandey added a comment -

        Thanks Amardeep Singh Jhajj for the contribution.
        You patch is in trunk r1761180.

        Show
        pandeypranay Pranay Pandey added a comment - Thanks Amardeep Singh Jhajj for the contribution. You patch is in trunk r1761180.
        Hide
        amardeepsj Amardeep Singh Jhajj added a comment -

        Steps to test it:

        Test selectAll functionality over ReturnItems screen.

        1. Create Return.
        2. Go to return item screen- https://ofbiz-trunk.hotwaxsystems.com/ordermgr/control/returnItems
        3. Check/ Uncheck parent checkbox, its all child boxes should be checked/unchecked.
        4. Parent checkbox should be checked, if its all child boxes is checked.

        Test selectAll functionality over order items screen.

        1. Go to order entry.
        2. Next, go to order items screen and add products to order.
        3. Check/ Uncheck parent checkbox of order items, its all child boxes should be checked/unchecked.
        4. Parent checkbox should be checked, if its all child boxes is checked.

        Show
        amardeepsj Amardeep Singh Jhajj added a comment - Steps to test it: Test selectAll functionality over ReturnItems screen. 1. Create Return. 2. Go to return item screen- https://ofbiz-trunk.hotwaxsystems.com/ordermgr/control/returnItems 3. Check/ Uncheck parent checkbox, its all child boxes should be checked/unchecked. 4. Parent checkbox should be checked, if its all child boxes is checked. Test selectAll functionality over order items screen. 1. Go to order entry. 2. Next, go to order items screen and add products to order. 3. Check/ Uncheck parent checkbox of order items, its all child boxes should be checked/unchecked. 4. Parent checkbox should be checked, if its all child boxes is checked.
        Hide
        amardeepsj Amardeep Singh Jhajj added a comment -

        Please find attached patch for removal of inline toggleAll, checkToggle and selectAll function calling from ftls. Also removed redundant functions present in Javascript.ftl, which was used at one place only. Thanks.

        Show
        amardeepsj Amardeep Singh Jhajj added a comment - Please find attached patch for removal of inline toggleAll, checkToggle and selectAll function calling from ftls. Also removed redundant functions present in Javascript.ftl, which was used at one place only. Thanks.

          People

          • Assignee:
            pandeypranay Pranay Pandey
            Reporter:
            amardeepsj Amardeep Singh Jhajj
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile