Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7892

Move *CertKeystore.groovy* to location according to best practice

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 16.11.01
    • Component/s: framework/webtools
    • Labels:
      None

      Description

      Currently the CertKeystore.groovy is located in framework/common/webcommon/WEB-INF/actions/certs. This file should move to the location in accordance to best practices.

      The dependencies need to be adjusted.

        Activity

        Hide
        deepak.dixit Deepak Dixit added a comment -

        Hi Pierre Smits,

        I think instead of reporting new issue we can reopen OFBIZ-6302, as this groovy introduced in mentioned issue.

        Show
        deepak.dixit Deepak Dixit added a comment - Hi Pierre Smits , I think instead of reporting new issue we can reopen OFBIZ-6302 , as this groovy introduced in mentioned issue.
        Hide
        pfm.smits Pierre Smits added a comment -

        That issue was dealt with. And it created a new issue, as the implemented patch was not reflecting OFBIZ-7218. In stead of revisiting closed tasks it is customary to open new ones, as I did.

        But if you want to address the issue of enhancing OFBiz best practices with respect to JIRA issues, feel free to open a discussion in dev ml.

        Show
        pfm.smits Pierre Smits added a comment - That issue was dealt with. And it created a new issue, as the implemented patch was not reflecting OFBIZ-7218 . In stead of revisiting closed tasks it is customary to open new ones, as I did. But if you want to address the issue of enhancing OFBiz best practices with respect to JIRA issues, feel free to open a discussion in dev ml.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Hi Pierre Smits,

        OFBIZ-6302 not closed yet, its an resolved status.

        And Jacques Le Roux added comment

        >>I don't close to let you check all is allright before closing, thanks!

        Show
        deepak.dixit Deepak Dixit added a comment - Hi Pierre Smits , OFBIZ-6302 not closed yet, its an resolved status. And Jacques Le Roux added comment >>I don't close to let you check all is allright before closing, thanks!
        Hide
        pfm.smits Pierre Smits added a comment -

        It is now.

        Show
        pfm.smits Pierre Smits added a comment - It is now.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Done at r1753196, thanks for the request Pierre

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Done at r1753196, thanks for the request Pierre

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development