Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: accounting
    • Labels:
      None

      Description

      Required improvements;

      • All is good with entity definition .
      • Add crud services using entity-auto. Make sure PK is not optional while create service.
      • Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented.
      • As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service.

        Activity

        Hide
        arunpati Arun Patidar added a comment -

        Committed changes in trunk at rev: 1759072.

        Thanks Rishi Solanki and Amit Gadaley for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed changes in trunk at rev: 1759072. Thanks Rishi Solanki and Amit Gadaley for your contribution.
        Hide
        amit.gadaley Amit Gadaley added a comment -

        Provided patch. Thanks Arun Patidar and Rishi Solanki for the guidance.

        Show
        amit.gadaley Amit Gadaley added a comment - Provided patch. Thanks Arun Patidar and Rishi Solanki for the guidance.
        Hide
        rishisolankii Rishi Solanki added a comment -

        Community, we decided to not provide delete operation for this entity, could you please help us here, what should we do in such cases. Here no from date/thru date or status field exists. But it contains the historical data IMO, and as per the entity def it can not (and should not) expire.

        We have two option;
        1) Do not provide delete service for such cases. (In ticket description I proposed to follow this.)
        2) Provide delete service and let the business user decide weather to remove any record or not. We can add description in the service something like; "Entity contains historical data, and ideally not used."

        Show
        rishisolankii Rishi Solanki added a comment - Community, we decided to not provide delete operation for this entity, could you please help us here, what should we do in such cases. Here no from date/thru date or status field exists. But it contains the historical data IMO, and as per the entity def it can not (and should not) expire. We have two option; 1) Do not provide delete service for such cases. (In ticket description I proposed to follow this.) 2) Provide delete service and let the business user decide weather to remove any record or not. We can add description in the service something like; "Entity contains historical data, and ideally not used."

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            rishisolankii Rishi Solanki
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development