Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: ebaystore
    • Labels:
      None
    • Sprint:
      2016 - OFBiz Community Day 4

      Description

      Client side validations are missing at 'Add Ebay Configuration' feature. Error from server side is being thrown if we do not provide the required fields.

        Activity

        Hide
        Florian M Montalbano Florian added a comment -

        HI,
        I looked at this issue and I was wondering the meaning of the value "Any" from the drop down for the Product Store.

        Does that mean that the configuration should be applied for every store ? Or to none ?

        I don't have much experience in the ebay component. What is the goal of an "Ebay Configuration" ?

        Have a nice day,
        Thanks.

        Show
        Florian M Montalbano Florian added a comment - HI, I looked at this issue and I was wondering the meaning of the value "Any" from the drop down for the Product Store. Does that mean that the configuration should be applied for every store ? Or to none ? I don't have much experience in the ebay component. What is the goal of an "Ebay Configuration" ? Have a nice day, Thanks.
        Hide
        deepak.nigam Deepak Nigam added a comment - - edited

        Hii Montalbano Florian

        IMO use of value 'Any' is not making sense here as productStoreId is a compulsory field in the service 'createEbayConfiguration'. Instead of 'Any' an empty / blank option should be provided and productStoreId should be made required to avoid unintentional selection of first / default productStoreId.

        Ebay Configuration is used for storing all the configuration related data required in OFBiz-eBay integration.

        Show
        deepak.nigam Deepak Nigam added a comment - - edited Hii Montalbano Florian IMO use of value 'Any' is not making sense here as productStoreId is a compulsory field in the service 'createEbayConfiguration'. Instead of 'Any' an empty / blank option should be provided and productStoreId should be made required to avoid unintentional selection of first / default productStoreId. Ebay Configuration is used for storing all the configuration related data required in OFBiz-eBay integration.
        Hide
        deepak.nigam Deepak Nigam added a comment -

        Attaching the patch for the issue in which used empty / blank value in place of 'Any' value of productStoreId and made it required.

        Show
        deepak.nigam Deepak Nigam added a comment - Attaching the patch for the issue in which used empty / blank value in place of 'Any' value of productStoreId and made it required.
        Hide
        mbrohl Michael Brohl added a comment -

        Thanks Deepak,

        your patch is in trunk r1774805.

        Show
        mbrohl Michael Brohl added a comment - Thanks Deepak, your patch is in trunk r1774805.

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            deepak.nigam Deepak Nigam
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile