Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 16.11.01
    • Component/s: manufacturing
    • Labels:
      None

      Description

      Clean up commented out code in Java source for Manufacturing

      1. OFBIZ-7548.patch
        16 kB
        Harsh Vijaywargiya
      2. OFBIZ-7848-added-log-execption.patch
        1 kB
        Harsh Vijaywargiya

        Activity

        Hide
        toashishvijay Ashish Vijaywargiya added a comment -

        Thanks Harsh for the contribution. Committed your changes in trunk at r1757991.

        Show
        toashishvijay Ashish Vijaywargiya added a comment - Thanks Harsh for the contribution. Committed your changes in trunk at r1757991.
        Hide
        harshvijay Harsh Vijaywargiya added a comment -

        As per discussion provided patch to add the log statements in catch block to avoid silent exceptions.

        Show
        harshvijay Harsh Vijaywargiya added a comment - As per discussion provided patch to add the log statements in catch block to avoid silent exceptions.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Harsh,

        Your slightly enhanced patch is in trunk at revision: 1761124

        I also changed a "if (Debug.infoOn()) Debug.logInfo" to always print an error in case of catched exception

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Harsh, Your slightly enhanced patch is in trunk at revision: 1761124 I also changed a "if (Debug.infoOn()) Debug.logInfo" to always print an error in case of catched exception

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            harshvijay Harsh Vijaywargiya
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development