Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7830

Upload Communication Content functionality is not working from the Internal Note creation screen

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: party
    • Labels:
      None

      Description

      1) Go to Party component.
      2) Navigate to My Communication page.
      3) Go to create New Internal Note screen.
      4) Here under Communication Content section, try to upload any content.
      Not be able to upload any content.

        Activity

        Hide
        Florian M Montalbano Florian added a comment -

        Hi,
        the problem comes from a javascript error (you can check it with the dev tools inspector of a web navigator).

        When uploading, the javascript called try to access information about an element of the Dom which is "EditEmail" . It is a form that does exist in OFBiz. But on this page, there is no such form. Instead, we need to access "EditInternalNote" (which has all the information we need).

        I tried to change the javascript of the submit button in the file "CommunicationEventForms.xml" and it works.
        I'm not updating a patch yet because I didn't check if the same form was used to upload content for an email and for an internal note (then it would repair one form while breaking the other).

        Btw, there is the same problem with "adding a communication event roles" to the email.

        I hope that will be useful.

        Show
        Florian M Montalbano Florian added a comment - Hi, the problem comes from a javascript error (you can check it with the dev tools inspector of a web navigator). When uploading, the javascript called try to access information about an element of the Dom which is "EditEmail" . It is a form that does exist in OFBiz. But on this page, there is no such form. Instead, we need to access "EditInternalNote" (which has all the information we need). I tried to change the javascript of the submit button in the file "CommunicationEventForms.xml" and it works. I'm not updating a patch yet because I didn't check if the same form was used to upload content for an email and for an internal note (then it would repair one form while breaking the other). Btw, there is the same problem with "adding a communication event roles" to the email. I hope that will be useful.
        Hide
        lodhiravi Ravi Lodhi added a comment - - edited

        Thanks for looking into this. There are separate sections to store information related to communication event (Subject, content etc) and for uploading content. So I think there is no need to save subject, content etc. when uploading content.

        Uploaded patch to fix this.

        Show
        lodhiravi Ravi Lodhi added a comment - - edited Thanks for looking into this. There are separate sections to store information related to communication event (Subject, content etc) and for uploading content. So I think there is no need to save subject, content etc. when uploading content. Uploaded patch to fix this.
        Hide
        toashishvijay Ashish Vijaywargiya added a comment -

        Thanks Ravi for the contribution. Your changes are committed in trunk at r1758013

        Show
        toashishvijay Ashish Vijaywargiya added a comment - Thanks Ravi for the contribution. Your changes are committed in trunk at r1758013

          People

          • Assignee:
            toashishvijay Ashish Vijaywargiya
            Reporter:
            lodhiravi Ravi Lodhi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development