Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7821

Remove unused system generated fields from all data files

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: None
    • Labels:
      None

      Description

      There are four system generated fields for every entity as lastUpdatedStamp, lastUpdatedTxStamp, createdStamp and createdTxStamp
      To increase readability of data files, these fields are not necessary to be there in data files, as it gets generated every time when data load occurs.
      This ticket will be served as a parent ticket and I will be creating child tickets component wise for all affected components.

        Activity

        Hide
        pfm.smits Pierre Smits added a comment -

        Hold on for a moment and please thread carefully. In another issue we are discussing about making this more configurable or extended in cerain places. See OFBIZ-7781. Feel free to join in there and add your input. It will help to get to a common consensus.

        Show
        pfm.smits Pierre Smits added a comment - Hold on for a moment and please thread carefully. In another issue we are discussing about making this more configurable or extended in cerain places. See OFBIZ-7781 . Feel free to join in there and add your input. It will help to get to a common consensus.
        Hide
        suraj.khurana Suraj Khurana added a comment -

        Thanks Pierre Smits for your inputs.
        In this ticket, I am just proposing to clean up existing data files as per the current practices around these fields.

        Show
        suraj.khurana Suraj Khurana added a comment - Thanks Pierre Smits for your inputs. In this ticket, I am just proposing to clean up existing data files as per the current practices around these fields.
        Hide
        pfm.smits Pierre Smits added a comment -

        Hi Suraj Khurana,

        I understand. That is why I suggested not to spend effort on this ticket until there is consensus regarding what to do with the default fields (as these are).

        Show
        pfm.smits Pierre Smits added a comment - Hi Suraj Khurana , I understand. That is why I suggested not to spend effort on this ticket until there is consensus regarding what to do with the default fields (as these are).
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        I see no reasons to not already clean the data files from useless data, readability will improve. Then we should not add new data fields in data files even if we changes things in data model, and even if we do the files will be better then.

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited I see no reasons to not already clean the data files from useless data, readability will improve. Then we should not add new data fields in data files even if we changes things in data model, and even if we do the files will be better then.
        Hide
        mridul.pathak Mridul Pathak added a comment - - edited

        I agree with Jacques Le Roux, data cleanup will only improve existing data in OFBiz and doesn't directly impact or is impacted by conclusion of OFBIZ-7781.

        Show
        mridul.pathak Mridul Pathak added a comment - - edited I agree with Jacques Le Roux , data cleanup will only improve existing data in OFBiz and doesn't directly impact or is impacted by conclusion of OFBIZ-7781 .
        Hide
        rishisolankii Rishi Solanki added a comment -

        +1 for the effort, it takes time to understand a data in data file with four extra fields. Also these fields contains older dates, and create confusions.

        Show
        rishisolankii Rishi Solanki added a comment - +1 for the effort, it takes time to understand a data in data file with four extra fields. Also these fields contains older dates, and create confusions.
        Hide
        mridul.pathak Mridul Pathak added a comment -

        Closing this parent ticket as all the sub tasks are now closed.

        Show
        mridul.pathak Mridul Pathak added a comment - Closing this parent ticket as all the sub tasks are now closed.

          People

          • Assignee:
            mridul.pathak Mridul Pathak
            Reporter:
            suraj.khurana Suraj Khurana
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development