Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7798

Translate the svn and git info footers

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None
    • Sprint:
      Community Day 3 - 2016

      Description

      We slightly changed the old format of the footer. The old format used only the translated words uiLabelMap.CommonBuiltOn and uiLabelMap.CommonWith. On the other hand, the new format contains the words Branch, Revision, Built On and Java Version.

      We need to translate all four words in the CommonUiLabels.xml and then incorporate them

      old version:

      " - Release-revision : ${releasePath}-r${info.entry.commit(revision)},  ${uiLabelMap.CommonBuiltOn} ${dateTime} ${uiLabelMap.CommonWith} Java ${java.version}
      

      new version:

      "Branch: ${info.entry.url.text()}" + System.lineSeparator()
      "Revision: ${info.entry.commit.@revision}" + System.lineSeparator()
      "Built on: ${timestamp}" + System.lineSeparator()
      "Java Version: ${org.gradle.internal.jvm.Jvm.current()}"
      
      1. OFBIZ-7798.patch
        2 kB
        Taher Alkhateeb

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Completed: At revision: 1762077

        While doing so I noticed an issue with labels cache clearing. I'll create a bug issue for that

        Show
        jacques.le.roux Jacques Le Roux added a comment - Completed: At revision: 1762077 While doing so I noticed an issue with labels cache clearing. I'll create a bug issue for that
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Taher,

        I have commited the patch at r1761076 (with the snippet for Xlint to be replaced with OFBIZ-8251)

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Taher, I have commited the patch at r1761076 (with the snippet for Xlint to be replaced with OFBIZ-8251 )
        Hide
        taher Taher Alkhateeb added a comment -

        Hi Jacques,

        This JIRA already has a solution and a patch (Might need to update it). All that we need here is to reuse some existing labels in uiLabelMap, or create new ones and add them. The Patch shows how this can be done (even if outdated).

        So if you are interested in working on this, then it is quite minor to accomplish. I'm just not sure which ui labels best to use from which XML file.

        Show
        taher Taher Alkhateeb added a comment - Hi Jacques, This JIRA already has a solution and a patch (Might need to update it). All that we need here is to reuse some existing labels in uiLabelMap, or create new ones and add them. The Patch shows how this can be done (even if outdated). So if you are interested in working on this, then it is quite minor to accomplish. I'm just not sure which ui labels best to use from which XML file.
        Hide
        taher Taher Alkhateeb added a comment -

        I am attaching here a solution that you can use to apply the translation. However, you need to check whether the labels provided exist in the uiLabelMaps (whatever component) or use ones that are most appropriate. I use this as an example because I'm not sure what is the best labels to use and the labels I added I think they do not exist.

        Show
        taher Taher Alkhateeb added a comment - I am attaching here a solution that you can use to apply the translation. However, you need to check whether the labels provided exist in the uiLabelMaps (whatever component) or use ones that are most appropriate. I use this as an example because I'm not sure what is the best labels to use and the labels I added I think they do not exist.

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            jacques.le.roux Jacques Le Roux
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile