Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7604

Add lookup for approver party at leave approval find form

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: humanres
    • Labels:
      None

      Description

      Add lookup for approver party at leave approval find form. Currently, it has text field for find.

      1. OFBIZ-7604.patch
        0.8 kB
        Amardeep Singh Jhajj

        Activity

        Hide
        amardeepsj Amardeep Singh Jhajj added a comment -

        Please find attached patch for trunk. Thanks

        Show
        amardeepsj Amardeep Singh Jhajj added a comment - Please find attached patch for trunk. Thanks
        Hide
        pfm.smits Pierre Smits added a comment - - edited

        Have you taken into consideration that not all parties can be an approver of a leave? E.g. external persons, internal organisations, the requestor him/herself, etc.

        Show
        pfm.smits Pierre Smits added a comment - - edited Have you taken into consideration that not all parties can be an approver of a leave? E.g. external persons, internal organisations, the requestor him/herself, etc.
        Hide
        amardeepsj Amardeep Singh Jhajj added a comment -

        Currently, approver can be any party present in system (requestor him/ her), party lookup is present over create leave form. Have a look -

        https://localhost:8443/humanres/control/EditEmplLeave

        I have just added party lookup for find leave approval screen only. Previously, there was a find text field where any partyId can be entered to find. I am not sure whether we should restrict any party to be an approver. If we restrict it then we need to consider the create leave form's party lookup field first.

        Show
        amardeepsj Amardeep Singh Jhajj added a comment - Currently, approver can be any party present in system (requestor him/ her), party lookup is present over create leave form. Have a look - https://localhost:8443/humanres/control/EditEmplLeave I have just added party lookup for find leave approval screen only. Previously, there was a find text field where any partyId can be entered to find. I am not sure whether we should restrict any party to be an approver. If we restrict it then we need to consider the create leave form's party lookup field first.
        Hide
        pandeypranay Pranay Pandey added a comment - - edited

        Hi Amardeep Singh Jhajj,
        Thanks for reporting this issue and providing the patch. Definitely, where your patch can be applied but at the same time, it's debatable that, are we actually adding lot value by adding a lookup for approver party?? I think of an auto-complete will be a better option if need to do something with this field or leaving it as is not a bad idea. Let's discuss.

        Show
        pandeypranay Pranay Pandey added a comment - - edited Hi Amardeep Singh Jhajj , Thanks for reporting this issue and providing the patch. Definitely, where your patch can be applied but at the same time, it's debatable that, are we actually adding lot value by adding a lookup for approver party?? I think of an auto-complete will be a better option if need to do something with this field or leaving it as is not a bad idea. Let's discuss.
        Hide
        pandeypranay Pranay Pandey added a comment -

        Hi Amardeep Singh Jhajj,

        Upon taking a closer look and testing your patch, this improvement is making perfect sense to me as it will definitely add on value to the search field for approver.

        Show
        pandeypranay Pranay Pandey added a comment - Hi Amardeep Singh Jhajj , Upon taking a closer look and testing your patch, this improvement is making perfect sense to me as it will definitely add on value to the search field for approver.
        Hide
        pandeypranay Pranay Pandey added a comment -

        Done in Trunk at r1750447. Thanks Amardeep Singh Jhajj for your contribution.

        Show
        pandeypranay Pranay Pandey added a comment - Done in Trunk at r1750447. Thanks Amardeep Singh Jhajj for your contribution.

          People

          • Assignee:
            pandeypranay Pranay Pandey
            Reporter:
            amardeepsj Amardeep Singh Jhajj
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development