[OFBIZ-7591] Enforce noninstantiability to UtilJavaParse class

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 16.11.01
• Component/s: framework
• Sprint: Community Day 2 - 2016, OFBiz Community Day (May 2020)
• Assignee: Arun Patidar
• Reporter: Rishi Solanki
• Created: 24/Jun/16 09:30
• Updated: 01/Jul/16 15:54
• Resolved: 01/Jul/16 15:54

Description

• Make class as final.
• Add a private constructor.
• Make the following public static variables as private and move them to top of class. Also move the static block initializing it.

          // FIXME: Not thread safe
      public static Set<String> serviceMethodNames = new HashSet<String>();
      static {
          serviceMethodNames.add("runSync");
          serviceMethodNames.add("runSyncIgnore");
          serviceMethodNames.add("runAsync");
          serviceMethodNames.add("runAsyncWait");
          serviceMethodNames.add("registerCallback");
          serviceMethodNames.add("schedule"); // NOTE: the service name may be the 1st, 2nd or 3rd param for variations on this
          serviceMethodNames.add("addRollbackService");
          serviceMethodNames.add("addCommitService");
      }