Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2016

      Description

      • Make class as final.
      • Add a private constructor.
      • Make the following public static variables as private
            public static final String MULTI_ROW_DELIMITER = "_o_";
            public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
            public static final String COMPOSITE_DELIMITER = "_c_";
            public static final int MULTI_ROW_DELIMITER_LENGTH = MULTI_ROW_DELIMITER.length();
            public static final int ROW_SUBMIT_PREFIX_LENGTH = ROW_SUBMIT_PREFIX.length();
            public static final int COMPOSITE_DELIMITER_LENGTH = COMPOSITE_DELIMITER.length();
        
            public static final String SESSION_KEY_TIMEZONE = "timeZone";
        
      • Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(), and use them in following classes/scripts;
            GlEvents.java
            ShoppingCartEvents.java
            CheckAction.groovy
            CheckRejected.groovy
            ServiceMultiEventHandler.java
            EbayEvents.java
        

      No variables needs to be change for this class.

      1. OFBIZ-7589.patch
        8 kB
        Rohit Koushal

        Activity

        Hide
        arunpati Arun Patidar added a comment -

        Committed changes in trunk at rev: 1751026.

        Thanks Rishi Solanki and Rohit Koushal for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed changes in trunk at rev: 1751026. Thanks Rishi Solanki and Rohit Koushal for your contribution.
        Hide
        rohit.koushal Rohit Koushal added a comment -

        Thanks Rishi Solanki for the details. Here is the patch for the ticket

        Show
        rohit.koushal Rohit Koushal added a comment - Thanks Rishi Solanki for the details. Here is the patch for the ticket

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            rishisolankii Rishi Solanki
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile