Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7533

Not able to set new Lot Id to existing inventory item

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 16.11.01
    • Fix Version/s: 16.11.01
    • Component/s: product
    • Labels:
      None

      Description

      When any new lot is assigned to exiting inventory item then it ends up throwing foreign key constraint.

      We could allow it by creating first new lot (if its not found already existent in DB) and then associate the same with given inventory item. (Also currently i couldn't find any screen to create new lot in given facility)

      Please refer to attached screenshot for reference.

      1. II_LOT.png
        310 kB
        Swapnil Shah
      2. OFBIZ-7533.patch
        1 kB
        Ankush Upadhyay

        Issue Links

          Activity

          Hide
          pfm.smits Pierre Smits added a comment - - edited

          The lot management solution in OFBiz is flawed. See OFBIZ-5704

          Show
          pfm.smits Pierre Smits added a comment - - edited The lot management solution in OFBiz is flawed. See OFBIZ-5704
          Hide
          swash78 Swapnil Shah added a comment - - edited

          Thanks for sharing the reference Pierre Smits. I have tried to walk through the discussion but it seems there is still no conclusion made. So irrespective of fact what design approach we follow under OFBIZ-5704, i feel the feature for updating Lot id over an inventory item should still hold water and hence we can possibly attempt to fix this ticket independently for now and later once we have implementation detail concluded with regard to lot, Lot Id provision via inventory item could proved to be an add on.

          Show
          swash78 Swapnil Shah added a comment - - edited Thanks for sharing the reference Pierre Smits . I have tried to walk through the discussion but it seems there is still no conclusion made. So irrespective of fact what design approach we follow under OFBIZ-5704 , i feel the feature for updating Lot id over an inventory item should still hold water and hence we can possibly attempt to fix this ticket independently for now and later once we have implementation detail concluded with regard to lot, Lot Id provision via inventory item could proved to be an add on.
          Hide
          ankush.upadhyay Ankush Upadhyay added a comment -

          Thanks Swapnil Shah for reporting issue, I have added patch to fix this issue.

          Show
          ankush.upadhyay Ankush Upadhyay added a comment - Thanks Swapnil Shah for reporting issue, I have added patch to fix this issue.
          Hide
          diveshdut Divesh Dutta added a comment -

          I have committed Ankush Upadhyay's patch in revision number 1759336 in trunk. Thanks Swapnil Shah for reporting the issue and Ankush for providing the patch.

          Show
          diveshdut Divesh Dutta added a comment - I have committed Ankush Upadhyay 's patch in revision number 1759336 in trunk. Thanks Swapnil Shah for reporting the issue and Ankush for providing the patch.
          Hide
          diveshdut Divesh Dutta added a comment -

          Assigning Swapnil Shah for verification and closure.

          Show
          diveshdut Divesh Dutta added a comment - Assigning Swapnil Shah for verification and closure.
          Hide
          swash78 Swapnil Shah added a comment -

          Thanks Ankush Upadhyay Divesh Dutta for contribution. I validated the fixes as follows and found to be working better now:

          1. Updated the lotId (using non-existent lot) on existing inventoryItem without any error/stack-trace (PASS)
          2. Checked that a new Lot is created in DB (PASS)

          Though i expect that in future we might need to overhaul the existing lot management process (as per OFBIZ-5704) but i reckon many existing users are still using the current version of this feature and the fixes here could be helpful, Closing this ticket for now.

          Show
          swash78 Swapnil Shah added a comment - Thanks Ankush Upadhyay Divesh Dutta for contribution. I validated the fixes as follows and found to be working better now: Updated the lotId (using non-existent lot) on existing inventoryItem without any error/stack-trace ( PASS ) Checked that a new Lot is created in DB ( PASS ) Though i expect that in future we might need to overhaul the existing lot management process (as per OFBIZ-5704 ) but i reckon many existing users are still using the current version of this feature and the fixes here could be helpful, Closing this ticket for now.

            People

            • Assignee:
              swash78 Swapnil Shah
              Reporter:
              swash78 Swapnil Shah
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development